Repository navigation
✨ Let hive decide: operator-action for selfreports, evidence-gated proposals - #15420
Conversation
…oposals Issues parked at stage/045-needs-decision are now judged the way the owner would, with named rules evaluated before default-approve: - selfreport-operator-action: a hive:selfreport whose class is an operator's to fix (agent_login_required, inference auth, disk, App setup, proxy, crux runtime, …) gets one direction comment to the reporting spoke's owner(s), needs-owner, no approved-direction, no implementer, the park kept. Re-deciding a kept-park decision no longer re-posts (the #15021 loop): the repark override is skipped when the decision never lifted the label, and the dedup answer reads "waiting on the spoke owner: @who …". - proposal-approve-evidence: a hive-filed proposal citing an incident or a fixed-one-at-a-time recurrence is approved naming the evidence. - proposal-not-now: a hive-filed proposal without evidence is declined for now — comment + close as not planned (new action close-not-now). Never for a person's proposal, never for hive-policy items. - hive-policy recommendation on an issue is a real sentence. Glossary, JS mirror, plan/preview wording, row result, docs and a changelog fragment follow; the five real issues are table-test fixtures. Fixes #15413 Signed-off-by: Andrew Anderson <andy@clubanderson.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of
|
|
@clubanderson is auto-promoted for contributor-lane merging on this PR: the last 5 merged PRs by this author in this hive's repositories have no revert or sentinel-alert evidence. CI, reviewer verdict, diff fences, soak, holds and branch protection still apply. |
|
@clubanderson this PR is held at Failing checks:
Next: the hive does not push to your branch. Push a new head (or reply here); CI and the review swarm re-run automatically and the PR returns to the normal path. |
|
stage 080-awaiting-merge-admission → 071-needs-author: optional-check-failing:test (rest 1/4) |
…h (writeback ratchet) Signed-off-by: Andrew Anderson <andy@clubanderson.com>
|
Thank you for your contribution! Your PR has been merged. We'd love to hear how your experience was: share feedback |
Fixes #15413
Why
"Let hive decide" on issues parked at
stage/045-needs-decisionfell through todefault-approvefor almost everything, so a[selfreport] agent_login_requiredgot "approved" (then looped: "Hive decided approved … but it hasn't taken effect") and speculative proposals got an implementer agent. The owner looked at five real parked issues and wants the hive to decide the way he would.What
New named rules in
pkg/delegatedecision, evaluated beforedefault-approve(which stays as the last fallback):selfreport-operator-actionhive:selfreportmarker /[selfreport]title AND class has an operator remedy (agent_login_required, credentials/quota/network/config classes frompkg/fleetreport)operator-action— comment tells the reporting spoke's owner(s) exactly what to do,needs-owner, noapproved-direction, stays at 045, never actionable for implementer laneshive-policy(kept)recommend-only, but now with a real recommendation sentenceproposal-approve-evidenceincident #N, "broke … v5", regression) or recurrence ("three-of-a-class", "3rd instance", ≥2 prior#N)approve, rationale names the evidenceproposal-not-nownot-now— comment "no incident or recurrence justifies the cost yet; re-propose with evidence", close as not plannedLoop fix: a decision that keeps the park (
KeepsPark) no longer triggers the "re-parked after decision" override, and re-deciding an already-decided parked item is a no-op that surfaces "already recorded this decision at ; waiting on " instead of posting again.Pure classifiers (
ParseSelfReport,selfreportOpsClass,OperatorInstruction,IsProposal,ProposalEvidence,BotShapedLogin) inissue_judgment.go; ops classes pinned againstpkg/fleetreportby test. Glossary entries (+ JS mirror, regeneratedstatic/index.html), preview/plan and row-result wording in the new verb-first style, docs (dashboard-sections.md,labels-and-control-signals.md), changelog fragment.What the new code produces for the 5 issues (from
TestDecideIssueLikeTheOwner, real bodies as fixtures)[selfreport] agent_login_requiredselfreport-operator-actionoperator-actionstage/045-needs-decisionstays · "What happens next: Nothing by itself. Waiting on the spoke owner." No/hive decisionline, noapproved-direction.hive-policyrecommend-only📝 RFC: admission-side #5117 — hold unacknowledged hive-filed proposals before any kickas proposed — proposals nobody has acknowledged should not be actionable; make it default-on for the lanes it names rather than opt-in; owner to confirm"[quality] gate proposal: shell-checker mutation harnessproposal-not-nownot-now[quality] Gate config: require_current_base — stale-green merge broke v5proposal-approve-evidenceapprove[scanner] Gate proposal: ECMA-48 conformance test (3rd recogniser gap)proposal-approve-evidenceapproveVerification
go build ./...,go vet,go test -racetargeted, fullgo test -count=1 ./pkg/delegatedecision/... ./pkg/dashboard/...,check-api-reference-citations.sh, docs link check — all green after rebase onto #15409.