Skip to content

✨ Let hive decide: operator-action for selfreports, evidence-gated proposals - #15420

Merged
clubanderson merged 2 commits into
v5from
fix/decide-issue-judgment
Oct 29, 2026
Merged

clubanderson merged 2 commits into
v5from
fix/decide-issue-judgment

Conversation

@clubanderson

Copy link
Copy Markdown
Member

Fixes #15413

Why

"Let hive decide" on issues parked at stage/045-needs-decision fell through to default-approve for almost everything, so a [selfreport] agent_login_required got "approved" (then looped: "Hive decided approved … but it hasn't taken effect") and speculative proposals got an implementer agent. The owner looked at five real parked issues and wants the hive to decide the way he would.

What

New named rules in pkg/delegatedecision, evaluated before default-approve (which stays as the last fallback):

rule when verdict
selfreport-operator-action hive:selfreport marker / [selfreport] title AND class has an operator remedy (agent_login_required, credentials/quota/network/config classes from pkg/fleetreport) operator-action — comment tells the reporting spoke's owner(s) exactly what to do, needs-owner, no approved-direction, stays at 045, never actionable for implementer lanes
hive-policy (kept) proposal about hive's own policy recommend-only, but now with a real recommendation sentence
proposal-approve-evidence hive-filed proposal citing an incident (incident #N, "broke … v5", regression) or recurrence ("three-of-a-class", "3rd instance", ≥2 prior #N) approve, rationale names the evidence
proposal-not-now hive-filed proposal with no such evidence (never for human authors, never for hive-policy items) not-now — comment "no incident or recurrence justifies the cost yet; re-propose with evidence", close as not planned

Loop fix: a decision that keeps the park (KeepsPark) no longer triggers the "re-parked after decision" override, and re-deciding an already-decided parked item is a no-op that surfaces "already recorded this decision at ; waiting on " instead of posting again.

Pure classifiers (ParseSelfReport, selfreportOpsClass, OperatorInstruction, IsProposal, ProposalEvidence, BotShapedLogin) in issue_judgment.go; ops classes pinned against pkg/fleetreport by test. Glossary entries (+ JS mirror, regenerated static/index.html), preview/plan and row-result wording in the new verb-first style, docs (dashboard-sections.md, labels-and-control-signals.md), changelog fragment.

What the new code produces for the 5 issues (from TestDecideIssueLikeTheOwner, real bodies as fixtures)

issue rule verdict comment text
hive#15021 [selfreport] agent_login_required selfreport-operator-action operator-action "operator action — @clubanderson: re-authenticate the agent provider (run the provider's login on the spoke so the agent CLI has a current session) on hosted-ibm-alchemy-logg-ptoo" · stage/045-needs-decision stays · "What happens next: Nothing by itself. Waiting on the spoke owner." No /hive decision line, no approved-direction.
hive#15329 RFC admission-side hold hive-policy recommend-only "hive recommends: approve 📝 RFC: admission-side #5117 — hold unacknowledged hive-filed proposals before any kick as proposed — proposals nobody has acknowledged should not be actionable; make it default-on for the lanes it names rather than opt-in; owner to confirm"
hivecommons.github.io#296 [quality] gate proposal: shell-checker mutation harness proposal-not-now not-now "not now: no incident or recurrence justifies the cost of #296 yet; re-propose with the incident or the repeated instances it would have prevented" · closed as not planned
hive#15335 [quality] Gate config: require_current_base — stale-green merge broke v5 proposal-approve-evidence approve "approve as proposed: it cites incident #15322, so the cost of the gate is already paid for"
rationguard#418 [scanner] Gate proposal: ECMA-48 conformance test (3rd recogniser gap) proposal-approve-evidence approve "approve as proposed: the same class was already fixed one at a time in #415, #417, so the cost of the gate is already paid for"

Verification

go build ./..., go vet, go test -race targeted, full go test -count=1 ./pkg/delegatedecision/... ./pkg/dashboard/..., check-api-reference-citations.sh, docs link check — all green after rebase onto #15409.

…oposals

Issues parked at stage/045-needs-decision are now judged the way the owner
would, with named rules evaluated before default-approve:

- selfreport-operator-action: a hive:selfreport whose class is an
  operator's to fix (agent_login_required, inference auth, disk, App
  setup, proxy, crux runtime, …) gets one direction comment to the
  reporting spoke's owner(s), needs-owner, no approved-direction, no
  implementer, the park kept. Re-deciding a kept-park decision no longer
  re-posts (the #15021 loop): the repark override is skipped when the
  decision never lifted the label, and the dedup answer reads
  "waiting on the spoke owner: @who …".
- proposal-approve-evidence: a hive-filed proposal citing an incident or
  a fixed-one-at-a-time recurrence is approved naming the evidence.
- proposal-not-now: a hive-filed proposal without evidence is declined
  for now — comment + close as not planned (new action close-not-now).
  Never for a person's proposal, never for hive-policy items.
- hive-policy recommendation on an issue is a real sentence.

Glossary, JS mirror, plan/preview wording, row result, docs and a
changelog fragment follow; the five real issues are table-test fixtures.

Fixes #15413

Signed-off-by: Andrew Anderson <andy@clubanderson.com>
@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Oct 29, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign nicholasjackson for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Oct 29, 2026
@github-actions

github-actions Bot commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

PR Title Relation Files
#15426 ✨ tracker: show who holds a claimed item on the chevron and hover same files src/docs/dashboard-sections.md
src/pkg/dashboard/static/index.html
#15424 🐛 tracker: name the clanker's owner on returned rows; flag superseded contributor PRs same files src/pkg/dashboard/static/index.html
#15418 🐛 Advisory issues: skip empty dedupe checklists, show as advisory in tracker same files src/docs/dashboard-sections.md
src/pkg/dashboard/api_repo_item_decision_test.go
src/pkg/dashboard/static-src/js/tracker-filter.js
src/pkg/dashboard/static/index.html
#15425 ✨ feature: show local claim holders in tracker same files src/pkg/dashboard/static/index.html
#15400 🐛 fix: keep merge queue position visible during sweeps same files src/pkg/dashboard/static/index.html
#15407 ✨ tracker: show where an adopted PR came from same files src/docs/dashboard-sections.md
src/pkg/dashboard/static/index.html
#15307 🐛 fix: refuse workflow-changing fork rebase follow-through same files src/pkg/dashboard/api_repo_item_decision_test.go
#15308 ✨ feature: enqueue eligible PRs into GitHub native merge queues same files src/docs/labels-and-control-signals.md

@hivecommons-hive

Copy link
Copy Markdown
Contributor

@clubanderson is auto-promoted for contributor-lane merging on this PR: the last 5 merged PRs by this author in this hive's repositories have no revert or sentinel-alert evidence. CI, reviewer verdict, diff fences, soak, holds and branch protection still apply.

@hivecommons-hive

Copy link
Copy Markdown
Contributor

@clubanderson this PR is held at stage/071-needs-author and the hive will not merge it yet.

Failing checks:

  • test (rest 1/4)

Next: the hive does not push to your branch. Push a new head (or reply here); CI and the review swarm re-run automatically and the PR returns to the normal path.

@hivecommons-hive

Copy link
Copy Markdown
Contributor

stage 080-awaiting-merge-admission → 071-needs-author: optional-check-failing:test (rest 1/4)

…h (writeback ratchet)

Signed-off-by: Andrew Anderson <andy@clubanderson.com>
@clubanderson
clubanderson merged commit 07cf83f into v5 Oct 29, 2026
75 of 76 checks passed
@kubestellar-prow
kubestellar-prow Bot deleted the fix/decide-issue-judgment branch October 29, 2026 16:11
@github-actions

Copy link
Copy Markdown
Contributor

Thank you for your contribution! Your PR has been merged.

We'd love to hear how your experience was: share feedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco-signoff: yes Indicates the PR's author has signed the DCO. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Let hive decide: judge issues like the owner would (selfreport → operator action, proposals need evidence)

1 participant