Repository navigation
π tracker: name the clanker's owner on returned rows; flag superseded contributor PRs - #15424
Conversation
β¦rseded contributor PRs An issue row drawn through its one covering PR kept the issue's author for the stage chevron, so hive-filed issues read "Returned to @hivecommons-hive[bot]'s hive" while the waiting-on chip named the clanker's owner. The returned word now takes the author from the PR drawn on the row and says "'s clanker" for clanker authors. A contributor PR the supersession sweep found superseded but could not close (hold label) was drawn as "Returned to β¦" with the finding only in the caption. It now reads "Superseded by #N Β· decide" and the Close as superseded prompt is prefilled with the sweep's closer PR. Signed-off-by: Andrew Anderson <andy@clubanderson.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of
|
|
@clubanderson this PR is held at Failing checks:
Next: the hive does not push to your branch. Push a new head (or reply here); CI and the review swarm re-run automatically and the PR returns to the normal path. |
|
stage 080-awaiting-merge-admission β 071-needs-author: required-check-failing:build-and-test |
There was a problem hiding this comment.
The red test (dashboard β¦) shards are this PR's own test edit, and the fix is one word.
src/pkg/dashboard/stage_tracker_rework_test.go:227 β the regex was updated to expect title="Waiting on @Danathar's clanker (online, β¦" but still expects aria-label="Waiting on @Danathar's hive[^"]*acknowledged. stageTrackerPresenceChipHtml renders both attributes from the same string (tracker-words.js:1004: title="${esc(tip)}" aria-label="${esc(tip)}"), and this PR changes that tip to 's clanker ( (tracker-words.js:942), so the aria-label half can no longer match. CI confirms it: TestStageTrackerReworkJS fails with the chip showing title="Waiting on @Danathar's clanker (online, last seen 2 min ago) β¦" (job 123567530132). Changing s hive[^"]*acknowledged β s clanker[^"]*acknowledged in the aria-label part should turn the shard green; coverage / test are downstream of the same failure.
Correctness read of the source change, against the v5 tree at eb61710:
stageTrackerReturnedAuthorreadslinked_prs[].author/author_kind/drawn_under, which exist onStageTrackerLinkedPR(stage_tracker.go:569-641), anditem.superseded.closer_pr/closer_repomatchgithub.ReviewQueueSuperseded(review_queue.go:275-276). Thedrawn_underfilter keeps a PR drawn under a different issue from naming itself on this row.stageTrackerSupersederDefaultonly prefills; it still goes throughstageTrackerSupersederValidand the existingdecide:close-supersededpath β no new writer, as the body says.- Go caption
stageTrackerReturnedToHiveCaption(stage_tracker.go:1621) and the JSstageTrackerDirectionCarrier/ presence tip now agree on's clanker; the remaining's hivecases areauthor_kind === 'hive'only, which is the intended split.
Otherwise matches #15423's ask. No other findings.
β hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88
β¦nce tests Signed-off-by: Andrew Anderson <andy@clubanderson.com>
There was a problem hiding this comment.
Read against the v5 tree; looks correct to me.
- Every field the new JS reads exists on the wire:
superseded.closer_pr/closer_repo(pkg/github/review_queue.go:275-276, carried byStageTrackerItem.Supersededatstage_tracker.go:249), andlinked_prs[].author/author_kind/drawn_under(stage_tracker.go:574-575, 641). stageTrackerReturnedAuthordepends on thevia_prshown item still carryinglinked_prs; it does βtracker-row.js:1090buildsshownwithObject.assign({}, item, {...}), so the array survives. When thedrawn_underfilter does not isolate exactly one PR it falls back to the issue author, i.e. today's behaviour.stageTrackerSupersederDefaultonly replaces the prompt default;stageTrackerSupersederValidstill gates the value, so a mis-speltcloser_repocannot slip through unvalidated.
One behaviour shift beyond the body's wording, in case it matters: the old Returned to @author branch appended 's hive for every non-human kind; stageTrackerToolingSuffix now appends only for clanker/hive, so a foreign-bot author (author_kind other than those) reads Returned to @bot with no suffix. Looks like an improvement, just noting it is a change.
β hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88
|
stage 080-awaiting-merge-admission β 060-reviewed: required-check-pending:build-and-test |
|
@clubanderson is auto-promoted for contributor-lane merging on this PR: the last 5 merged PRs by this author in this hive's repositories have no revert or sentinel-alert evidence. CI, reviewer verdict, diff fences, soak, holds and branch protection still apply. |
|
@clubanderson this PR is held at Failing checks:
Next: the hive does not push to your branch. Push a new head (or reply here); CI and the review swarm re-run automatically and the PR returns to the normal path. |
Signed-off-by: Andrew Anderson <andy@clubanderson.com>
|
stage 080-awaiting-merge-admission β 050-review-pending: required-check-pending:Sign-off survives the squash |
There was a problem hiding this comment.
Docs currency (delta re-review at 567d3a0) β the delta is test-only (expectations updated to the @login's clanker (β¦) tooltip that tracker-words.js:942 already emitted at 8e41f79); clean. One operator-facing doc still carries the wording this PR retires:
src/docs/dashboard-sections.md:942β caption exampleReturned to @thatguywob's hive β @clubanderson requested changes; the Go caption now emits's clanker(src/pkg/dashboard/stage_tracker.go:1622).src/docs/dashboard-sections.md:944β chevron exampleReturned to @thatguywob's hive;stageTrackerToolingSuffixnow returns's clankerfor clanker authors (static-src/js/tracker-words.js:1164), and #15423 asks for exactly that wording. The same doc's own rule at line 1335 ("Their clanker, not their hive") is now contradicted two sections earlier.
Suggested edit (both lines): replace @thatguywob's hive with @thatguywob's clanker. Non-blocking; the previous head was approved on this perspective and the delta does not change it.
Prior finding [intent-alignment] tracker-words.js:1163 (non-clanker/non-hive kinds get no suffix): unchanged by the delta β still present as previously noted, still advisory.
β hive: agent=ci-maintainer backend=copilot model=claude-fable-5.1 copilot=1.0.88
|
Thank you for your contribution! Your PR has been merged. We'd love to hear how your experience was: share feedback |
Fixes #15423
An issue row drawn through its one covering PR kept the issue's author for the stage chevron, so hive-filed issues read "Returned to @hivecommons-hive[bot]'s hive" while the waiting-on chip named the clanker's owner.
stageTrackerReturnedWordnow takes the author from the PR drawn on the row (stageTrackerReturnedAuthor) and says "'s clanker" for clanker authors (JS + Go caption, direction carrier, presence tip).A contributor PR the supersession sweep found superseded but could not close (hold label) was drawn as "Returned to β¦" with the finding only in the caption. It now reads "Superseded by #N Β· decide", and the existing "Close as superseded byβ¦" prompt is prefilled with the sweep's closer PR (
stageTrackerSupersederDefault). No new writer; the existing audited action path is reused.Tests:
stage_tracker_sentinel_lane_test.go(via_pr bot-author case, superseded word, drawn-under exclusion),stage_tracker_row_actions_test.go(stageTrackerSupersederDefault), wording updates in presence/rework/ui/adoption tests. SPA regenerated.