Skip to content

πŸ› tracker: name the clanker's owner on returned rows; flag superseded contributor PRs - #15424

Merged
clubanderson merged 3 commits into
v5from
fix/returned-to-clanker-offline
Oct 29, 2026
Merged

clubanderson merged 3 commits into
v5from
fix/returned-to-clanker-offline

Conversation

@clubanderson

Copy link
Copy Markdown
Member

Fixes #15423

An issue row drawn through its one covering PR kept the issue's author for the stage chevron, so hive-filed issues read "Returned to @hivecommons-hive[bot]'s hive" while the waiting-on chip named the clanker's owner. stageTrackerReturnedWord now takes the author from the PR drawn on the row (stageTrackerReturnedAuthor) and says "'s clanker" for clanker authors (JS + Go caption, direction carrier, presence tip).

A contributor PR the supersession sweep found superseded but could not close (hold label) was drawn as "Returned to …" with the finding only in the caption. It now reads "Superseded by #N Β· decide", and the existing "Close as superseded by…" prompt is prefilled with the sweep's closer PR (stageTrackerSupersederDefault). No new writer; the existing audited action path is reused.

Tests: stage_tracker_sentinel_lane_test.go (via_pr bot-author case, superseded word, drawn-under exclusion), stage_tracker_row_actions_test.go (stageTrackerSupersederDefault), wording updates in presence/rework/ui/adoption tests. SPA regenerated.

…rseded contributor PRs

An issue row drawn through its one covering PR kept the issue's author for
the stage chevron, so hive-filed issues read "Returned to
@hivecommons-hive[bot]'s hive" while the waiting-on chip named the clanker's
owner. The returned word now takes the author from the PR drawn on the row
and says "'s clanker" for clanker authors.

A contributor PR the supersession sweep found superseded but could not close
(hold label) was drawn as "Returned to …" with the finding only in the
caption. It now reads "Superseded by #N Β· decide" and the Close as superseded
prompt is prefilled with the sweep's closer PR.

Signed-off-by: Andrew Anderson <andy@clubanderson.com>
@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Oct 29, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign nicholasjackson for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 29, 2026
@github-actions

github-actions Bot commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

PR Title Relation Files
#15429 ✨ governor: merge-hotspot advisor files modularize issues for the ci-maintainer same files src/pkg/dashboard/static/index.html
#15427 ✨ tracker: merge queue position on the chevron, stable wording, stall warning same files src/pkg/dashboard/stage_tracker.go
src/pkg/dashboard/static-src/js/tracker-words.js
src/pkg/dashboard/static/index.html
#15400 πŸ› fix: keep merge queue position visible during sweeps same files src/pkg/dashboard/static-src/js/tracker-words.js
src/pkg/dashboard/static/index.html
#15425 ✨ feature: show local claim holders in tracker same files src/pkg/dashboard/stage_tracker.go
src/pkg/dashboard/static/index.html

@hivecommons-hive

Copy link
Copy Markdown
Contributor

@clubanderson this PR is held at stage/071-needs-author and the hive will not merge it yet.

Failing checks:

  • build-and-test

Next: the hive does not push to your branch. Push a new head (or reply here); CI and the review swarm re-run automatically and the PR returns to the normal path.

@hivecommons-hive

Copy link
Copy Markdown
Contributor

stage 080-awaiting-merge-admission β†’ 071-needs-author: required-check-failing:build-and-test

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The red test (dashboard …) shards are this PR's own test edit, and the fix is one word.

src/pkg/dashboard/stage_tracker_rework_test.go:227 β€” the regex was updated to expect title="Waiting on @Danathar&#39;s clanker (online, …" but still expects aria-label="Waiting on @Danathar&#39;s hive[^"]*acknowledged. stageTrackerPresenceChipHtml renders both attributes from the same string (tracker-words.js:1004: title="${esc(tip)}" aria-label="${esc(tip)}"), and this PR changes that tip to 's clanker ( (tracker-words.js:942), so the aria-label half can no longer match. CI confirms it: TestStageTrackerReworkJS fails with the chip showing title="Waiting on @Danathar&#39;s clanker (online, last seen 2 min ago) …" (job 123567530132). Changing s hive[^"]*acknowledged β†’ s clanker[^"]*acknowledged in the aria-label part should turn the shard green; coverage / test are downstream of the same failure.

Correctness read of the source change, against the v5 tree at eb61710:

  • stageTrackerReturnedAuthor reads linked_prs[].author / author_kind / drawn_under, which exist on StageTrackerLinkedPR (stage_tracker.go:569-641), and item.superseded.closer_pr / closer_repo match github.ReviewQueueSuperseded (review_queue.go:275-276). The drawn_under filter keeps a PR drawn under a different issue from naming itself on this row.
  • stageTrackerSupersederDefault only prefills; it still goes through stageTrackerSupersederValid and the existing decide:close-superseded path β€” no new writer, as the body says.
  • Go caption stageTrackerReturnedToHiveCaption (stage_tracker.go:1621) and the JS stageTrackerDirectionCarrier / presence tip now agree on 's clanker; the remaining 's hive cases are author_kind === 'hive' only, which is the intended split.

Otherwise matches #15423's ask. No other findings.

β€” hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88

…nce tests

Signed-off-by: Andrew Anderson <andy@clubanderson.com>

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read against the v5 tree; looks correct to me.

  • Every field the new JS reads exists on the wire: superseded.closer_pr / closer_repo (pkg/github/review_queue.go:275-276, carried by StageTrackerItem.Superseded at stage_tracker.go:249), and linked_prs[].author / author_kind / drawn_under (stage_tracker.go:574-575, 641).
  • stageTrackerReturnedAuthor depends on the via_pr shown item still carrying linked_prs; it does β€” tracker-row.js:1090 builds shown with Object.assign({}, item, {...}), so the array survives. When the drawn_under filter does not isolate exactly one PR it falls back to the issue author, i.e. today's behaviour.
  • stageTrackerSupersederDefault only replaces the prompt default; stageTrackerSupersederValid still gates the value, so a mis-spelt closer_repo cannot slip through unvalidated.

One behaviour shift beyond the body's wording, in case it matters: the old Returned to @author branch appended 's hive for every non-human kind; stageTrackerToolingSuffix now appends only for clanker/hive, so a foreign-bot author (author_kind other than those) reads Returned to @bot with no suffix. Looks like an improvement, just noting it is a change.

β€” hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive

Copy link
Copy Markdown
Contributor

stage 080-awaiting-merge-admission β†’ 060-reviewed: required-check-pending:build-and-test

@hivecommons-hive

Copy link
Copy Markdown
Contributor

@clubanderson is auto-promoted for contributor-lane merging on this PR: the last 5 merged PRs by this author in this hive's repositories have no revert or sentinel-alert evidence. CI, reviewer verdict, diff fences, soak, holds and branch protection still apply.

@hivecommons-hive

Copy link
Copy Markdown
Contributor

@clubanderson this PR is held at stage/071-needs-author and the hive will not merge it yet.

Failing checks:

  • build-and-test

Next: the hive does not push to your branch. Push a new head (or reply here); CI and the review swarm re-run automatically and the PR returns to the normal path.

Signed-off-by: Andrew Anderson <andy@clubanderson.com>
@hivecommons-hive

Copy link
Copy Markdown
Contributor

stage 080-awaiting-merge-admission β†’ 050-review-pending: required-check-pending:Sign-off survives the squash

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed β€” no findings from this perspective.

β€” hive: agent=adjudicator-4 backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed β€” no findings from this perspective.

β€” hive: agent=adjudicator-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed β€” no findings from this perspective.

β€” hive: agent=adjudicator-3 backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed β€” no findings from this perspective.

β€” hive: agent=adjudicator backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs currency (delta re-review at 567d3a0) β€” the delta is test-only (expectations updated to the @login's clanker (…) tooltip that tracker-words.js:942 already emitted at 8e41f79); clean. One operator-facing doc still carries the wording this PR retires:

  • src/docs/dashboard-sections.md:942 β€” caption example Returned to @thatguywob's hive β€” @clubanderson requested changes; the Go caption now emits 's clanker (src/pkg/dashboard/stage_tracker.go:1622).
  • src/docs/dashboard-sections.md:944 β€” chevron example Returned to @thatguywob's hive; stageTrackerToolingSuffix now returns 's clanker for clanker authors (static-src/js/tracker-words.js:1164), and #15423 asks for exactly that wording. The same doc's own rule at line 1335 ("Their clanker, not their hive") is now contradicted two sections earlier.

Suggested edit (both lines): replace @thatguywob's hive with @thatguywob's clanker. Non-blocking; the previous head was approved on this perspective and the delta does not change it.

Prior finding [intent-alignment] tracker-words.js:1163 (non-clanker/non-hive kinds get no suffix): unchanged by the delta β€” still present as previously noted, still advisory.

β€” hive: agent=ci-maintainer backend=copilot model=claude-fable-5.1 copilot=1.0.88

@clubanderson
clubanderson merged commit 2a8b326 into v5 Oct 29, 2026
75 of 76 checks passed
@kubestellar-prow
kubestellar-prow Bot deleted the fix/returned-to-clanker-offline branch October 29, 2026 16:42
@github-actions

Copy link
Copy Markdown
Contributor

Thank you for your contribution! Your PR has been merged.

We'd love to hear how your experience was: share feedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco-signoff: yes Indicates the PR's author has signed the DCO. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Activity Monitor: returned-to rows name the hive bot instead of the clanker's owner; superseded contributor PRs hide the sweep's finding

1 participant