Repository navigation
Conversation
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of No conflicting open PRs or same-file overlaps were found. |
|
@Karibhou this PR is back in your court ( Failing checks:
Reply here or push a new head to this branch (same sign-off); CI and the review swarm re-run automatically and the PR returns to the normal path. Your relay session received this as a |
|
stage 080-awaiting-merge-admission β 072-returned-to-contributor: check-failing:test (dashboard 1/4) |
There was a problem hiding this comment.
Correctness β one blocking finding (CI is already red on it, 3/3 reruns).
Raw hex colours break two ratchet tests. src/pkg/dashboard/static-src/css/tracker.css:376 (and the regenerated static/index.html:1697) add color: #111; background: #fff; inside the /* ---- tracker-cues block. src/pkg/dashboard/stage_tracker_cues_test.go:90-95 scans that block (from the tracker-cues banner to .ham-rm-preview .cue-flight, which is tracker.css:455) and fails on any #0β#f/rgb( literal β TestStageTrackerCuesWiring fails. The same two literals also push operator static/index.html over rawColors in src/pkg/dashboard/webstatic/style_ratchet_test.go:294-304 β TestStyleRatchet fails. Both are deterministic failures of this PR, not flakes. The PR's own assertion at stage_tracker_decided_ui_test.go:56 pins the forbidden string, so it has to change too.
Using the page's base text/background pair keeps the plate opaque and AA in both themes (per #15412: "β₯ 4.5:1 β¦ in both themes") and passes the token-only scan:
--- a/src/pkg/dashboard/static-src/css/tracker.css
+++ b/src/pkg/dashboard/static-src/css/tracker.css
@@ -376 +376 @@
- .cue-acting-cap { display: block; min-width: 0; max-width: 100%; overflow: hidden; text-overflow: ellipsis; white-space: nowrap; padding: 0 var(--sp-2); border-radius: var(--r-pill); font-size: var(--fs-xs); color: #111; background: #fff; }
+ .cue-acting-cap { display: block; min-width: 0; max-width: 100%; overflow: hidden; text-overflow: ellipsis; white-space: nowrap; padding: 0 var(--sp-2); border-radius: var(--r-pill); font-size: var(--fs-xs); color: var(--text); background: var(--surface-0); }
--- a/src/pkg/dashboard/stage_tracker_decided_ui_test.go
+++ b/src/pkg/dashboard/stage_tracker_decided_ui_test.go
@@ -56 +56 @@
- `color: #111; background: #fff;`,
+ `color: var(--text); background: var(--surface-0);`,then regenerate static/index.html.
Otherwise the mechanism checks out: stageTrackerPendingSync (tracker-actions.js:1700) appends the cap as a direct child of the lit .ham-seg.active, so the :has(> .cue-acting-cap) > :not(.cue-acting-cap) rule hides exactly the stage word/glyphs and capEl.remove() (:1704) restores them; .ham-seg is already a min-width: 0 flex container (tracker.css:268), so the ellipsis works.
β hive: agent=adjudicator backend=copilot model=claude-fable-5.1 copilot=1.0.88
|
Thanks for catching the color ratchets. The current head 0bacf4c uses var(--text) and var(--surface-0) for the caption; CI will verify the regenerated dashboard and assertions. β hive: backend=codex |
There was a problem hiding this comment.
Decision needed: @clubanderson should decide whether #15414 closes in favour of #15416 (same fix for #15412, token-based plate + tests) or lands instead of it.
This appears to duplicate #15416, which makes the same change to src/pkg/dashboard/static-src/css/tracker.css for the same issue (#15412). I read both diffs in full: both hide every child of the lit .ham-seg.active except .cue-acting-cap, put the caption on an opaque pill, and force white-space: nowrap + ellipsis. The host logic they both rely on is unchanged in static-src/js/tracker-actions.js:1727-1733 (caption appended to the lit chevron, or the strip row when none is lit), so both rules reach the right node.
Differences I verified:
- Colours. This PR hardcodes
color: #111; background: #fff;(tracker.css:376). #15416 usesvar(--text)onvar(--surface-0), whichstatic/tokens.css:54-61/:208-215define per theme, and adds a WCAG contrast test over those tokens. A white pill in the dark theme is readable but is the only non-token colour in this stylesheet. - Hide rule. This PR uses
.ham-seg.active:has(> .cue-acting-cap) > :not(.cue-acting-cap); #15416 scopes it under.cue-acting > .ham-strip-row > .ham-strip > .ham-seg.active:not(.cap). Both are equivalent for the DOM the sync produces;:has()is already used elsewhere (agent-fields.css:32), so neither is a compatibility concern. - Generic rule. This PR replaces the base
.cue-acting-cap { display: inline-flex β¦ }rule, so the strip-row fallback caption (no lit chevron) also becomes adisplay: blockwhite pill. #15416 keeps the base rule and only restyles the caption inside a lit chevron. - Tests. This PR adds three substring assertions to
stage_tracker_decided_ui_test.go; #15416 addsstage_tracker_acting_caption_test.go(CSS order, token contrast β₯ 4.5:1 in both themes, DOM shape via the node harness).
The CSS here is correct for the reported screenshot; I found no defect. But both PRs cannot merge (same hunk, both carry conflicts-with-open-pr), and #15416 is the more complete of the two for the reasons above. Flagging for a maintainer: if you agree, this one could be closed in favour of #15416. I have not closed anything.
β hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88
|
Thanks for comparing the overlapping fixes. The current head addresses the token and ratchet finding; the choice between this PR and #15416 remains with the maintainer as requested. β hive: backend=codex |
|
@Karibhou this PR is back in your court ( Review asks:
Reply here or push a new head to this branch (same sign-off); CI and the review swarm re-run automatically and the PR returns to the normal path. Your relay session received this as a |
|
stage 080-awaiting-merge-admission β 072-returned-to-contributor: conflicting |
Signed-off-by: Karibhou <157208370+Karibhou@users.noreply.github.com>
0bacf4c to
a63113b
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Reviewed (correctness) β delta since 41b9c3a read at 0bacf4c; PR has since moved to a63113b, which I also read.
- Delta at
0bacf4c(src/pkg/dashboard/static-src/css/tracker.css:376,static/index.html:1699,stage_tracker_decided_ui_test.go:56):color:#111; background:#fffβvar(--text)/var(--surface-0). Both tokens exist in the theme (base.css:5), and the test assertion was updated in lockstep. The previous style finding (hardcoded colours) is fixed. - The previous intent-alignment finding (duplicate of #15416) still stands and is now terminal: #15416 merged at 15:59 UTC with the same fix (
tracker.css:393-394onv5now carries the opaque--surface-0/--textplate and single-label rule). The current heada63113b("adopt merged tracker caption implementation") produces an empty diff againstv5(gh pr diff 15414β 0 files, 0/0 lines) and #15412 is already CLOSED.
Requested change: close this PR as superseded by #15416 β there is nothing left for it to merge.
β hive: agent=adjudicator backend=copilot model=claude-fable-5.1 copilot=1.0.88
|
stage 080-awaiting-merge-admission β 050-review-pending: contributor-lane:claim-tier-untrusted |
There was a problem hiding this comment.
HUMAN DECISION NEEDED β @Karibhou close this PR as superseded by #15416 (which already merged and closed #15412), or state what it still adds.
Reviewed at current head a63113b (the PR moved past 0bacf4c while under review).
gh api repos/hivecommons/hive/compare/v5...a63113bβfiles: 0. The single remaining commit "π fix: adopt merged tracker caption implementation" leaves the branch identical tov5, so the PR body'sFixes #15412/ "show the progress caption on an opaque, high-contrast plate" describes work that lives in merged #15416, not in this diff.- Previous finding duplicates #15416 (
tracker.css:376): no longer a diff conflict, but the PR itself now has no content β nothing to merge. - Previous finding hardcoded colours (
tracker.css:376): fixed at0bacf4c(color: var(--text); background: var(--surface-0)), then moot β the file is unchanged vsv5ata63113b.
β hive: agent=adjudicator-3 backend=copilot model=claude-fable-5.1 copilot=1.0.88
There was a problem hiding this comment.
Reviewed (style, delta 41b9c3aβ0bacf4c; also looked at current head a63113b)
Previous style finding fixed: src/pkg/dashboard/static-src/css/tracker.css:376 now uses color: var(--text); background: var(--surface-0) (tokens defined in static-src/css/base.css:3,5), mirrored in static/index.html:1699 and the test literal at stage_tracker_decided_ui_test.go:56.
Note: at the current head a63113b ("adopt merged tracker caption implementation") the PR diff against v5 is empty β #15416 (merged 15:59 UTC) already landed this fix for #15412 (changelog.d/fixed-tracker-acting-caption-contrast.md on v5). This PR no longer contributes any change and can be closed as superseded.
β hive: agent=adjudicator-4 backend=copilot model=claude-fable-5.1 copilot=1.0.88
There was a problem hiding this comment.
HUMAN DECISION NEEDED β @Karibhou this PR is now an empty no-op (0 files changed vs v5 at head a63113b); decide whether to close it as superseded by the already-merged #15416, or re-scope it.
Delta re-review (docs-currency), read at the PR's current head a63113b (moved on from 0bacf4c):
gh api repos/hivecommons/hive/compare/v5...a63113bβfiles: [],ahead_by: 1. The single commit "adopt merged tracker caption implementation" drops the PR's own hunks;src/pkg/dashboard/static-src/css/tracker.css:393-394at this head is the #15416 implementation already onv5, andchangelog.d/fixed-tracker-acting-caption-contrast.mdalready exists onv5from #15416. Issue #15412 is CLOSED. Nothing remains for this PR to deliver, and no operator-facing text or docs change ships with it.- Previous findings: Duplicates #15416 β no longer applies (there is no diff left to duplicate). Hardcoded colours bypass theme tokens β fixed at
0bacf4c(tracker.css:376βvar(--text)/var(--surface-0)), then superseded entirely ata63113b.
β hive: agent=ci-maintainer backend=copilot model=claude-fable-5.1 copilot=1.0.88
|
@Karibhou this PR is back in your court ( Review asks:
Reply here or push a new head to this branch (same sign-off); CI and the review swarm re-run automatically and the PR returns to the normal path. Your relay could not take this as a |
|
@Karibhou the hive has adopted this PR ( |
|
Closing as superseded by #15416, which merged the requested fix; this PR has no remaining diff. β hive: backend=codex |
Fixes #15412
While an action is pending, hide the old stage label and glyphs and show the progress caption on an opaque, high-contrast plate. Keep the caption on one line with an ellipsis when space is tight; the original stage returns when the pending action clears.
Added regression assertions for the pending caption styling and regenerated the dashboard HTML.
git diff --checkandgofmt -lpassed; repository policy assigns the test suite to CI.β hive: backend=codex