Repository navigation
π tracker: readable progress label when a chevron action is running - #15416
Conversation
While an operator action is in flight the lit chevron hid nothing: the in-flight caption sat in muted grey on top of the amber stripes (unreadable) beside the still-shown stage word, which wrapped to four lines. The caption now replaces the word and its glyphs for the duration and sits on an opaque plate (page surface under page text: 18.5:1 dark, 16.7:1 light), one line with an ellipsis. Applies to every chevron that can be busy. Fixes #15412 Signed-off-by: Andrew Anderson <andy@clubanderson.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of
|
|
Thank you for your contribution! Your PR has been merged. We'd love to hear how your experience was: share feedback |
There was a problem hiding this comment.
Decision needed: @clubanderson should decide whether #15416 or #15414 lands for #15412 β both make the same tracker.css change and conflict on the same hunk.
This overlaps #15414 (same issue #15412, same fix, same hunk). Both diffs read in full.
Same semantic change in src/pkg/dashboard/static-src/css/tracker.css (hunk at line ~373 in both): while a caption occupies the lit chevron, hide the chevron's other children; put .cue-acting-cap on an opaque var(--surface-0) / var(--text) pill; white-space: nowrap + text-overflow: ellipsis. Both regenerate static/index.html. They cannot both merge β the hunks collide.
Where they genuinely differ (verified against tracker-actions.js on v5):
- Hide selector. This PR:
.cue-acting > .ham-strip-row > .ham-strip > .ham-seg.active:not(.cap) > :not(.cue-acting-cap). #15414:.ham-seg.active:has(> .cue-acting-cap) > :not(.cue-acting-cap). The DOM path here is right βstageTrackerPendingSynclooks up:scope > .ham-strip-rowon the row (tracker-actions.js:1723) and hosts the caption in:scope > .ham-strip > .ham-seg.active:not(.cap)(:1727). - Fallback host (low, open question). At
tracker-actions.js:1727a row with no lit chevron hosts the caption on the strip row itself. This PR's plate rule is scoped.ham-seg.active > .cue-acting-cap, so in that fallback the caption keeps the oldcolor: var(--muted)styling on the amber row. #15414 restyles.cue-acting-capunscoped and covers that case. Whether the cap-only strip can actually be.cue-actingin practice I did not verify β flagging, not asserting. - Tests. This PR adds a dedicated test file (CSS ordering, computed WCAG contrast from
tokens.css, node harness on the real row HTML); #15414 extendsstage_tracker_decided_ui_test.go.
Not recommending which to close β that is the owner's call, and #15414's head has moved since its last hive verdict. I have not closed anything.
β hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88
Fixes #15412
Problem (owner screenshot, dark theme)
After Approve & merge, the merge-gate chevron went into action mode (
.cue-acting, amber stripes) and:var(--muted)straight on the stripes β ~1.9:1, unreadable;Fix (CSS only,
static-src/css/tracker.css+ regeneratedstatic/index.html).cue-acting, every child of the lit chevron except the caption is hidden: one label. Works for every chevron that can be busy (merge gate, decision, hold, re-run) sincestageTrackerPendingSyncalready hosts the caption in whichever chevron is lit.--surface-0under--text, above the stripes and the pulse overlay. Contrast computed fromtokens.css: 18.5:1 dark, 16.7:1 light (AA needs 4.5:1).white-space: nowrap+ ellipsis: one line, never wrapping.Before / after (Playwright, chromium, real
index.htmlCSS, 1400 px)Tests
stage_tracker_acting_caption_test.go:TestStageTrackerActingCaptionCSSβ the hide and plate rules are in the page, ordered after the rules they override.TestStageTrackerActingCaptionContrastβ WCAG contrast of--texton--surface-0fromtokens.cssfor both theme blocks β₯ 4.5:1.TestStageTrackerActingCaptionNodeβ realstageTrackerRowHtmloutput nests every lit chevron atrow > .ham-strip-row > .ham-strip > .ham-seg.active(so the rule reaches it) with the word as a direct child;stageTrackerPendingSyncon a chevron carrying word + glyphs yields exactly onerole=statuscaption (spinner + text), no second label, idempotent on re-sync, and restores the word when the action lands.