Skip to content

πŸ› tracker: readable progress label when a chevron action is running - #15416

Merged
clubanderson merged 1 commit into
v5from
fix/chevron-action-contrast
Oct 29, 2026
Merged

clubanderson merged 1 commit into
v5from
fix/chevron-action-contrast

Conversation

@clubanderson

Copy link
Copy Markdown
Member

Fixes #15412

Problem (owner screenshot, dark theme)

After Approve & merge, the merge-gate chevron went into action mode (.cue-acting, amber stripes) and:

  • the progress caption "Queuing for merge…" was drawn in var(--muted) straight on the stripes β€” ~1.9:1, unreadable;
  • the stage word "Ready for human merge Β· untrusted author", the gate glyph and the person icon stayed beside it β€” two labels at once, the old one wrapped to four lines.

Fix (CSS only, static-src/css/tracker.css + regenerated static/index.html)

  • While the row is .cue-acting, every child of the lit chevron except the caption is hidden: one label. Works for every chevron that can be busy (merge gate, decision, hold, re-run) since stageTrackerPendingSync already hosts the caption in whichever chevron is lit.
  • The caption sits on an opaque plate: --surface-0 under --text, above the stripes and the pulse overlay. Contrast computed from tokens.css: 18.5:1 dark, 16.7:1 light (AA needs 4.5:1).
  • white-space: nowrap + ellipsis: one line, never wrapping.

Before / after (Playwright, chromium, real index.html CSS, 1400 px)

dark light
before before-dark before-light
after after-dark after-light

Tests

stage_tracker_acting_caption_test.go:

  • TestStageTrackerActingCaptionCSS β€” the hide and plate rules are in the page, ordered after the rules they override.
  • TestStageTrackerActingCaptionContrast β€” WCAG contrast of --text on --surface-0 from tokens.css for both theme blocks β‰₯ 4.5:1.
  • TestStageTrackerActingCaptionNode β€” real stageTrackerRowHtml output nests every lit chevron at row > .ham-strip-row > .ham-strip > .ham-seg.active (so the rule reaches it) with the word as a direct child; stageTrackerPendingSync on a chevron carrying word + glyphs yields exactly one role=status caption (spinner + text), no second label, idempotent on re-sync, and restores the word when the action lands.

While an operator action is in flight the lit chevron hid nothing: the
in-flight caption sat in muted grey on top of the amber stripes (unreadable)
beside the still-shown stage word, which wrapped to four lines. The caption
now replaces the word and its glyphs for the duration and sits on an opaque
plate (page surface under page text: 18.5:1 dark, 16.7:1 light), one line
with an ellipsis. Applies to every chevron that can be busy.

Fixes #15412

Signed-off-by: Andrew Anderson <andy@clubanderson.com>
@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Oct 29, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign kellyaa for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 29, 2026
@github-actions

github-actions Bot commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

PR Title Relation Files
#15418 πŸ› Advisory issues: skip empty dedupe checklists, show as advisory in tracker same files src/pkg/dashboard/static-src/css/tracker.css
src/pkg/dashboard/static/index.html
#15414 πŸ› fix: make tracker action captions readable CONFLICT src/pkg/dashboard/static-src/css/tracker.css
src/pkg/dashboard/static/index.html
#15420 ✨ Let hive decide: operator-action for selfreports, evidence-gated proposals same files src/pkg/dashboard/static/index.html
#15400 πŸ› fix: keep merge queue position visible during sweeps same files src/pkg/dashboard/static/index.html
#15407 ✨ tracker: show where an adopted PR came from same files src/pkg/dashboard/static-src/css/tracker.css
src/pkg/dashboard/static/index.html

@github-actions

Copy link
Copy Markdown
Contributor

Thank you for your contribution! Your PR has been merged.

We'd love to hear how your experience was: share feedback

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Decision needed: @clubanderson should decide whether #15416 or #15414 lands for #15412 β€” both make the same tracker.css change and conflict on the same hunk.

This overlaps #15414 (same issue #15412, same fix, same hunk). Both diffs read in full.

Same semantic change in src/pkg/dashboard/static-src/css/tracker.css (hunk at line ~373 in both): while a caption occupies the lit chevron, hide the chevron's other children; put .cue-acting-cap on an opaque var(--surface-0) / var(--text) pill; white-space: nowrap + text-overflow: ellipsis. Both regenerate static/index.html. They cannot both merge β€” the hunks collide.

Where they genuinely differ (verified against tracker-actions.js on v5):

  • Hide selector. This PR: .cue-acting > .ham-strip-row > .ham-strip > .ham-seg.active:not(.cap) > :not(.cue-acting-cap). #15414: .ham-seg.active:has(> .cue-acting-cap) > :not(.cue-acting-cap). The DOM path here is right β€” stageTrackerPendingSync looks up :scope > .ham-strip-row on the row (tracker-actions.js:1723) and hosts the caption in :scope > .ham-strip > .ham-seg.active:not(.cap) (:1727).
  • Fallback host (low, open question). At tracker-actions.js:1727 a row with no lit chevron hosts the caption on the strip row itself. This PR's plate rule is scoped .ham-seg.active > .cue-acting-cap, so in that fallback the caption keeps the old color: var(--muted) styling on the amber row. #15414 restyles .cue-acting-cap unscoped and covers that case. Whether the cap-only strip can actually be .cue-acting in practice I did not verify β€” flagging, not asserting.
  • Tests. This PR adds a dedicated test file (CSS ordering, computed WCAG contrast from tokens.css, node harness on the real row HTML); #15414 extends stage_tracker_decided_ui_test.go.

Not recommending which to close β€” that is the owner's call, and #15414's head has moved since its last hive verdict. I have not closed anything.

β€” hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

conflicts-with-open-pr Open PR has a merge conflict with another open PR dco-signoff: yes Indicates the PR's author has signed the DCO. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tracker chevron in action mode: progress text unreadable on stripes, old label still shown

1 participant