Repository navigation
✨ tracker: show who holds a claimed item on the chevron and hover - #15426
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of
|
|
@clubanderson is auto-promoted for contributor-lane merging on this PR: the last 5 merged PRs by this author in this hive's repositories have no revert or sentinel-alert evidence. CI, reviewer verdict, diff fences, soak, holds and branch protection still apply. |
|
stage 080-awaiting-merge-admission → 050-review-pending: required-check-pending:golangci-lint |
|
@clubanderson this PR is held at Why:
Next: the hive does not push to your branch. Push a new head (or reply here); CI and the review swarm re-run automatically and the PR returns to the normal path. |
The activity monitor's lit chevron and its hover said what kind of actor
held a claimed or in-progress row (the stage_actor icon) but never who.
/api/stage-tracker rows and nested linked_prs[] now carry
claimant {kind: hive-agent|clanker|person, login, agent, hive, since,
source}, derived from the worker-claim ledger, the hive:claim marker
(with its hive fingerprint, now plumbed through Issue.ClaimHive), an
assignee, or the busy agent in the status payload; PR rows name their
author or adopting agent. The SPA appends one short token to the chevron
word (quality, quality@alchemy, @bob's clanker, @alice) and one
'Held by: … since … (source)' line to the hover; nothing when unknown.
Fixes #15422
Signed-off-by: Andrew Anderson <andy@clubanderson.com>
Signed-off-by: Andrew Anderson <andy@clubanderson.com>
Signed-off-by: Andrew Anderson <andy@clubanderson.com>
eebb796 to
b384f81
Compare
|
hive/awaiting-ci: rebased onto v5 (resolved conflicts in src/docs/api-reference/dashboard-misc.md, src/pkg/dashboard/stage_tracker.go, src/pkg/dashboard/static-src/js/tracker-row.js, src/pkg/dashboard/static/index.html, src/docs/scale-envelope.md); CI pending — sweep will merge when green. 🐝 Hive Agent: — hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88 |
|
@clubanderson this PR is back in your court (
Once the new head lands, CI and the review swarm re-run automatically and the PR returns to the normal path. |
|
stage 080-awaiting-merge-admission → 071-needs-author: hive-signoff-attribution |
There was a problem hiding this comment.
Decision needed: @clubanderson should decide whether #15425 (partial slice of #15422, CI red) is closed in favour of this PR, since both define StageTrackerClaimant / Claimant and cannot merge together.
Code reads correct to me; the blocker is the overlap with #15425.
What I verified against the tree at b384f81:
- Every helper the new file leans on exists with the signature used:
stageTrackerWorkerOn(stage_tracker_actor.go:75),timePtr(stage_tracker.go:1853),findContributor(contribute_profiles.go:429),claims.KindExternal/KindHuman(claims/claims.go:42-50),issueclaim.Claim.Hive(issueclaim.go:94). - Ledger kind mapping in
stage_tracker_claimant.go:72-80agrees with the existingstageTrackerClaimantKind(stage_tracker.go:2514-2521): contributor+external → clanker, agent → hive, else person. holderHtmlis folded intoword, which is only rendered on theactivesegment (tracker-row.js:360,369), so the suffix does not appear on done/pending chevrons.- The one
RepoWorkIssue → github.Issueconstruction site now carriesClaimHive(stage_tracker.go:2322); I found no other.
Conflict, not duplicate: #15425 (90bd989, Refs #15422) adds the same Claimant *StageTrackerClaimant field on StageTrackerItem, a second type StageTrackerClaimant in stage_tracker_actor.go, and its own stage_tracker_claimant_test.go — whichever lands second fails to compile. #15425's body lists as remaining exactly what this PR delivers (claim-comment / assignee / kick-history fallbacks, foreign hive names, PR and covering-PR identity), and its test (dashboard 4/4) and coverage checks are red at head. I have not closed anything; a maintainer should pick one, and this one is the complete fix.
— hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88
There was a problem hiding this comment.
Read the diff against v5@e0f8bd9 plus the callers; this looks correct to me, and it is the one of the two open #15422 PRs that matches the issue's spec.
Correctness (verified in the tree, head b384f81):
stage_tracker_claimant.go:66-108derivation order ledger →hive:claimmarker → assignee → kick-history matches the "Where the data is" section of #15422.KindExternal→clankerfollows the existing precedent instageTrackerClaimantKind(stage_tracker.go:2519), so the chevron and the actor icon agree.stage_tracker.go:2193-2201/2296-2302gate onstageTrackerClaimantStage(issues at 20/30, PRs at 50–79) so the merge-gate word (stageTrackerMergeGateWordHtml) is never doubled with a holder suffix;stage_tracker.go:3077mirrorsClaimantontolinked_prs[]andtracker-row.js:884,1197carry it through both sub-row paths.tracker-row.js:306escapes the login before it lands in.ham-holder;stageTrackerIsClankerOwnermemoisesfindContributorper build so assignee lookups don't hit disk once per row.go build ./pkg/dashboard/ ./pkg/github/at this head is clean; CItest(v2 Tests) is green on this head.
Conflicts with #15425 (same issue, cannot both merge): #15425 declares the same exported StageTrackerClaimant type in stage_tracker_actor.go:43-50 and the same Claimant field/JSON key on StageTrackerItem, and adds a file with the same name stage_tracker_claimant_test.go — whichever lands second fails to compile until rebased. They are not duplicates: #15425 reads only the local claims ledger (stage_tracker_actor.go:53-77), only on stage-20 issue rows (stage_tracker.go:2169), labels the source (claim ledger), and has no marker/assignee/kick-history fallback, no PR rows and no linked_prs[] mirror. Per #15422's "Proposal" (sources claim-comment|assignee|kick-history|author, PRs and covering-PR sub-rows included) this PR is the one that implements the issue; #15425 is a strict subset of it.
Flagging for a maintainer: if you agree, #15425 could be closed in favour of this one once it merges. I have not closed anything.
— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88
|
Quality note on the
Two cheap assertions would make the change fail without the fix:
Both live in the same package as the change, so no new fixtures are needed. 🐝 Hive Agent: — hive: agent=quality backend=copilot model=claude-fable-5.1 copilot=1.0.88 |
|
Thank you for your contribution! Your PR has been merged. We'd love to hear how your experience was: share feedback |
…PR (#15480) A PR row whose linked issue is already closed drew a bare `closed` chip when the hive's merged ledger did not know the closer (a PR the owner merged by hand; a merge lost across a roll), which read as the issue having been closed before its fix merged — hive's #15422 under follow-up #15425 and #15058 under #15431. The issues were in fact closed by GitHub the second #15426 / #15068 merged. The soft-link enrichment now asks GitHub which MERGED pull request closed the issue (closedByPullRequestsReferences; an open PR with Fixes #N is listed there too and is never named) and carries state_reason and closed_by on the link, so the chip reads `closed by #N`. When no merged closer is known it reads `closed · this PR unmerged` with a hover saying a person or another merged PR closed it. Docs state the rule: the hive closes an issue only after its PR has merged. Fixes #15479 Signed-off-by: Andrew Anderson <andy@clubanderson.com>
Fixes #15422
What
Activity Monitor rows now say who holds a claimed / in-progress item, on the chevron (one short token) and in the hover (one line).
Claimed · qualityHeld by: hive agent quality since 3h ago (claim comment)Claimed · quality@alchemyHeld by: hive agent quality@hosted-ibm-alchemy since 3h ago (claim comment)Claimed · @bob's clankerHeld by: @bob's clanker since 3h ago (assignee)Claimed · @aliceHeld by: @alice since 3h ago (assignee)PR in progress · fixerHeld by: hive agent fixer since just now (kick history)Returned to @bob's hive · @bob's clankerHeld by: @bob's clanker … (author)Claimed(nothing added)The existing person / robot / bee icon stays; the login sits next to it. Short hive names strip the
hosted-ibm-/hosted-prefix the same way other chips do.How
github.Issue/RepoWorkIssuegainClaimHive(from thehive=claim marker).stage_tracker_claimant.go:StageTrackerClaimant{kind, login, agent, hive, since, source}derived in order claim ledger → claim comment/marker → assignees (registered contributor ⇒ clanker, else person) → kick history; PRs derive fromauthor_kind+ worker/agent/label./api/stage-trackeritems andlinked_prs[]carryclaimant; documented indocs/api-reference/dashboard-misc.mdanddocs/dashboard-sections.md.stageTrackerClaimantShort/stageTrackerClaimantLineintracker-row.js;.ham-holderis normal-weight so the label still reads first.static/index.htmlregenerated.Tests
TestStageTrackerIssueClaimant,TestStageTrackerPRClaimant,TestStageTrackerClaimantStage(Go tables: fleet fingerprint → hive-agent with hive; registered contributor assignee → clanker; plain assignee → person; kick-history fallback; none → empty).TestStageTrackerClaimantChevronJS(Node harness: suffix on chevron, hover line present, nothing when empty, no slug leakage).go test -race ./pkg/dashboard/ -run 'StageTracker|Claim|IndexHTML', full./pkg/dashboard/,./pkg/github/ -run Claimall green locally.Screenshot
Local fixture, headless Chrome: