Skip to content

πŸ› dashboard: bigger merge bee and a visible odometer roll on the Merged counter - #15409

Merged
clubanderson merged 1 commit into
v5from
fix/bee-odometer
Oct 29, 2026
Merged

clubanderson merged 1 commit into
v5from
fix/bee-odometer

Conversation

@clubanderson

Copy link
Copy Markdown
Member

Fixes #15398

Operator feedback (hive's own spoke, 11:03 ET): the merge bee was too small to recognise, and the "mileage counter" roll on the Merged pill from #15249 was not visible in production.

Root cause

The odometer code from #15249 is deployed and does run (the chip is static HTML from tracker.html, not re-rendered per poll, so the overlay survives) β€” but a +1 moved one 12 px digit a single 15 px cell with ease-out ~80 % done in 250 ms, inside the chip's 320 ms cue-count-pop scale, nothing to the right spun, and the first draw / a reload never rolled. On the dark theme a second bug hid the day/week line entirely while it rolled: the dark token sheet has no --text-faint (only body.light-mode sets it), so the sub overlay inherited the rolling line's transparent colour.

Changes

  • Bee: .cue-flight is sized by a new --cue-flight-size: var(--fs-3xl) token (β‰ˆ32 px, was --fs-lg β‰ˆ17 px) with a --cue-flight-halo drop-shadow in the text colour (light glow on dark, dark shadow on light). STAGE_TRACKER_CELEBRATE_GLYPH_HALF centres it on the βœ“ cell. Reduced motion unchanged.
  • Odometer plan: in a risen number, the first changed wheel rolls its own distance; every wheel right of it β€” and the rightmost wheel always β€” spins at least one full turn (STAGE_TRACKER_ODOMETER_TURN) before settling, so a +1 reads as a roll and a carry's zeros whirr past. Still 900 ms ease-out, same transition.
  • Day/week line rolls with the same mechanism over STAGE_TRACKER_ODOMETER_SUB_MS (600 ms); --text-faint gets a --muted fallback so it stays visible mid-roll on dark.
  • Reload roll-up: the values shown are kept in sessionStorage (hive.tracker.merged.last); the first draw seeds from them when they are behind, so the operator sees it move on page load.
  • DOM nodes are diffed in place (data-odo-value), no recreation when unchanged; tabular-nums kept, no layout shift. No inline styles added.
  • Tests: node-harness plan/set cases (full-turn, carry 9β†’0, spinning unchanged wheel, grown number, no DOM churn, sub duration, seed/parse, sessionStorage round-trip, fresh-chip roll-up on first draw); static check that .cue-flight is sized via the token.

Mid-animation frames (headless Chrome, generated index.html + real theme tokens)

Odometer 9471 β†’ 9472 / 73 β†’ 74 / 886 β†’ 887, dark, ~120 ms and ~300 ms in:

Merged counter at 120 ms, all three wheels mid-roll
Merged counter at 300 ms, digits sliding

Bee at 32 px mid-flight, dark and light:

bee mid-flight on dark
bee mid-flight on light

…ed counter

The merge celebration glyph is drawn at --cue-flight-size (--fs-3xl,
~32px, was --fs-lg ~17px) with a theme-aware drop-shadow halo. The
Merged chip's odometer roll was running but imperceptible: a +1 moved
one 12px digit a single cell inside the chip's 320ms pop, nothing to the
right spun, and a reload never rolled. Now the rightmost wheel (and every
wheel right of the first changed digit) spins a full turn before
settling, the day/week line rolls with the same mechanism over 600ms,
and the values last shown are kept in sessionStorage so a reload rolls
up from them. The dark theme's token sheet has no --text-faint, so the
day/week overlay inherited the rolling line's transparent colour and
vanished mid-roll; it now falls back to --muted.

Fixes #15398

Signed-off-by: Andrew Anderson <andy@clubanderson.com>
@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Oct 29, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign danathar for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 29, 2026
@github-actions

github-actions Bot commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

PR Title Relation Files
#15407 ✨ tracker: show where an adopted PR came from same files src/pkg/dashboard/static-src/css/tracker.css
src/pkg/dashboard/static/index.html
#15406 πŸ› tracker: say it once, in plain words β€” simplify hovers, menus and captions same files src/pkg/dashboard/static-src/css/tracker.css
src/pkg/dashboard/static/index.html
#15400 πŸ› fix: keep merge queue position visible during sweeps same files src/pkg/dashboard/static/index.html
#15402 πŸ› fix: show adopted PR provenance in the stage tracker same files src/pkg/dashboard/static/index.html
#15408 πŸ› tracker: merge outcomes always render in the Merge gate column; pending CI is not 'red' same files src/pkg/dashboard/static-src/css/tracker.css
src/pkg/dashboard/static/index.html

@github-actions

Copy link
Copy Markdown
Contributor

Thank you for your contribution! Your PR has been merged.

We'd love to hear how your experience was: share feedback

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read static-src/js/tracker-merged.js at c0004d0. The new spin rule in stageTrackerOdometerPlan (tracker-merged.js:436-441) is sound: steps starts as [o], so for an unchanged digit on a spinning wheel the do … while (d !== nw || (spin && steps.length <= 10)) loop exits after exactly ten pushes (one full turn), and for a changed digit after a turn plus the delta; d cycles mod 10 so it cannot fail to terminate. Nothing rolls unless the number actually rose (:429 still gates on Number(b[i]) > Number(a[i])), so the "always spin the rightmost wheel" rule cannot animate a flat redraw.

The reload seed is also guarded correctly: stageTrackerOdometerSeed (:496-501) only writes data-odo-value when the element has never been written and the plan from the remembered value to the new one is non-null, and stageTrackerMergedLastParse (:505-509) rejects anything that is not {n: digits, sub: string}, so a stale or malformed sessionStorage entry falls back to the old instant first draw rather than a bogus roll. stageTrackerMergedLastSave is skipped while shown is 0 (:533), so an empty spoke never seeds a non-zero roll later.

Looks correct to me. The two red Sign-off survives the squash entries on this head are CANCELLED superseded runs; the live one passed.

β€” hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88

clubanderson added a commit that referenced this pull request Oct 29, 2026
#15409 enlarged the flying .cue-flight glyph, not the pill's
.ham-merged-ico (12px), and drew the roll as a 900ms .ham-odo overlay over
plain --fs-sm text, so at rest the Merged pill was a small hexagon and a
bold number. The counter is now a persistent drum (one .ham-odo-col wheel
per digit in a dark inset cell with a roller gradient, inner shadows and
hairline dividers; monospace tabular 18px digits; no thousands separator)
that only the changed wheels roll through, the pill's bee is 28px with the
pill and sticky bar grown to fit, reduced motion swaps instantly, and the
day/week line rolls through the same columns drawn plain.

Signed-off-by: Andrew Anderson <andy@clubanderson.com>

Fixes #15469

Signed-off-by: Andrew Anderson <andy@clubanderson.com>
clubanderson added a commit that referenced this pull request Oct 29, 2026
…15470)

#15409 enlarged the flying .cue-flight glyph, not the pill's
.ham-merged-ico (12px), and drew the roll as a 900ms .ham-odo overlay over
plain --fs-sm text, so at rest the Merged pill was a small hexagon and a
bold number. The counter is now a persistent drum (one .ham-odo-col wheel
per digit in a dark inset cell with a roller gradient, inner shadows and
hairline dividers; monospace tabular 18px digits; no thousands separator)
that only the changed wheels roll through, the pill's bee is 28px with the
pill and sticky bar grown to fit, reduced motion swaps instantly, and the
day/week line rolls through the same columns drawn plain.



Fixes #15469

Signed-off-by: Andrew Anderson <andy@clubanderson.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco-signoff: yes Indicates the PR's author has signed the DCO. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

dashboard: merge bee is too small to recognise and the Merged counter's odometer roll is not visible

1 participant