Repository navigation
π dashboard: bigger merge bee and a visible odometer roll on the Merged counter - #15409
Conversation
β¦ed counter The merge celebration glyph is drawn at --cue-flight-size (--fs-3xl, ~32px, was --fs-lg ~17px) with a theme-aware drop-shadow halo. The Merged chip's odometer roll was running but imperceptible: a +1 moved one 12px digit a single cell inside the chip's 320ms pop, nothing to the right spun, and a reload never rolled. Now the rightmost wheel (and every wheel right of the first changed digit) spins a full turn before settling, the day/week line rolls with the same mechanism over 600ms, and the values last shown are kept in sessionStorage so a reload rolls up from them. The dark theme's token sheet has no --text-faint, so the day/week overlay inherited the rolling line's transparent colour and vanished mid-roll; it now falls back to --muted. Fixes #15398 Signed-off-by: Andrew Anderson <andy@clubanderson.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of
|
|
Thank you for your contribution! Your PR has been merged. We'd love to hear how your experience was: share feedback |
There was a problem hiding this comment.
Read static-src/js/tracker-merged.js at c0004d0. The new spin rule in stageTrackerOdometerPlan (tracker-merged.js:436-441) is sound: steps starts as [o], so for an unchanged digit on a spinning wheel the do β¦ while (d !== nw || (spin && steps.length <= 10)) loop exits after exactly ten pushes (one full turn), and for a changed digit after a turn plus the delta; d cycles mod 10 so it cannot fail to terminate. Nothing rolls unless the number actually rose (:429 still gates on Number(b[i]) > Number(a[i])), so the "always spin the rightmost wheel" rule cannot animate a flat redraw.
The reload seed is also guarded correctly: stageTrackerOdometerSeed (:496-501) only writes data-odo-value when the element has never been written and the plan from the remembered value to the new one is non-null, and stageTrackerMergedLastParse (:505-509) rejects anything that is not {n: digits, sub: string}, so a stale or malformed sessionStorage entry falls back to the old instant first draw rather than a bogus roll. stageTrackerMergedLastSave is skipped while shown is 0 (:533), so an empty spoke never seeds a non-zero roll later.
Looks correct to me. The two red Sign-off survives the squash entries on this head are CANCELLED superseded runs; the live one passed.
β hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88
#15409 enlarged the flying .cue-flight glyph, not the pill's .ham-merged-ico (12px), and drew the roll as a 900ms .ham-odo overlay over plain --fs-sm text, so at rest the Merged pill was a small hexagon and a bold number. The counter is now a persistent drum (one .ham-odo-col wheel per digit in a dark inset cell with a roller gradient, inner shadows and hairline dividers; monospace tabular 18px digits; no thousands separator) that only the changed wheels roll through, the pill's bee is 28px with the pill and sticky bar grown to fit, reduced motion swaps instantly, and the day/week line rolls through the same columns drawn plain. Signed-off-by: Andrew Anderson <andy@clubanderson.com> Fixes #15469 Signed-off-by: Andrew Anderson <andy@clubanderson.com>
β¦15470) #15409 enlarged the flying .cue-flight glyph, not the pill's .ham-merged-ico (12px), and drew the roll as a 900ms .ham-odo overlay over plain --fs-sm text, so at rest the Merged pill was a small hexagon and a bold number. The counter is now a persistent drum (one .ham-odo-col wheel per digit in a dark inset cell with a roller gradient, inner shadows and hairline dividers; monospace tabular 18px digits; no thousands separator) that only the changed wheels roll through, the pill's bee is 28px with the pill and sticky bar grown to fit, reduced motion swaps instantly, and the day/week line rolls through the same columns drawn plain. Fixes #15469 Signed-off-by: Andrew Anderson <andy@clubanderson.com>
Fixes #15398
Operator feedback (hive's own spoke, 11:03 ET): the merge bee was too small to recognise, and the "mileage counter" roll on the Merged pill from #15249 was not visible in production.
Root cause
The odometer code from #15249 is deployed and does run (the chip is static HTML from
tracker.html, not re-rendered per poll, so the overlay survives) β but a +1 moved one 12 px digit a single 15 px cell with ease-out ~80 % done in 250 ms, inside the chip's 320 mscue-count-popscale, nothing to the right spun, and the first draw / a reload never rolled. On the dark theme a second bug hid the day/week line entirely while it rolled: the dark token sheet has no--text-faint(onlybody.light-modesets it), so the sub overlay inherited the rolling line'stransparentcolour.Changes
.cue-flightis sized by a new--cue-flight-size: var(--fs-3xl)token (β32 px, was--fs-lgβ17 px) with a--cue-flight-halodrop-shadow in the text colour (light glow on dark, dark shadow on light).STAGE_TRACKER_CELEBRATE_GLYPH_HALFcentres it on the β cell. Reduced motion unchanged.STAGE_TRACKER_ODOMETER_TURN) before settling, so a +1 reads as a roll and a carry's zeros whirr past. Still 900 ms ease-out, same transition.STAGE_TRACKER_ODOMETER_SUB_MS(600 ms);--text-faintgets a--mutedfallback so it stays visible mid-roll on dark.sessionStorage(hive.tracker.merged.last); the first draw seeds from them when they are behind, so the operator sees it move on page load.data-odo-value), no recreation when unchanged;tabular-numskept, no layout shift. No inline styles added..cue-flightis sized via the token.Mid-animation frames (headless Chrome, generated index.html + real theme tokens)
Odometer 9471 β 9472 / 73 β 74 / 886 β 887, dark, ~120 ms and ~300 ms in:
Bee at 32 px mid-flight, dark and light: