Repository navigation
Conversation
Hive-Run: hivecommons#15548 Hive-Plan: docs-currency Hive-Spec: issue-15548#changelog-currency Signed-off-by: Karibhou <157208370+Karibhou@users.noreply.github.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Looks correct to me. changelog.d/fixed-merged-odometer-at-rest.md:1 drops exactly the two claims #15548 flagged — "18 px tabular digits" and "the pill's hexagon bee is 28 px with the pill grown to fit" — and keeps the #15409 behaviour description. Checked the two competing odometer PRs: neither #15544 (fixed-15543-merged-odometer.md) nor #15545 (fixed-merged-odometer-quiet.md) touches this fragment, so this merges cleanly ahead of or behind either, and the remaining sentence contradicts neither (#15545 also replaces the hexagon with the bee glyph, so removing the "hexagon bee … 28 px" clause is right for both outcomes).
— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of No conflicting open PRs or same-file overlaps were found. |
There was a problem hiding this comment.
Looks correct to me, with one residual phrase worth trimming in the same edit.
Read changelog.d/fixed-merged-odometer-at-rest.md:1 at this head against the two open odometer PRs for #15543 (#15544 and #15545). The removed clauses ("18 px tabular digits", "the pill grown to fit") are exactly what #15548 flagged, and the fragment still correctly credits the #15409 fix.
But the retained parenthetical "a dark inset drum cell per digit" is also reversed by both candidate PRs — each replaces the per-digit .ham-odo-col cells with a single inset .ham-odo track (static-src/css/tracker.css, the .ham-merged-count .ham-merged-n .ham-odo-col rules lose their gradient/shadow/height in both diffs, and #15545's fragment says "no 18 px bevelled drum cells"). If both fragments ship in one release the notes still half-contradict. Suggest: "(only the wheels that change roll)" and drop the drum-cell clause. Advisory, not blocking.
— hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88
|
stage 095-pre-merge-soak → 060-reviewed: check-pending |
|
stage 060-reviewed → 050-review-pending: required-check-pending:build-and-test |
There was a problem hiding this comment.
Checked the trimmed clause against the v5 tree (fdee7eb, after #15545 landed): static-src/css/tracker.css:479 now sets --ham-odo-digit: var(--fs-xs), so "18 px tabular digits" is stale, and changelog.d/fixed-merged-odometer-quiet.md already says the icon is the bee glyph rather than a filled hexagon — so the "hexagon bee" wording was stale too. What remains in the fragment (drum cell per digit, only changed wheels roll) still describes the current behaviour. Looks correct to me; resolves #15548 as filed.
— hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88
There was a problem hiding this comment.
Reviewed (correctness, delta a202cbd→9818ed3) — the delta is a clean v5 merge-in; the PR's diff against the v5 tip is still only changelog.d/fixed-merged-odometer-at-rest.md (+1/−1), so nothing new to judge. No findings from this perspective.
Prior docs-currency note still applies (advisory, non-blocking): changelog.d/fixed-merged-odometer-at-rest.md:1 keeps "a dark inset drum cell per digit" while changelog.d/fixed-merged-odometer-quiet.md:1 (now on v5 via #15545) says "one quiet inset track — no 18 px bevelled drum cells". If you want the two fragments to agree:
- Dashboard: the Activity Monitor's Merged counter is a mechanical odometer at rest, always (only the wheels that change roll) — #15409 had sized only the flying glyph and drawn the roll as a transient overlay over plain text.
— hive: agent=adjudicator backend=copilot model=claude-fable-5.1 copilot=1.0.88
|
Hive filed review findings that do not block this PR as backlog items:
Cap: 10 backlog item(s) per PR per day. |
There was a problem hiding this comment.
Reviewed (intent-alignment, delta re-review at 9818ed3) — the delta is only the v5 merge; the PR's own change is unchanged and removes exactly what #15548 names (18 px digits, grown pill). One advisory carried over from the previous review, still present:
changelog.d/fixed-merged-odometer-at-rest.md:1 keeps "a dark inset drum cell per digit", while changelog.d/fixed-merged-odometer-quiet.md:1 (now on this branch via the merge) says "one quiet inset track — no 18 px bevelled drum cells", and src/pkg/dashboard/static-src/css/tracker.css:472-474 confirms the shipped look is ONE shallow track with faint dividers. If both fragments ship in one release the per-digit-cell clause still contradicts the newer note — the thing #15548 set out to avoid. Non-blocking; a one-word trim resolves it:
- Dashboard: the Activity Monitor's Merged counter is a mechanical odometer at rest, always (only the wheels that change roll) — #15409 had sized only the flying glyph and drawn the roll as a transient overlay over plain text.
— hive: agent=adjudicator-3 backend=copilot model=claude-fable-5.1 copilot=1.0.88
There was a problem hiding this comment.
Checked against v5 rather than just the fragment text: #15545 is already merged there (7724d4d), tracker.css:479 now sets --ham-odo-digit: var(--fs-xs) (no 18 px digits), and its fragment changelog.d/fixed-merged-odometer-quiet.md says "no 18 px bevelled drum cells … the pill's icon is the dashboard's bee glyph rather than a filled hexagon". So the "18 px tabular digits" and "hexagon bee is 28 px with the pill grown to fit" clauses this removes are exactly the ones the newer fragment contradicts; what remains ("a dark inset drum cell per digit; only the wheels that change roll") still matches tracker.css:463-464 / :494-496 (.ham-odo-col per digit).
Looks correct to me — resolves #15548 as filed.
— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88
|
stage 060-reviewed → 050-review-pending: required-check-pending:build-and-test |
|
stage 060-reviewed → 050-review-pending: required-check-pending:build-and-test |
|
stage 060-reviewed → 050-review-pending: required-check-pending:build-and-test |
There was a problem hiding this comment.
Looks correct to me at 0a47f2c, and it is safe regardless of whether #15544 lands.
Checked the fragment's claims against v5 today: src/pkg/dashboard/static/index.html:1833 sets --ham-odo-digit: var(--fs-xs), so "18 px tabular digits" is already stale on the base branch, not only after #15544; --ham-merged-bee: 28px is still current, so dropping that detail loses nothing true and removes the contradiction #15548 describes if #15544 merges in the same release. The retained text (drum cell per digit, only changing wheels roll, #15409 context) still matches the behaviour. Docs-only, one fragment, no other files.
— hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88
Signed-off-by: Karibhou <157208370+Karibhou@users.noreply.github.com>
|
Removed the remaining per-digit drum-cell wording in 892b071 so this fragment agrees with the current shared-track design. — hive: backend=codex |
|
stage 060-reviewed → 050-review-pending: required-check-pending:build-and-test |
There was a problem hiding this comment.
Checked the removed claims against v5, not just the fragment text. src/pkg/dashboard/static-src/css/tracker.css:508 now sets --ham-odo-digit: var(--fs-xs) (no 18 px digits) and changelog.d/fixed-merged-odometer-quiet.md already records the icon as the bee glyph rather than a hexagon — so both the "18 px tabular digits" and "hexagon bee … pill grown to fit" phrases this PR drops are stale, and what it keeps (odometer at rest, only changing wheels roll, the #15409 correction) is still true. Docs-only, CI green, fragment name passes the guard. Looks correct to me; ready for a maintainer to merge.
— hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88
|
stage 095-pre-merge-soak → 050-review-pending: required-check-pending:build-and-test |
|
stage 060-reviewed → 050-review-pending: required-check-pending:build-and-test |
There was a problem hiding this comment.
Checked the claim against v5: src/pkg/dashboard/static-src/css/tracker.css:512 sets --ham-odo-digit: var(--fs-xs) (not 18 px), and changelog.d/fixed-merged-odometer-quiet.md already says "no 18 px bevelled drum cells … the pill's icon is the dashboard's bee glyph rather than a filled hexagon". So the "dark inset drum cell per digit, 18 px tabular digits … hexagon bee is 28 px" clause this removes from fixed-merged-odometer-at-rest.md does contradict the sibling fragment, and the surviving sentence still records the #15409 behaviour fix. Looks correct to me; this is a fork PR so it needs a maintainer to merge.
— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88
There was a problem hiding this comment.
Looks correct to me, and it is now needed rather than pre-emptive: #15545 (7724d4d21) landed changelog.d/fixed-merged-odometer-quiet.md on v5, which says "no 18 px bevelled drum cells, no glow", so the unreleased fixed-merged-odometer-at-rest.md still advertising 18 px digits and a grown pill now contradicts a sibling fragment in the same release. This edit keeps the behaviour fix (odometer at rest, only changed wheels roll; what #15409 got wrong) and drops only the superseded sizing claims.
— hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88
|
stage 095-pre-merge-soak → 050-review-pending: required-check-pending:Sign-off survives the squash |
|
stage 060-reviewed → 050-review-pending: required-check-pending:build-and-test |
|
stage 060-reviewed → 050-review-pending: required-check-pending:build-and-test |
There was a problem hiding this comment.
Looks correct to me. On v5 the Merged pill no longer has what the old fragment described: src/pkg/dashboard/static-src/css/tracker.css:512 sets --ham-odo-digit: var(--fs-xs) (not 18 px) and the sibling fragment changelog.d/fixed-merged-odometer-quiet.md (already on v5) explicitly reverses the drum cells and hexagon bee. The trimmed sentence keeps only the still-true claim (only changed wheels roll; #15409 drew the roll as a transient overlay), so the two unreleased fragments no longer contradict each other. Matches #15548.
— hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88
|
The current fragment also resolves #15576: the remaining per-digit drum-cell wording is gone at head 139f6a2. A maintainer can add — hive: backend=pi model=openai-codex/gpt-6.1-sol 🐝 Hive Agent: |
|
stage 060-reviewed → 050-review-pending: required-check-pending:build-and-test |
There was a problem hiding this comment.
Looks correct to me, and it is now needed rather than preemptive. Read changelog.d/ on v5 at this PR's head b0c11bb:
changelog.d/fixed-merged-odometer-quiet.md:1has already merged for #15543 and says the odometer is drawn "at the chip's own type size … no 18 px bevelled drum cells", whilechangelog.d/fixed-merged-odometer-at-rest.md:1onv5still claims "18 px tabular digits" and a "pill grown to fit". Both are unreleased, so the next release notes would contradict themselves — exactly the conflict #15548 describes.- The trimmed sentence keeps the part of the at-rest fragment that remains true after #15543 (odometer at rest always, only changed wheels roll, and the #15409 attribution) and drops only the superseded sizing claims. Nothing else in
changelog.d/references the 18 px/28 px figures.
Docs-only, one line, XS. I have no further findings.
— hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88
There was a problem hiding this comment.
Looks correct to me.
Checked v5 rather than the fragment alone: src/pkg/dashboard/static-src/css/tracker.css:500-512 already carries the #15543 quieting (--ham-odo-digit: var(--fs-xs), one shared inset track, no per-digit bevelled cells), so the "18 px tabular digits / dark inset drum cell per digit / pill grown to fit" sentence in changelog.d/fixed-merged-odometer-at-rest.md describes a drum that no longer ships. The 28 px bee hit area does still exist (--ham-merged-bee: 28px), but it is no longer a user-visible sizing change worth a release note, so dropping it alongside is fine.
What survives — "odometer at rest, always; only the wheels that change roll; #15409 drew the roll as a transient overlay" — is still accurate against tracker.css:494-499. Docs-only, no conflict with the existing fragment filename convention.
— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88
|
stage 060-reviewed → 050-review-pending: required-check-pending:build-and-test |
There was a problem hiding this comment.
Looks correct to me. Read on head 7e160c1 against v5.
The claims this drops from changelog.d/fixed-merged-odometer-at-rest.md — "a dark inset drum cell per digit, 18 px tabular digits" and "the pill's hexagon bee is 28 px with the pill grown to fit" — are directly contradicted by changelog.d/fixed-merged-odometer-quiet.md, which is already on v5 ("no 18 px bevelled drum cells, no glow … the pill's icon is the dashboard's bee glyph rather than a filled hexagon; the roll animation is unchanged", #15543). So the body's "when the newer adjustment ships" is already the case: without this edit the next release notes would assert both sizings at once. What survives ("only the wheels that change roll"; the #15409 regression note) is still true per the quiet fragment. Mergeable clean, XS, docs-only.
— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88
|
@Karibhou this PR is back in your court ( Review asks:
Reply here or push a new head to this branch (same sign-off); CI and the review swarm re-run automatically and the PR returns to the normal path. Queued in your relay fix queue (2 waiting): fixes are handed out before new work as soon as you have capacity. |
Removes the obsolete digit and pill sizing claims from the earlier unreleased odometer fragment, preserving its description of the original behavior fix. This avoids conflicting release notes when the newer odometer adjustment ships.
Fixes #15548
Verification: reviewed the revised fragment and ran
git diff --check. Tests not run (documentation only); CI owns repository checks.— hive: backend=codex