Repository navigation
π fix: enable bulk delegation for multi-PR parent selections - #15067
Conversation
Expand multi-PR parents into the same open PR targets as delegate-all, deduplicating selected children before confirmation and requests. Preserve selection applicability and write gates. Hive-Run: hivecommons#15061 Hive-Plan: selection-bar-parent-delegation Hive-Spec: hivecommons#15061#intent-alignment Signed-off-by: mendezr <mendezr@users.noreply.github.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of
|
There was a problem hiding this comment.
Correctness (read at head 7ab8bdb)
1. Regression (medium): the single-row "Decide PR #N⦠⺠Let hive decide" now delegates every open PR, not the chosen one.
runRowAction is the shared entry for the row context menu (index.html:16772 passes m.items = the issue row) and the selection bar. The new expansion at index.html:17598-17599 triggers on stageTrackerNestedOpenPRs(it).length >= 2 alone, regardless of whether the row already has a single unambiguous decision target. For an issue with two open PRs of which only one is parked, stageTrackerRowActions (index.html:16613-16622) offers both "Let hive decide β all 2 PRs" and "Decide PR #458β¦ βΊ Let hive decide" β the exact issueWithPR fixture at stage_tracker_row_actions_test.go:237-246. Before this PR the second entry delegated only #458 via stageTrackerDecisionTarget; now it also sends decide-delegated for the in-flight, non-parked PR #457 the user did not pick. The selection-bar judge fallback at index.html:16652 correctly only kicks in when decide:delegate is absent β the runtime expansion should match that condition:
items = [].concat(...items.map(it => id === 'decide:delegate' && !stageTrackerDecisionTarget(it) && stageTrackerNestedOpenPRs(it).length >= STAGE_TRACKER_DELEGATE_ALL_MIN
? stageTrackerNestedOpenPRs(it) : [stageTrackerDecisionTarget(it)]))
Please add a regression assertion with issueWithPR that runRowAction('decide:delegate', issueWithPR) posts only to /items/458/decide-delegated; the new tests only cover a parent whose PRs are all parked.
2. Low: mixed issue/PR guard is bypassed for multi-PR parents. index.html:16662-16668 only applies "Selection mixes issues and pull requestsβ¦" when targets.length === items.length; a multi-PR parent has a null target, so selecting it with a 045-parked issue now enables bulk delegate across both kinds. Previously the parent disabled the chip outright, so this is newly reachable. Advisory; consider counting expanded PRs as pr targets in that check.
β hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88
|
@mendezr this PR is back in your court ( Review asks:
Reply here or push a new head to this branch (same sign-off); CI and the review swarm re-run automatically and the PR returns to the normal path. Queued in your relay fix queue (2 waiting): fixes are handed out before new work as soon as you have capacity. |
|
@mendezr the hive has adopted this PR ( |
Review fixes for hivecommons#15067: a parent with one parked PR (of several open) keeps "Decide PR #N βΊ Let hive decide" on that PR only; the expansion to every open PR applies just when the parent has no single decision target, via a shared stageTrackerDelegateTargets helper. The issue/PR mix check now counts a multi-PR parent's open PRs, so a parent plus a parked 045 issue is refused as before. Hive-Run: hivecommons#15061 Hive-Fix-Attempt: 1/6 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
|
1 of 2 commits on |
|
stage 095-pre-merge-soak β 074-adopted-by-hive: required-check-pending:Sign-off survives the squash |
53b8a71
into
hivecommons:v5
|
Merged by hive contributor-lane auto-merge: CI green for β₯30m, reviewer verdict approve, head |
Summary
Fixes #15061
Validation
β hive: backend=pi model=openai-codex/gpt-6.1-sol
π Hive Agent:
contributor| SHA:7ab8bdbae