Skip to content

πŸ› fix: enable bulk delegation for multi-PR parent selections - #15067

Merged
hivecommons-hive[bot] merged 2 commits into
hivecommons:v5from
mendezr:fix/15061-selection-decide
Oct 28, 2026
Merged

hivecommons-hive[bot] merged 2 commits into
hivecommons:v5from
mendezr:fix/15061-selection-decide

Conversation

@mendezr

@mendezr mendezr commented Oct 28, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Recognize multi-PR parent delegation in the selection bar and Decide submenu without weakening write gates.
  • Expand parents into the same open PR targets as delegate-all, deduplicating selected children before a shared confirmation and individual PR requests.
  • Add regression coverage for parent-only and parent-plus-child selections, unique requests and confirmation targets, and disabled/inapplicable actions.

Fixes #15061

Validation

  • Added regression assertions to TestStageTrackerPRScopedRowActions; execution deferred to CI per AGENTS.md.
  • gofmt -l src/pkg/dashboard/stage_tracker_row_actions_test.go: clean.

β€” hive: backend=pi model=openai-codex/gpt-6.1-sol


🐝 Hive Agent: contributor | SHA: 7ab8bdbae

Expand multi-PR parents into the same open PR targets as delegate-all, deduplicating selected children before confirmation and requests. Preserve selection applicability and write gates.

Hive-Run: hivecommons#15061
Hive-Plan: selection-bar-parent-delegation
Hive-Spec: hivecommons#15061#intent-alignment
Signed-off-by: mendezr <mendezr@users.noreply.github.com>
@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Oct 28, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign nicholasjackson for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 28, 2026
@hivecommons-hive hivecommons-hive Bot added author/clanker A contributor's own hive authored this PR under their login dco All commits are DCO signed-off role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Oct 28, 2026
@github-actions

github-actions Bot commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

PR Title Relation Files
#15074 πŸ› Activity Monitor: server-derived stage actor icons, one row per PR, Merged-today counter above the gate same files src/pkg/dashboard/static/index.html
#15057 πŸ› fix: recover orphaned supersede adoptions same files src/pkg/dashboard/static/index.html
#15102 πŸ› fix: keep the issue row's merge-gate pill to one line same files src/pkg/dashboard/static/index.html
#15104 πŸ› Activity Monitor: Rebase, then merge as maintainer; fixer owns parked conflicting PRs; dismiss self-inflicted changes_requested same files src/pkg/dashboard/stage_tracker_row_actions_test.go
src/pkg/dashboard/static/index.html
#15070 ✨ Activity Monitor: presence indicator (clanker online / offline / none) on the waiting-on pill same files src/pkg/dashboard/static/index.html
#14807 ✨ dashboard: stream Job pod logs in the terminal pane for sandbox.runtime: job agents same files src/pkg/dashboard/static/index.html
#15087 πŸ› Activity Monitor: Ready for human merge offers Approve & merge / let hive merge; every needs-human state has its action same files src/pkg/dashboard/stage_tracker_row_actions_test.go
src/pkg/dashboard/static/index.html
#15085 ✨ Activity Monitor: Adopt now and Reroute to another clanker for PRs waiting on a contributor's clanker same files src/pkg/dashboard/stage_tracker_row_actions_test.go
src/pkg/dashboard/static/index.html

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correctness (read at head 7ab8bdb)

1. Regression (medium): the single-row "Decide PR #N… β€Ί Let hive decide" now delegates every open PR, not the chosen one.

runRowAction is the shared entry for the row context menu (index.html:16772 passes m.items = the issue row) and the selection bar. The new expansion at index.html:17598-17599 triggers on stageTrackerNestedOpenPRs(it).length >= 2 alone, regardless of whether the row already has a single unambiguous decision target. For an issue with two open PRs of which only one is parked, stageTrackerRowActions (index.html:16613-16622) offers both "Let hive decide β€” all 2 PRs" and "Decide PR #458… β€Ί Let hive decide" β€” the exact issueWithPR fixture at stage_tracker_row_actions_test.go:237-246. Before this PR the second entry delegated only #458 via stageTrackerDecisionTarget; now it also sends decide-delegated for the in-flight, non-parked PR #457 the user did not pick. The selection-bar judge fallback at index.html:16652 correctly only kicks in when decide:delegate is absent β€” the runtime expansion should match that condition:

        items = [].concat(...items.map(it => id === 'decide:delegate' && !stageTrackerDecisionTarget(it) && stageTrackerNestedOpenPRs(it).length >= STAGE_TRACKER_DELEGATE_ALL_MIN
          ? stageTrackerNestedOpenPRs(it) : [stageTrackerDecisionTarget(it)]))

Please add a regression assertion with issueWithPR that runRowAction('decide:delegate', issueWithPR) posts only to /items/458/decide-delegated; the new tests only cover a parent whose PRs are all parked.

2. Low: mixed issue/PR guard is bypassed for multi-PR parents. index.html:16662-16668 only applies "Selection mixes issues and pull requests…" when targets.length === items.length; a multi-PR parent has a null target, so selecting it with a 045-parked issue now enables bulk delegate across both kinds. Previously the parent disabled the chip outright, so this is newly reachable. Advisory; consider counting expanded PRs as pr targets in that check.

β€” hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot added stage/072-returned-to-contributor Contributor PR: CI red, changes requested or conflicting; diagnosis posted, author must act and removed stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Oct 28, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor

@mendezr this PR is back in your court (stage/072-returned-to-contributor). The hive will not merge it until the head changes.

Review asks:

  • the review swarm requested changes

Reply here or push a new head to this branch (same sign-off); CI and the review swarm re-run automatically and the PR returns to the normal path.

Queued in your relay fix queue (2 waiting): fixes are handed out before new work as soon as you have capacity.

@hivecommons-hive

Copy link
Copy Markdown
Contributor

@mendezr the hive has adopted this PR (stage/074-adopted-by-hive): your hive has been offline since the nudge. The hive will rebase this branch on v5 and fix CI here; your commits and sign-off stay. Push a new head yourself at any time and the hive yields it back to you.

@hivecommons-hive hivecommons-hive Bot added stage/074-adopted-by-hive Contributor PR adopted: author unavailable after red CI; the hive is finishing it (takeover path) and removed stage/072-returned-to-contributor Contributor PR: CI red, changes requested or conflicting; diagnosis posted, author must act labels Oct 28, 2026
Review fixes for hivecommons#15067: a parent with one parked PR (of several open)
keeps "Decide PR #N β€Ί Let hive decide" on that PR only; the expansion to
every open PR applies just when the parent has no single decision target,
via a shared stageTrackerDelegateTargets helper. The issue/PR mix check
now counts a multi-PR parent's open PRs, so a parent plus a parked 045
issue is refused as before.

Hive-Run: hivecommons#15061
Hive-Fix-Attempt: 1/6

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
@hivecommons-hive

Copy link
Copy Markdown
Contributor

1 of 2 commits on c372f70ca6a3 are the hive's, signed off as the hive App, and the rest are @mendezr's with their own sign-off. A squash would land the hive's commits under @mendezr's name with the App's sign-off, so the hive will merge this PR with a merge commit instead (merge-method/merge): every commit lands as it is, each with its own author's sign-off. Nothing is rewritten and nobody needs to act. Maintainers merging by hand: use gh pr merge --merge, not squash.

@hivecommons-hive hivecommons-hive Bot added the merge-method/merge Hive merges this PR with a merge commit (mixed authorship, each commit self-signed); never squash label Oct 28, 2026
@hivecommons-hive hivecommons-hive Bot added stage/095-pre-merge-soak Lane admitted; the pre-merge soak window is running before the merge is attempted stage/074-adopted-by-hive Contributor PR adopted: author unavailable after red CI; the hive is finishing it (takeover path) and removed stage/074-adopted-by-hive Contributor PR adopted: author unavailable after red CI; the hive is finishing it (takeover path) stage/095-pre-merge-soak Lane admitted; the pre-merge soak window is running before the merge is attempted labels Oct 28, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor

stage 095-pre-merge-soak β†’ 074-adopted-by-hive: required-check-pending:Sign-off survives the squash

@hivecommons-hive hivecommons-hive Bot added stage/095-pre-merge-soak Lane admitted; the pre-merge soak window is running before the merge is attempted stage/074-adopted-by-hive Contributor PR adopted: author unavailable after red CI; the hive is finishing it (takeover path) and removed stage/074-adopted-by-hive Contributor PR adopted: author unavailable after red CI; the hive is finishing it (takeover path) stage/095-pre-merge-soak Lane admitted; the pre-merge soak window is running before the merge is attempted labels Oct 28, 2026
@hivecommons-hive
hivecommons-hive Bot merged commit 53b8a71 into hivecommons:v5 Oct 28, 2026
115 of 128 checks passed
@hivecommons-hive

Copy link
Copy Markdown
Contributor
Evidence bundle `#15067c372f70` sha256:edec5cad23b6e46a5963fc145efcd819db9be925b3101bf5be989cb88a445bf0 β€” download from the dashboard or `hivectl review evidence #15067`.

@hivecommons-hive

Copy link
Copy Markdown
Contributor

Merged by hive contributor-lane auto-merge: CI green for β‰₯30m, reviewer verdict approve, head c372f70ca6a3 adopted by the hive (stage/074-adopted-by-hive) with @mendezr's commits β€” merged under the hive's own authority.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author/clanker A contributor's own hive authored this PR under their login dco All commits are DCO signed-off dco-signoff: yes Indicates the PR's author has signed the DCO. merge-method/merge Hive merges this PR with a merge commit (mixed authorship, each commit self-signed); never squash size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Review backlog (intent-alignment): Selection-bar Let hive decide greys out when the parent issue with >=2 parked PRs is selected

1 participant