Repository navigation
π fix(dashboard): show newly opened issues and PRs in the Activity Monitor immediately with a 000-new pre-stage state - #15097
Conversation
β¦ew pre-stage state A brand-new issue or PR was invisible in the Hive activity monitor until the governor's next publish: the opened webhook re-read only rewrote rows the status already listed, and the governor classifier dropped an un-admitted contributor's issue as Unknown when unlisted. - Insert unlisted open items from the webhook re-read (apply + replay); governor side keeps the reporter_triage row in its cached snapshot. - Derive a 000-new pre-stage state (next mover, next pass, gates) and render it in the Open column with a gates tooltip. - Refit the repo work breakdown when a recount changes the lists. - Go tests for the insert and derivation, node fixture for the row. - Docs and changelog fragment. Fixes #15094 Signed-off-by: Andrew Anderson <andy@clubanderson.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@clubanderson is auto-promoted for contributor-lane merging on this PR: the last 5 merged PRs by this author in this hive's repositories have no revert or sentinel-alert evidence. CI, reviewer verdict, diff fences, soak, holds and branch protection still apply. |
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of
|
|
Thank you for your contribution! Your PR has been merged. We'd love to hear how your experience was: share feedback |
Fixes #15094
Why #15092 was invisible
#15092 (a human contributor's issue, opened 20:38Z) did not appear in
/api/stage-trackerfor ~8 minutes. Two gaps:issues.openedwebhook re-read ran within 3 s, butpatchFrontendRepoItemonly rewrote rows the status lists already carried β a brand-new item was a no-op.classifyWebhookIssuereturnedWebhookBucketUnknownfor a CONTRIBUTOR reporter the reporter-trust gate had not admitted, andapplyWebhookItemdropped an unlisted Unknown item. Only aftertriage/acceptedlanded (20:41Z) did the labelled re-read put it in the cached snapshot, and the dashboard saw it on the governor's next publish (~20:45:40Z).Fix
insertFrontendRepoItemadds an open item none of the repo's lists carry, on the live apply and on the post-publish replay; an open read behind a remembered newer close is not re-listed. Governor side: an un-admitted reporter's issue is offered as areporter_triageWorkIssueand inserted when unlisted. The enumeration poll remains the fallback.000-newpre-stage state βstage_tracker_new.goderivesnew{since, next_mover, next_mover_text, next_pass_at, next_pass_in_seconds, gates[], text}for an open item nothing has placed yet. Caption:New Β· waiting for the stage-label pass (β 010 actionable), then the scanner (next pass in 7m), orNew Β· waiting for a maintainer's triage (addtriage/accepted); the hive's next pass in 7mwhile the reporter gate holds it. Next pass =governor.nextKickAt.ham-open-new, tokens only), tooltip lists the gates ahead (triage β actionable β claimed) with β/β/Β· marks, actor icon follows the next mover.recountRepoOpenItemsnow refits the repo work breakdown so the Overview partition follows an insert.Tests
pkg/github:TestClassifyWebhookIssue_UnadmittedReporterCarriesTriageRow,TestApplyWebhookItem_UnlistedUnknownInsertsOfferedRow.pkg/dashboard:TestWebhookOpenedItemInsertedIntoTracker,TestWebhookOpenedInsertRespectsRememberedClose,TestStageTrackerNewState,TestStageTrackerNewRowRendering(node fixture via stdin).Docs
src/docs/dashboard-sections.md(New row),src/docs/labels-and-control-signals.md(Before any stage:000-new),changelog.d/fixed-tracker-000-new.md.