Skip to content

πŸ› fix(dashboard): show newly opened issues and PRs in the Activity Monitor immediately with a 000-new pre-stage state - #15097

Merged
clubanderson merged 1 commit into
v5from
fix/tracker-000-new
Oct 28, 2026
Merged

clubanderson merged 1 commit into
v5from
fix/tracker-000-new

Conversation

@clubanderson

Copy link
Copy Markdown
Member

Fixes #15094

Why #15092 was invisible

#15092 (a human contributor's issue, opened 20:38Z) did not appear in /api/stage-tracker for ~8 minutes. Two gaps:

  1. Dashboard: the issues.opened webhook re-read ran within 3 s, but patchFrontendRepoItem only rewrote rows the status lists already carried β€” a brand-new item was a no-op.
  2. Governor: classifyWebhookIssue returned WebhookBucketUnknown for a CONTRIBUTOR reporter the reporter-trust gate had not admitted, and applyWebhookItem dropped an unlisted Unknown item. Only after triage/accepted landed (20:41Z) did the labelled re-read put it in the cached snapshot, and the dashboard saw it on the governor's next publish (~20:45:40Z).

Fix

  • Webhook insert β€” insertFrontendRepoItem adds an open item none of the repo's lists carry, on the live apply and on the post-publish replay; an open read behind a remembered newer close is not re-listed. Governor side: an un-admitted reporter's issue is offered as a reporter_triage WorkIssue and inserted when unlisted. The enumeration poll remains the fallback.
  • 000-new pre-stage state β€” stage_tracker_new.go derives new{since, next_mover, next_mover_text, next_pass_at, next_pass_in_seconds, gates[], text} for an open item nothing has placed yet. Caption: New Β· waiting for the stage-label pass (β†’ 010 actionable), then the scanner (next pass in 7m), or New Β· waiting for a maintainer's triage (add triage/accepted); the hive's next pass in 7m while the reporter gate holds it. Next pass = governor.nextKickAt.
  • SPA β€” the Open chevron reads New (ham-open-new, tokens only), tooltip lists the gates ahead (triage β†’ actionable β†’ claimed) with βœ“/β†’/Β· marks, actor icon follows the next mover.
  • recountRepoOpenItems now refits the repo work breakdown so the Overview partition follows an insert.

Tests

  • pkg/github: TestClassifyWebhookIssue_UnadmittedReporterCarriesTriageRow, TestApplyWebhookItem_UnlistedUnknownInsertsOfferedRow.
  • pkg/dashboard: TestWebhookOpenedItemInsertedIntoTracker, TestWebhookOpenedInsertRespectsRememberedClose, TestStageTrackerNewState, TestStageTrackerNewRowRendering (node fixture via stdin).

Docs

src/docs/dashboard-sections.md (New row), src/docs/labels-and-control-signals.md (Before any stage: 000-new), changelog.d/fixed-tracker-000-new.md.

…ew pre-stage state

A brand-new issue or PR was invisible in the Hive activity monitor until
the governor's next publish: the opened webhook re-read only rewrote rows
the status already listed, and the governor classifier dropped an
un-admitted contributor's issue as Unknown when unlisted.

- Insert unlisted open items from the webhook re-read (apply + replay);
  governor side keeps the reporter_triage row in its cached snapshot.
- Derive a 000-new pre-stage state (next mover, next pass, gates) and
  render it in the Open column with a gates tooltip.
- Refit the repo work breakdown when a recount changes the lists.
- Go tests for the insert and derivation, node fixture for the row.
- Docs and changelog fragment.

Fixes #15094

Signed-off-by: Andrew Anderson <andy@clubanderson.com>
@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Oct 28, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign danathar for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Oct 28, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor

@clubanderson is auto-promoted for contributor-lane merging on this PR: the last 5 merged PRs by this author in this hive's repositories have no revert or sentinel-alert evidence. CI, reviewer verdict, diff fences, soak, holds and branch protection still apply.

@github-actions

github-actions Bot commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

PR Title Relation Files
#15074 πŸ› Activity Monitor: server-derived stage actor icons, one row per PR, Merged-today counter above the gate same files src/docs/dashboard-sections.md
src/pkg/dashboard/stage_tracker.go
src/pkg/dashboard/static/index.html
#15057 πŸ› fix: recover orphaned supersede adoptions same files src/docs/labels-and-control-signals.md
src/pkg/dashboard/stage_tracker.go
src/pkg/dashboard/static/index.html
#15087 πŸ› Activity Monitor: Ready for human merge offers Approve & merge / let hive merge; every needs-human state has its action same files src/docs/dashboard-sections.md
src/pkg/dashboard/stage_tracker.go
src/pkg/dashboard/static/index.html
#15085 ✨ Activity Monitor: Adopt now and Reroute to another clanker for PRs waiting on a contributor's clanker same files src/docs/dashboard-sections.md
src/docs/labels-and-control-signals.md
src/pkg/dashboard/stage_tracker.go
src/pkg/dashboard/static/index.html
#15102 πŸ› fix: keep the issue row's merge-gate pill to one line same files src/docs/dashboard-sections.md
src/pkg/dashboard/static/index.html
#15070 ✨ Activity Monitor: presence indicator (clanker online / offline / none) on the waiting-on pill same files src/docs/dashboard-sections.md
src/docs/labels-and-control-signals.md
src/pkg/dashboard/stage_tracker.go
src/pkg/dashboard/static/index.html
#15067 πŸ› fix: enable bulk delegation for multi-PR parent selections same files src/pkg/dashboard/static/index.html
#14807 ✨ dashboard: stream Job pod logs in the terminal pane for sandbox.runtime: job agents same files src/pkg/dashboard/static/index.html

@hivecommons-hive hivecommons-hive Bot added author/human A person pushed this PR themselves dco All commits are DCO signed-off role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Oct 28, 2026
@clubanderson
clubanderson merged commit c1abe7c into v5 Oct 28, 2026
81 of 85 checks passed
@kubestellar-prow
kubestellar-prow Bot deleted the fix/tracker-000-new branch October 28, 2026 21:31
@github-actions

Copy link
Copy Markdown
Contributor

Thank you for your contribution! Your PR has been merged.

We'd love to hear how your experience was: share feedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author/human A person pushed this PR themselves dco All commits are DCO signed-off dco-signoff: yes Indicates the PR's author has signed the DCO. role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. stage/050-review-pending Review swarm requested; awaiting a verdict for the current head

Projects

None yet

Development

Successfully merging this pull request may close these issues.

πŸ› Activity Monitor: newly opened issues/PRs invisible until next governor publish; no pre-stage "new" state

1 participant