Repository navigation
🐛 Reporter-trust hold: never hold hive-authored PRs, judge only linked issues, show and release hive-set holds - #15080
Conversation
…issues, show and release hive-set holds The #9665 reporter-trust merge hold judged #15020, a hive-authored PR, via a bare '#15017' mention that resolved to a sibling PR, attributed that PR's author as an untrusted issue reporter and held the PR two seconds after it opened; the tracker then showed only 'hold +1 · Needs human decision'. - Gate rationale is closing-keyword and declared issue links only; a link that resolves to a PR is skipped; hive self-reports are trusted; the gate is skipped for hive-authored PRs (kept for contributor and shared-PAT PRs). - Stage-label pass records hold provenance (by/source/reason/since) from the reporter-trust notice and the newest hold label event; tracker pill reads 'Held by hive · reporter trust (issue #N by @x, contributor)' or 'Held by @login'; the decision popover asks release/keep with Release leading; the 085 comment names who set the hold and why. - The same pass releases a hive-set reporter-trust hold on a hive-authored PR and logs 'stage labels: releasing self-imposed reporter-trust hold'; operator holds are left alone. Fixes #15075 Signed-off-by: Andrew Anderson <andy@clubanderson.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@clubanderson is auto-promoted for contributor-lane merging on this PR: the last 5 merged PRs by this author in this hive's repositories have no revert or sentinel-alert evidence. CI, reviewer verdict, diff fences, soak, holds and branch protection still apply. |
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of
|
|
merged by Hive trusted-author auto-merge: author @clubanderson holds role owner and GitHub permission admin on repo; CI green at 5153ac1. |
|
Thank you for your contribution! Your PR has been merged. We'd love to hear how your experience was: share feedback |
Fixes #15075
What broke
#15020 (hive-authored,
author/hive+role/trusted, 65/65 green, approved) was held by the hive itself two seconds after opening via the #9665 reporter-trust hold, with metadata"Issue":15017,"Reporter":"Karibhou","Association":"CONTRIBUTOR". 15017 is a sibling PR, not an issue. The row then sat 49+ minutes atstage/085-needs-decisionas "hold +1 · Needs human decision" with no way to tell who held it or why.Root cause. 15020's body reads
Refs #15009 (closed by #15017, …); the gate fed the body to the bare-mention parser (ParseReferencedIssues), which yielded#15017, andIssues.Getreturned that PR as an issue object whose user (Karibhou, CONTRIBUTOR) was then treated as the issue reporter. The gate never checkedIsPullRequest()and never asked whether the PR's author was the hive itself.Changes
pkg/github/pr_reporter_trust.go): rationale = closing-keyword links (ParseClaimedIssues) + the request's declared issues; bare mentions are no longer consulted; a link resolving to a PR is skipped; a hive-filed issue ([selfreport], App/AI author) resolves as trusted.EvaluateReporterTrusttakes the PR author; App bot /project.ai_author/[bot]/ non-human authors skip the gate. Kept for contributor PRs and shared-PAT accounts.stagelabels.HoldProvenance(by,source,reason,since, issue/reporter/association) recorded on the stage store by the stage-label pass from thehive:reporter-trust-metadatanotice + newestholdlabel event; tracker payloadhold {…, pill}on items and nestedlinked_prs; pill reads Held by hive · reporter trust (issue 🐛 fix(fleetreport): treat the hive-held stage dwell warning as benign #15017 by @Karibhou, contributor) / Held by @login; decision popover asks Release the hold, or keep it? with Release hold leading (blocker_reason: hold:hive); the 085 comment names who set the hold and why.pkg/github/automerge/reporter_trust_release.go): on the stage-label pass, a hive-authored PR carrying a hive-set reporter-trust hold hashold(andneeds-humanwhen the gate owned it) removed, a<!-- hive:reporter-trust-release -->comment posted, andstage labels: releasing self-imposed reporter-trust holdlogged. Operator-set holds (human label actor) are left alone.labels-and-control-signals.md(hold / reporter-trust row, 085 row),dashboard-sections.md(hold pill + popover);changelog.d/fixed-reporter-trust-hold-hive-authored.md.Notes
Acceptance
After roll, the next stage-label pass releases 15020's
hold+needs-humanwith the release comment and log line, and the automerge lane merges it.