Skip to content

πŸ› Activity Monitor "Merged today" chip resets to 0 on reload β€” count lives only in the tabΒ #15147

Closed

Description

@clubanderson

What happened

On hive's own spoke (build dd412e4) the Activity Monitor's Merged today chip read 4; the operator refreshed the page and it read 0. On another reload it went 33 β†’ 4. The number is accumulated only in the tab β€” from rows vanishing as merged, seeded from the in-memory audit ring β€” so a reload, a new tab or a roll of the pod resets it. There is no server-side record of what merged, and a merged row leaves no trace once its 2.5 s pin ends (op-eyes G11/N8 in #15096).

From the CDP session on #15096 (comment 6481579497): the celebration did fire for #14945 / #15067 but the operator never saw it, because the chip sits in a non-sticky toolbar ~2,300 px above a scrolled viewport, and the row effect is a one-shot 2.5 s glow with sound off.

Expected

  1. A persistent merged ledger under /data (survives a roll, β‰₯30 days of entries, all-time total that only grows) recording {repo, number, title, url, merged_at, merged_by (hive | login), lane, issue} for every PR the hive tracked that reached merged β€” whoever merged it (audit pr_merged lines and webhook / closed-sweep snapshots), seeded from existing audit history and the PR throughput counter on first boot so the count does not restart at zero.
  2. GET /api/stage-tracker carries merged{today, total_7d, total_30d, all_time, recent[≀20], tz, day_start}; "today" rolls at midnight in the spoke's zone (UTC when none).
  3. The chip is renamed Merged: primary number = all-time, sub-text "N today Β· N this week", click opens a popover listing recent merges (number, title, who merged, when). It hydrates from the API on load, never goes backwards within a tab, and live merges reconcile to the server number.
  4. The Merged chip and the stage column header strip are sticky at the top of the tracker while scrolling.
  5. On a merge, besides the row glow, a persistent banner bottom-right ("βœ“ πŸ› fix: enable bulk delegation for multi-PR parent selectionsΒ #15067 merged β€” title (lane, by hive, 17:42)") stays until dismissed or 30 s, stacked when several, with Show row / Open on GitHub / All merges.
  6. The flight, in the operator's words: "an animation that originates from the item's row where the check mark is and flies up to the top of the browser border. If the Merged pill is visible, the animation stops there. If not, we just see it go off the screen. It can be a bee or a +1." β€” 🐝 by default, "+1" via hive.tracker.celebrate_glyph; reduced motion fades in place.
  7. βš™ β†’ Merges β†’ Test celebration closes the dialog first and plays on a row currently in the viewport.

Activity

  1. added a commit that references this issue on Oct 28, 2026
    e5c59ae
  2. added
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    on Oct 28, 2026
  3. added 7 commits that reference this issue on Oct 28, 2026
    3c80c21
    31b3ae9
    ada2ea4
    9bf01a2
    83ee708
    db75abb
    22c2f40
  4. added a commit that references this issue on Oct 29, 2026
    3399efe
  5. github-actions commented on Oct 29, 2026

    @github-actions
    Contributor

    @clubanderson this issue was closed by @hivecommons-hive[bot] as completed.

    If this was closed by a merged PR, the fix only takes effect once it ships in a tagged release and your deployment updates to it β€” check your running version against the fix before concluding the fix failed.

    If you are still seeing the problem, comment /reopen and it will be reopened for you β€” you do not need write access. Please add what you are still observing (running version, logs, steps) so it is not closed the same way again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions