Repository navigation
✨ Activity Monitor: live row feedback — confirm opt-out, result toasts, working cue, event line, merge celebration - #15014
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@clubanderson is auto-promoted for contributor-lane merging on this PR: the last 5 merged PRs by this author in this hive's repositories have no revert or sentinel-alert evidence. CI, reviewer verdict, diff fences, soak, holds and branch protection still apply. |
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of
|
|
@clubanderson this PR is held at Why:
Next: the hive does not push to your branch. Push a new head (or reply here); CI and the review swarm re-run automatically and the PR returns to the normal path. |
de2b9ac to
b008523
Compare
|
@clubanderson this PR is held at Why:
Next: the hive does not push to your branch. Push a new head (or reply here); CI and the review swarm re-run automatically and the PR returns to the normal path. |
…s, working cue, event line, merge celebration Every row action now goes through one SPA helper (runRowAction) that marks the row acting, posts the request and renders a persistent result toast from a shared result payload (action, target, outcome, next, rule, applied_at) that the decision, delegated-decision, accept-triage, hold, send-to-human and rescan endpoints all return additively. Each confirm dialog carries a "Don't ask again for this action" box persisted per action id (hive.tracker.confirm.<action>=skip) with one Reset confirmations button in ⚙; the sentinel ⚠ line travels into the toast so skipping never hides it. The lit chevron turns only while a hive agent is on the item (tooltip: Working now), a one-line event line says what just happened, and a merge pins the row while an amber hex token rises into a new "Merged today: N" counter (seeded from merged_24h; toggle Celebrate merges; reduced-motion and 🔇 honoured). Requested by @clubanderson. Signed-off-by: Andrew Anderson <andy@clubanderson.com>
…e fixtures over stdin Signed-off-by: Andrew Anderson <andy@clubanderson.com>
… cue tokens, popover test with runRowAction present) Signed-off-by: Andrew Anderson <andy@clubanderson.com>
b008523 to
1eb938d
Compare
|
merged by Hive trusted-author auto-merge: author @clubanderson holds role owner and GitHub permission admin on repo; CI green at 1eb938d. |
|
Thank you for your contribution! Your PR has been merged. We'd love to hear how your experience was: share feedback |
Fixes #15012. Requested by @clubanderson.
This is piece (b) of the Activity Monitor feedback work — siblings: #14995 (needs-human options from PR comments, piece a) and #14992 (decision badge / trail, piece c). Enterprise-calm, plain words, not a game theme.
What changes
Server (additive). New
pkg/dashboard/row_action_result.go:RowActionResult{action, target{repo,kind,number,url}, outcome, next, rule?, applied_at?}withaction ∈ adopted | approved | recommended | closed | directed | refused | held | released | rescanned | triage-accepted | needs-human | noop-already-applied. Returned asresultby the decision, delegated-decision (job payload), accept-triage, hold, send-to-human and rescan endpoints; existing fields untouched. The delegated path detects a repeat of the same rule and answersnoop-already-appliedwith the priorapplied_at. Tracker payload gainsmerged_24h(same detector asrecently_merged, 24 h window) to seed the counter after a reload.SPA (
static/index.html).runRowAction(action, row): one path for every context-menu / selection-bar action → marks the row (and nested PR sub-row) acting, posts, renders a persistent result toast (✕, link to target, stays until the target row's stage/caption/chips change; up to 5 stack; errors plain and sticky; legacy fallback whenresultis absent).hive.tracker.confirm.<action>=skip; ⚙ → Confirmations → Reset confirmations. The ⚠ sentinel line is per head and is carried into the toast, so skipping the dialog never hides it.tracker-cuesblock:cue-working(chevron icon turns only while an agent's currentlastActionis on this item; tooltip leads Working now: …),cue-acting(stripes + caption + spinner),cue-event(one-line event from the poll/SSE diff, 2-min life, fades),cue-setback(red lead),cue-merged. Shared colour tokens--cue-state/--cue-work/--cue-decisionon.ham-row, declared identically to ✨ Activity Monitor: needs-human popover says what to decide and offers the actions #14995 so either lands first.merged_24h). On merge: row pinned 2.5 s, ✓ cell glows, amber hex token flies ~520 ms to the chip, chip ticks +1 with a pop, zap on arrival (🔊 only), row exits. 200 ms stagger, max 3 flights, off-board merges still count, reduced motion = tick + glow, ⚙ → Merges → Celebrate merges (default on,hive.tracker.celebrate). ReusablecelebrateRow(rowEl, {kind:'merged'|'closed-by-merge'}).Docs
docs/dashboard-sections.md: new What a row tells you without a click, Result toasts, Confirmations and "Don't ask again", Merged today paragraphs + legend (working / waiting on X / set back by Y / merged); Let hive decide "How it runs" updated. Changelog fragment added.Cue → text table
Working now: scout commented · 2m ago — <stage words><stage> · Next move: humanApproving…/Hive is deciding…/Holding…/Releasing hold…/Closing…/Sending…/Accepting triage…/Re-evaluating…/Marking needs-human…Hive: moved to CI / Review · 12s ago·Hive: fell back to Claimed — a reviewer requested changes·Hive: waiting on a person·Hive: hold released·You: approved·Hive: merged #14947 · by hiveHive decided on acme/console#14938 → PR #14947: adopted (contributor offline)/Adopted … in supersede mode as #14977./The hive rebases and merges it unattended./Open PR #14947 ↗No change — hive already recorded this decision at 12:01Z; still blocked by needs-humanHold failed on acme/console#7 — write permission required⚠ Sentinel flagged security-relevant changes at 40a959b …Don't ask again for this actionReset confirmationsMerged today: 3(tooltip:#14947 · 12:04, …)Celebrate mergesThree cue types per row (pill, working/acting, decision badge from #14992); the event line and merge glow do not blink; all motion 150–520 ms;
prefers-reduced-motionstops every animation.Screenshots
I could not drive a browser from this environment, so no before/after captures are attached; the celebration and acting states are exercised by the renderer tests below and can be previewed on a running dashboard via ⚙ → Merges and any row action. Happy to add a GIF if someone with a browser session can capture one.
Tests
stage_tracker_cues_test.go(new): wiring, working/waiting/event-line node tests, celebration (pin ≥2.5 s then release, token flight, count tick, zap on arrival, 200 ms stagger, cap 3, muted, reduced motion, off-board merge counts, toggle off, closed-by-merge).stage_tracker_row_actions_test.go: runRowAction, acting indicator, result toasts (persist → dismiss on state change, stack, no-op, error), confirm skip → no dialog → toast carries ⚠, reset.TestDelegatedDecisionRepeatIsNoop, result assertions in delegated decision / hold / accept-triage tests.go test ./pkg/dashboard/webstatic,./pkg/dashboard -run 'StageTracker|Native|Style|HivePrompt|Ham').