Repository navigation
✨ Activity Monitor: needs-human popover says what to decide and offers the actions - #14995
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of
|
…s the actions
Hovering or focusing the 'Needs human decision' chevron word or a lead
needs-human / triage-needed pill opens an in-app popover: what the row
waits on (the reviewer's own question when the verdict record has one,
else the park reason in plain words, plus the blocker), the applicable
actions as buttons (Let hive decide first) down the row context menu's
code path, and who asked, when. GET /api/stage-tracker rows carry
decision_needed {question, asked_by, since, blocker, blocker_reason,
options[]} under the context menu's action ids; mirrored onto
linked_prs[].
Requested by @clubanderson.
Fixes #14994
Signed-off-by: Andrew Anderson <andy@clubanderson.com>
a048e0b to
375ffa1
Compare
|
@clubanderson is auto-promoted for contributor-lane merging on this PR: the last 5 merged PRs by this author in this hive's repositories have no revert or sentinel-alert evidence. CI, reviewer verdict, diff fences, soak, holds and branch protection still apply. |
Signed-off-by: Andrew Anderson <andy@clubanderson.com>
|
merged by Hive trusted-author auto-merge: author @clubanderson holds role owner and GitHub permission admin on repo; CI green at cf65b6b. |
|
Thank you for your contribution! Your PR has been merged. We'd love to hear how your experience was: share feedback |
Fixes #14994
Part (a) of the owner's three-cue plan for the Activity Monitor (b = in-flight chevron / toasts / live event line, c = ✓ decision trail, #14992).
Owner request (verbatim)
Before / after
Before — the chevron word only carries a native title with the stage name and reason slug:
After — hover or focus opens an in-app popover: the question → the blocker → the actions (Let hive decide first; disabled ones greyed with the reason) → who asked, when:
What changed
Payload —
GET /api/stage-trackerrows parked on a person (PR at Needs human decision or with theneeds-decisionmodifier, issue at Needs human direction or Needs triage, any row with theneeds-humanpill) carry:questionis the reviewer's own decision question when the verdict record (review-verdicts.json, matched by repo / number / head) has one — the same text the hive's Needs a decision comment prints after "reviewer question:". Otherwise a plain-words sentence for the park reason.options[].actionare the row context menu's own ids, so the popover, the menu and the (b) helperrunRowAction(action,row)share one vocabulary; the client intersects serverenabledwith the menu's ownstageTrackerRowActionsso a button is never offered the menu would refuse.blocker_reasonkeeps the raw token for machines; operator copy never shows it.linked_prs[]entry.UI —
button.ham-decision-triggerreplaces the native title on the chevron word / lead pill. Hover opens (250 ms leave grace, re-checks:hoveracross re-renders), click or focus pins; Esc (refocuses trigger), click-away, scroll and resize close.role=dialog,aria-label="Decision needed on repo#N". Positioned/clamped withstageTrackerMenuPosition. Buttons callrunRowActionwhen present, elsestageTrackerDoAction— so (b)'s toast and in-flight chevron apply unchanged. Tiny sharedtracker-cuestoken block (--cue-state,--cue-work,--cue-decision) for the three PRs to compose; no new blinking — the row still has at most the state pill, the work spin and the decision badge.Tests —
TestStageTrackerDecisionNeeded(reviewer question quoted;requires_humanfallback; sentinel; changes requested disables Approve; adoption stalled; unauthorized; held; issue 045; triage 015; needs-human pill; plain rows nil; jargon scan),TestStageTrackerVerdictLookup, node renderer tests for popover content/order/escaping, option narrowing, trigger attributes andrunRowActionvsstageTrackerDoActionwiring. Style ratchet, no-native-dialog and tooltip scanners pass.Docs —
dashboard-sections.md(popover + cue tokens),api-reference.md(decision_needed, citations script clean), changelog fragment.Strings (cue → text)
<reason>on<sha>. Accept it as is, give direction, or close it?<sha>. Give direction for a new commit, or close it?<sha>— needs a new commit. Approving cannot override that.<label>label.Plain-word slugs:
contributor-lane:workflow-path→ "it edits CI workflow files";tests-removed→ "it removes tests";no-reviewer→ "no reviewer is configured for this repo";reporter-trust-hold→ "the author's trust level is not yet known";human-merge-path→ "it touches files a person must merge";merge-refused:review→ "GitHub requires a review the hive cannot give";merge-refused:method→ "GitHub refused the hive's merge method".3-second pass — each string was read as a new maintainer: no stage codes, no slugs, no "lane/sentinel/clanker"; every button is one verb; the order is the same everywhere (waiting on → can do → who/when).
Follow-ups / coordination
runRowActionistypeof-guarded — when the (b) PR lands the popover picks it up without a change; thedecision_neededfields are additive beside ✨ Activity monitor: decision badge shows what you chose and what hive did next #14992'slast_operator_action.Requested by @clubanderson.