Skip to content

Activity Monitor: merge celebration never flies for a PR drawn inline on its issue row (only the counter ticks) #15059

Closed

Description

@clubanderson

Reported by @clubanderson (2026-10-28): "I have not seen the animation yet." — hive's hive on aa9b530 (includes #15014), Safari tab open all afternoon, Merged today went 8 → 10 while watching, yet no token flight and no ✓ glow.

Diagnosis (live, not guessed)

  • /api/stage-tracker from hive's hive: merging PRs appear in recently_merged / merged_24h with the same key shape as their open row (hivecommons/hive, numeric number); the PR item and its issue are dropped from items in the same payload. The detector fired: in the open tab _stageTrackerZapped held all 7 merges of the afternoon and _stageTrackerMergedToday grew — the count ticked through the no-row fallback.
  • Root cause: stageTrackerCelebrateRowKey finds a row only by data-ham-key (a PR's own row) or data-ham-sub-key (a sub-row, drawn only when an issue has ≥2 covering PRs). On hive's hive 19 of 22 open PRs are nested under their issue and drawn inline on the issue row with no sub-row — so the lookup returned '', stageTrackerCelebrateMerges took the "not on the board" branch and only popped the counter.
  • Verified in the operator's Chrome tab via CDP: celebrateRow(issueRow, …) on a real row flies the token correctly (Safari-relevant pieces — CSS custom-property keyframes, animationend, CSS.escape, matchMedia reduced-motion false, document.hidden false, hive.tracker.celebrate unset = on — all fine). With the patched resolver injected, every drawn PR resolves to its issue row.

Fix

  • Rows stamp the PR keys they draw: data-ham-prs="<prKey> …" (own key on a PR row; the covering PRs on an issue row). The resolver falls through data-ham-key → data-ham-sub-key → [data-ham-prs~=key] → the PR's host row remembered from the last payload (nested_under / linked_prs), for a merge that also closes its issue.
  • ⚙ → Merges → Test celebration: one flight from the first row to the counter (pop + zap, count unchanged, no event line) so the effect can be confirmed on demand; says why when it cannot fly.
  • Renderer test replaying the captured before/after payload shape over stdin: asserts the issue row is the celebrating row, is pinned, glows, carries the event line, a token flies and the count ticks on landing; host-memory path; the Test button (flies, pops, does not count, clears) and its no-row warning.

Activity

  1. added a commit that references this issue on Oct 28, 2026
    fc10aff
  2. github-actions commented on Oct 28, 2026

    @github-actions
    Contributor

    @clubanderson this issue was closed by @hivecommons-hive[bot] as completed.

    If this was closed by a merged PR, the fix only takes effect once it ships in a tagged release and your deployment updates to it — check your running version against the fix before concluding the fix failed.

    If you are still seeing the problem, comment /reopen and it will be reopened for you — you do not need write access. Please add what you are still observing (running version, logs, steps) so it is not closed the same way again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions