Skip to content

πŸ› dashboard: Needs human chip counts only human-gated rows; Refs-only PRs address, not cover, an issue - #15013

Merged
hivecommons-hive[bot] merged 2 commits into
v5from
fix/needs-human-chip-covers
Oct 28, 2026
Merged

hivecommons-hive[bot] merged 2 commits into
v5from
fix/needs-human-chip-covers

Conversation

@clubanderson

Copy link
Copy Markdown
Member

Fixes #15008

Seen on hive's own hosted spoke (2026-10-28 16:20Z) with the Needs human 18 chip active.

Bug 1 β€” "Needs human" chip counted rows nobody waits on

The chip was label-based (needs_human_labels = the Projects preset set), so needs-signal (#14976 at 040 "PR in progress") and hold (#7563/#14939 ready-for-auto-merge, #2364/#9699/#9701/#9735) rows matched.

  • One predicate, mirrored exactly: Go stageTrackerNeedsHuman ↔ JS stageTrackerItemNeedsHuman. Needs human = a person's action is the only thing that advances the row: stages 015, 045, 085, 090; 071/072 when author_kind == human; or a needs-human / needs-decision / unauthorized modifier. hold wins β†’ never Needs human. Not: stalled, blocked, handled regression, 040 covered, auto-mergeable.
  • New payload fields needs_human / on_hold totals and per-item needs_human / on_hold flags, from the same predicate.
  • New ⏸ On hold chip + filter (onHold); one-line tooltips on both chips; the dialog's covered-label list is gone. needs_human_labels stays in the payload for the Projects preset.
  • SPA diff is additive and confined to the label-facet helpers / chip html (other agents are editing row actions, popover, badge).

Note: 090 (ready-for-human-merge) and 072 (returned to a human contributor) are included beyond the owner's list β€” only a human can advance either.

Bug 2 β€” #14976 (shared-CI incident) at 040 "open PR covers it"

Root cause differs from the thesis. Live tracker history: 030 β†’ 040 at 12:16:38 ET, linked PR #14990 (scanner fix, body Refs #14976 (needs-human: …), no closing keyword). The relay pr_request_watcher β†’ clearInProgressForPR(prCoveredIssues(...)) covered the declared issue regardless of the explicit non-closing Refs; the sweep's Reference claim then stated the same reason. Deferral comments on #14939/#14974 were not the cause: no code path derives coverage from timeline cross-references, and ParseClaimedIssues/ParseReferencedIssues ignore "Deferred to shared-CI incident #N" (regression test).

Follow-up (not here): [shared-ci] incident issues are detected only by title prefix; no label/marker exists for a dedicated "incident" presentation.

Tests

go test ./pkg/dashboard ./pkg/github/... ./pkg/stageengine/... ./pkg/stagelabels/... green (node renderer tests included). New: TestStageTrackerNeedsHuman, TestPRCoveredIssues_DeclaredRefsIsPartialNotCovered, TestPRRequestWatcher_DeclaredRefsIssueIsAddressedNotCovered, partial cases in deriver/labels/backfill tests, rewritten needs-human node fixture.

Docs: dashboard-sections.md (filter chips), labels-and-control-signals.md (040 row), changelog.d/fixed-15008-*.md.

…Rs address, not cover, an issue

Bug 1: the Activity Monitor's Needs human chip was label-based
(needs_human_labels), so needs-signal / hold rows β€” a 040 'PR in progress'
issue, held auto-merge PRs β€” counted. One predicate (stageTrackerNeedsHuman
Go, stageTrackerItemNeedsHuman JS) now feeds the chip count, the filter and
new needs_human / on_hold payload fields; held rows get an On hold chip.

Bug 2: #14976 (shared-CI incident) showed 040 'open PR covers it' because
the relay covered the declared issue of #14990 despite its explicit
non-closing 'Refs'. Reference-only claims are carried as ClaimFact.Partial,
recorded via FactSink.AddressedBy, and read 'addresses part of it'. Bare
cross-references (incident deferral comments) never create coverage.

Fixes #15008

Signed-off-by: Andrew Anderson <andy@clubanderson.com>
@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Oct 28, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign clubanderson for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Oct 28, 2026
@github-actions

github-actions Bot commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

PR Title Relation Files
#15003 ✨ feature: show Activity Monitor operator decision trails CONFLICT src/pkg/dashboard/static/index.html
#15011 πŸ› Close superseded hive PRs automatically and re-stage adopted originals out of the merge gate same files src/docs/labels-and-control-signals.md
src/pkg/dashboard/static/index.html
src/pkg/stageengine/facts.go
#14987 ✨ review: gate PR reviews on an approval label (review.require_labels) same files src/docs/dashboard-sections.md
src/pkg/dashboard/static/index.html
#15014 ✨ Activity Monitor: live row feedback β€” confirm opt-out, result toasts, working cue, event line, merge celebration CONFLICT src/pkg/dashboard/static/index.html
#14992 ✨ Activity monitor: decision badge shows what you chose and what hive did next CONFLICT src/pkg/dashboard/label_facets.test.js
src/pkg/dashboard/stage_tracker.go
src/pkg/dashboard/static/index.html
#14807 ✨ dashboard: stream Job pod logs in the terminal pane for sandbox.runtime: job agents same files src/pkg/dashboard/static/index.html
#15016 ✨ Adoption: maintainer_policy adopt|ask|never (default adopt); 072 row says why and offers Adopt same files src/docs/dashboard-sections.md
src/docs/labels-and-control-signals.md
src/pkg/dashboard/stage_tracker.go
src/pkg/dashboard/static/index.html

@github-actions github-actions Bot added the conflicts-with-open-pr Open PR has a merge conflict with another open PR label Oct 28, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor

@clubanderson is auto-promoted for contributor-lane merging on this PR: the last 5 merged PRs by this author in this hive's repositories have no revert or sentinel-alert evidence. CI, reviewer verdict, diff fences, soak, holds and branch protection still apply.

1 similar comment
@hivecommons-hive

Copy link
Copy Markdown
Contributor

@clubanderson is auto-promoted for contributor-lane merging on this PR: the last 5 merged PRs by this author in this hive's repositories have no revert or sentinel-alert evidence. CI, reviewer verdict, diff fences, soak, holds and branch protection still apply.

@hivecommons-hive

Copy link
Copy Markdown
Contributor

@clubanderson this PR is held at stage/071-needs-author and the hive will not merge it yet.

Failing checks:

  • build-and-test

Next: the hive does not push to your branch. Push a new head (or reply here); CI and the review swarm re-run automatically and the PR returns to the normal path.

@hivecommons-hive hivecommons-hive Bot added stage/050-review-pending Review swarm requested; awaiting a verdict for the current head and removed stage/071-needs-author Human-authored PR: CI red, changes requested or conflicting; diagnosis posted, the author must act labels Oct 28, 2026
…n predicate

Refs #15008

Signed-off-by: Andrew Anderson <andy@clubanderson.com>
@hivecommons-hive hivecommons-hive Bot added stage/071-needs-author Human-authored PR: CI red, changes requested or conflicting; diagnosis posted, the author must act and removed stage/050-review-pending Review swarm requested; awaiting a verdict for the current head stage/071-needs-author Human-authored PR: CI red, changes requested or conflicting; diagnosis posted, the author must act labels Oct 28, 2026
@hivecommons-hive hivecommons-hive Bot added the stage/050-review-pending Review swarm requested; awaiting a verdict for the current head label Oct 28, 2026

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read the core Go changes against v5 and the callers; I did not find a correctness defect. Noting what I verified so a maintainer can skip it.

Bug 2 (partial vs. covered)

  • prCoveredIssues (src/pkg/github/issue_inprogress.go) now splits declared issues: a declared N that ParseReferencedIssues sees and closingIssueRefs does not β†’ partial; anything closing β†’ covered. Both parsers already restrict to the same repo (prclaims.go:545-580 keys on defaultRepo; pr_duplicate_guard.go:54 filters on owner/repo), so "Refs #N" and "Closes #N" in the same body resolve to covered, which is the right precedence. pr_request_watcher.go:680-682 wires both halves.
  • FactSink gains AddressedBy; the only two implementers in the tree (stageengine/facts_sink.go:158, stageenginetest/fake.go:207) are both updated in this PR, and there are no test-local sink implementations that would stop compiling.
  • issueStage (derive_issue.go) keeps 040 placement and only changes the reason string; nothing else in pkg/ keys on the literal "open PR covers it" besides humanizeStageReason, which this PR extends with ReasonIsPartialCover before the existing switch.
  • enrichCoveringPR only marks partial when the ledger claim's PRNumber equals the remembered PR β€” so a stale ledger entry for a different PR cannot flip the flag.

Bug 1 (Needs human chip)

  • stageTrackerNeedsHuman is hold-first, then mods, then stages, then 071/072 gated on authorKindHuman β€” matches the doc and the JS fixture cases in label_facets.test.js. All referenced mod/author constants exist at stage_tracker.go:481-516.

The PR body's narrative matches the diff; I found no claimed behaviour the code does not implement.

Not a defect, just flagging for whoever merges: the PR carries conflicts-with-open-pr and stage/071-needs-author, and most checks are still pending on head 65262a2, so this is waiting on a rebase/CI rather than on review.

β€” hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read the tree at head d333c3e (not just the diff). Looks correct to me; nothing I could verify as a defect.

What I checked

  • FactSink gains AddressedBy (src/pkg/stageengine/facts_sink.go:21). The only production implementer is *factSink (:174), and the test double in stageenginetest/fake.go is updated too β€” go build ./... on the head is clean, so no third implementer was missed.
  • prCoveredIssues (src/pkg/github/issue_inprogress.go:213-243): a declared issue goes to partial only when ParseReferencedIssues saw it and closingIssueRefs did not; a bare Refs #N in the body that was never declared lands in neither list, which matches the doc comment ("a bare mention … is not in the body's claims at all") and the earlier ParseReferencedIssues default-repo behaviour at prclaims.go:567-570. Closing refs still always win into covered.
  • enrichCoveringPR (stage_facts_sink.go:193-203) only marks partial when the ledger claim's PRNumber equals the PR the store remembers, so a stale ledger entry for a different PR cannot flip the caption. BackfillCoveredByLedger uses the same claim.Reference && !claim.Closing test, consistent with the IssueClaim field semantics at prclaims.go:195-217.
  • issueStage (derive_issue.go:153-166): claim is is.Claim from :134, so claim.Partial is nil-safe; the 040 placement is unchanged and only the reason string differs, as the body says.
  • Go stageTrackerNeedsHuman (stage_tracker.go:1736-1746) and JS stageTrackerItemNeedsHuman (static/index.html:15194-15201) agree: hold short-circuits first, then mods needs-human/needs-decision/unauthorized, then stages {15,45,85,90}, then {71,72} gated on author_kind == human. The numeric constants match stagelabels.go:263-277.

Notes, not findings

  • build-and-test was red on the previous run and is re-running as I write; I did not chase the earlier failure.
  • The PR carries conflicts-with-open-pr; static/index.html is also touched by the author's #15014/#15016. GitHub still reports it mergeable, so this is a sequencing note for whoever merges, not an objection.

β€” hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot added stage/060-reviewed Review swarm verdict approve; a gate is still pending (CI running, soak not started) and removed stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Oct 28, 2026
@hivecommons-hive
hivecommons-hive Bot merged commit 679f886 into v5 Oct 28, 2026
82 of 86 checks passed
@hivecommons-hive

Copy link
Copy Markdown
Contributor
Evidence bundle `#1501365262a2` sha256:edd5b5de5ba58d033df9aeec762997f460a3e9cffc87e15fcf03c65845cee2e6 β€” download from the dashboard or `hivectl review evidence #15013`.

@hivecommons-hive

Copy link
Copy Markdown
Contributor

merged by Hive trusted-author auto-merge: author @clubanderson holds role owner and GitHub permission admin on repo; CI green at 65262a2.

@kubestellar-prow
kubestellar-prow Bot deleted the fix/needs-human-chip-covers branch October 28, 2026 17:16
@github-actions

Copy link
Copy Markdown
Contributor

Thank you for your contribution! Your PR has been merged.

We'd love to hear how your experience was: share feedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author/human A person pushed this PR themselves conflicts-with-open-pr Open PR has a merge conflict with another open PR dco All commits are DCO signed-off dco-signoff: yes Indicates the PR's author has signed the DCO. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Activity Monitor: "Needs human" chip counts hold/040 rows; hive Refs-only PR stages the shared-CI incident issue at 040 "open PR covers it"

1 participant