Skip to content

dashboard: 'ready for human merge' cell never says why a human is needed #14658

Closed

Description

@clubanderson

Symptom

Tracker row rationguard#400 → PR rationguard#401 "ci(mutation): shard nightly Stryker…" (2026-10-27 18:17Z). The merge-gate cell reads just "Ready for human merge 👤". The owner asked: why is this waiting for a human to merge?

The actual reason: the PR changes .github/workflows/mutation.yml (plus .github/tests/*.cjs), and the hive has a hard fence — it never merges PRs touching .github/workflows/** (and the GitHub App lacks the workflows permission anyway). It is labelled stage/090-ready-for-human-merge, lgtm, approved by @clubanderson.

Same on hive#14568 (cell says "Awaiting human merge · approved by @clubanderson" — still no reason) and hive#14498.

Expected

Every stage/090 cell and its tooltip carries a short machine-derived reason, e.g.

  • Ready for human merge · workflow files — tooltip: "Changes .github/workflows/** — hive never merges workflow changes; click Merge on GitHub"
  • · branch protection — required reviewers / rulesets the App can't satisfy
  • · auto-merge off — repo auto_merge disabled / lane disabled
  • · untrusted author / · manual-merge policy / · unauthorized (ties to hive:unauthorized, ✨ feat: mark lanes unauthorized when the App lacks rights for the next step #14595)
  • fallback · policy with the routing reason string

The reason should also show in the row caption and wherever 090 rows are summarised.

Where

The lane reason is already recorded on the stage record (contributor-lane:workflow-path[:human-approved@login], untrusted-author-role, …): RouteHuman / humanEvidence know it; stage_tracker.go just never turns it into a reason word on the 090 cell.

Activity

  1. added
    kind/bugCategorizes issue or PR as related to a bug.
    dashboardDashboard UI and API issues
    on Oct 27, 2026
  2. added
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    on Oct 27, 2026
  3. added a commit that references this issue on Oct 27, 2026
    583b584
  4. hivecommons-hive commented on Oct 27, 2026

    @hivecommons-hive
    Contributor

    Thanks for filing this issue! To help us reproduce and investigate, could you please include the commit SHA of the build you're running?

    You can find it by running:

    git rev-parse --short HEAD
    

    Or check the bottom of the console UI for the version string.

    This issue will be on hold until a SHA is provided. Simply add a comment with the SHA and the hold will be automatically removed.

  5. added a commit that references this issue on Oct 27, 2026
    cc4cc16
  6. added
    hive/likely-doneHive verified that a merged PR references or claims this issue; pending confirmation
    on Oct 27, 2026
  7. hivecommons-hive commented on Oct 27, 2026

    @hivecommons-hive
    Contributor

    ✅ PR #14669 fully addresses all expected features:

    Implemented:

    • HumanMergeReason codes: workflow-files, tests-removed, manual-merge-policy, branch-protection, merge-method, auto-merge-off, untrusted-author, unauthorized, reviewer-deferred, fallback policy
    • HumanMergeReasonText: one-sentence tooltips for each reason
    • Cell text: 'Ready for human merge · workflow files' (src/pkg/dashboard/stage_tracker.go, stageTrackerHumanMergeReasonWords map)
    • Nested PR sub-rows: mirror HumanMergeReason + HumanMergeReasonText (lp.HumanMergeReason, lp.HumanMergeReasonText assignment)
    • Needs-attention headline: carries the same tail
    • Fallback: 'policy' with raw lane reason in tooltip

    All bullets from Expected section are met. The implementation correctly derives reasons from stage records and displays them in merge-gate cells.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    dashboardDashboard UI and API issueshelp wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.hive/likely-doneHive verified that a merged PR references or claims this issue; pending confirmationkind/bugCategorizes issue or PR as related to a bug.needs-sha

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions