Repository navigation
✨ dashboard: Agents tiles show minute countdown and 'up next' marker - #10576
hivecommons-hive[bot] wants to merge 2 commits into
Conversation
Signed-off-by: scanner <scanner@hive.kubestellar.io> Co-authored-by: clubanderson <407614+clubanderson@users.noreply.github.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Open PR overlap checkBase branch:
Conflicts are checked with every PR merged onto the current tip of
|
|
hive/awaiting-ci: CI pending — sweep will merge when green. 🐝 Hive Agent: — hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88 |
TestNavbarClockTicksLocallyAndFlagsStaleStatus runs tickNavbarClock in isolation under node; the new _agentTileTickAt reference threw a ReferenceError. Move the 30s throttle into agentCollapsedMaybeTickCountdowns and call it via an optional typeof guard. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: scanner <scanner@hive.kubestellar.io>
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Supersession sweep found that this PR's claimed issue is already closed by another merged PR.
this PR touches files the merged PR did not. A human should decide whether to close this PR. This comment is edited in place by the supersession sweep; it is not duplicated. |
✅ Escalation cleared — back in the automated laneCI is green on the current head — returning this PR to the automated lane. The |
There was a problem hiding this comment.
Two things I verified against the tree at v5 (42ceebb) that don't match the stated intent ("an 'up next' badge on the soonest tile"):
1. The badge lands on the first tile of the sort, which is not always the soonest-scheduled agent (src/pkg/dashboard/static/index.html, agentsCollapsedTilesHtml: agentCollapsedTileHtml(a, nowMs, i === 0)).
agentCollapsedSortKey (index.html:5605-5616) puts busy === 'working' agents in group 0, ahead of group 1 (finite next kick). So whenever any agent is currently working, the "up next" badge is drawn on the working tile (whose countdown reads now), not on the agent whose kick is actually next. When no agent has a finite next kick (all continuous/paused/disabled), the badge still appears on whichever tile sorted first. Suggest picking the first tile whose sort key is group === 1 and omitting the badge otherwise.
2. The tile's countdown and the sort disagree about which agents have a next kick.
The new tile code computes nextMs = agentCollapsedParseNextKick(a.nextKickIn || a.nextKick, nowMs), but the sort (and the previous label) go through agentCollapsedNextKickMs (index.html:5593-5596), which (a) returns null for paused/offByCadence/unscheduledInMode/noCadence/onDemand agents and (b) also reads nextKickAt. Consequence: a paused agent that still carries a nextKick string is sorted into group 3 but renders a live "in 4m" countdown (and keeps ticking via data-next-ms), while an agent that only exposes nextKickAt sorts into group 1 but renders —. Reusing agentCollapsedNextKickMs in the tile would make both consistent.
The 30s throttle, the data-next-ms tick path, and the test coverage for agentCollapsedCountdownText otherwise look fine to me. Routing: @clubanderson requested this one; both issues are small follow-up edits on the scanner branch. I have not changed anything.
— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88
Collapsed Agents tiles now show a per-agent minute countdown (in 4m / now / —) refreshed every 30s from the shared navbar tick without re-rendering the row, an 'up next' badge on the soonest tile, a compact ' · ' second line (login state only when not authenticated), and a full-details tooltip on the tile title.
Closes #10560
— hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88 requested_by=@clubanderson