Repository navigation
π dashboard: Overview and Governor actionable counts share one definition - #10572
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Changelog: this PR changes code but carries no changelog entry If it is user-visible β a feature, a fix an operator would notice, a This is a reminder, not a gate; it never blocks a merge. |
Generated by changelog-fragment-guard from the PR title (#5675). Edit the wording freely, or replace this file with the no-changelog label if the change is not user-visible. Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Signed-off-by: clubanderson <407614+clubanderson@users.noreply.github.com>
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of
|
Signed-off-by: Andy Anderson <andy@clubanderson.com>
|
Thank you for your contribution! Your PR has been merged. We'd love to hear how your experience was: share feedback |
Summary
/api/status.actionableNowwith{issues, prs, total}computed after the server applies the Overview band taxonomy.issues + prs == totalfor the same status snapshot.Closes #10561
Root cause and trace
EnumerateActionable: issues and PRs pass hold/exempt/draft filters intoIssues.ItemsandPRs.Items, held work goes toHold, and stale drafts are tracked separately (src/pkg/github/client.go:992-1085).buildReposthen exposed raw actionable issues and open PRs to the dashboard, but also appendedPRs.StaleDraftsintoopenPrsfor display (src/pkg/dashboard/status_builder.go:1869-1952).actionable.Issues.Count,actionable.PRs.Count,actionable.Hold.Total) before Overview band classification (src/cmd/hive/main.go:6477-6482), and the Governor widget displayedgov.issues/gov.prs.waiting,done,draft, andblockedbands from "Actionable now" (src/pkg/dashboard/static/index.html:12730-12745).Fix details
statusWithOverviewBandsnow classifies repo items once, then computesActionableNowfrom the same banded objects (src/pkg/dashboard/overview_status.go:30-122).data.actionableNow.issues/prs/total(src/pkg/dashboard/static/index.html:10693-10745).window._lastStatus.actionableNow.totalfor the all-repos scope and keeps the existing local calculation for filtered repo views (src/pkg/dashboard/static/index.html:12730-12745).src/docs/dashboard.md:191-197).Tests
TestActionableNowSplitEqualsTotalWithSuppressedItems10561for held/draft/waiting/done/blocked fixtures.TestOverviewAndGovernorBindSharedActionableNowField10561string-scan guard for the shared UI binding.AGENTS.md; onlygofmtwas run.