Repository navigation
🐛 fix: use needs-triage for reporter trust waits - #10586
Merged
Merged
Conversation
Switch the reporter-trust wait label to the conventional needs-triage default, record when Hive added it in the marker, and only clear it when that marker proves Hive owns it.\n\nCo-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: Andrew Anderson <andy@clubanderson.com>
Contributor
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of
|
Contributor
|
Thank you for your contribution! Your PR has been merged. We'd love to hear how your experience was: share feedback |
kubestellar-prow
Bot
added
the
dco-signoff: yes
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
kubestellar-prow
Bot
added
the
size/L
This was referenced Oct 5, 2026
Merged
hivecommons-hive Bot
pushed a commit
that referenced
this pull request
Oct 5, 2026
…coverage floor Hermetic unit tests (nil client, stub admitters, httptest server, no sleeps) for src/pkg/github/reporter_trust_wait.go so the v5 coverage gate for pkg/github clears its 89% floor again after #10586. Rebuilt cleanly on v5 by the reviewer: the prior branch state had merged unrelated feedback/dashboard work (already landed via #10617) that conflicted with v5 and tripped the webstatic style ratchet. Refs #10586 Closes #10592 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: adjudicator <adjudicator@hive.kubestellar.io>
hivecommons-hive Bot
added a commit
that referenced
this pull request
Oct 5, 2026
…coverage floor (#10594) Hermetic unit tests (nil client, stub admitters, httptest server, no sleeps) for src/pkg/github/reporter_trust_wait.go so the v5 coverage gate for pkg/github clears its 89% floor again after #10586. Rebuilt cleanly on v5 by the reviewer: the prior branch state had merged unrelated feedback/dashboard work (already landed via #10617) that conflicted with v5 and tripped the webstatic style ratchet. Refs #10586 Closes #10592 Signed-off-by: adjudicator <adjudicator@hive.kubestellar.io> Co-authored-by: adjudicator <adjudicator@hive.kubestellar.io> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: Andy Anderson <andy@clubanderson.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
hive/awaiting-triageto the conventionalneeds-triagedefaultissue_filter.reporter_trust.awaiting_label, where""disables the wait labeladded-label=needs-triagein the marker only when Hive added it, and only clear the label later when that exact marker is presentValidation
gofmt -w/gofmt -lon changed Go filesgit diff --checkgo test; CI is the verdictFollow-up to #10585 / #10537.