Repository navigation
Conversation
|
Thank you for this, it's a big step: nobody had slept a 7 Pro with the Some things need changing first:
Smaller:
Versions will move at merge (0.3.33 is also claimed elsewhere), after #555. |
|
Thanks for the review! I'll fix all of these. |
|
Thanks for the reply. Nothing has been pushed yet, so the five points from my last comment stand, and main has moved a good deal under this branch. Here is what the rebase needs, so it's one pass:
Still open from before: eight cycles or seven, some M6.4 cycles through The kernel side (#232) needs a rebase as well, and I'll test the two together on my 7 Pro once both are up to date: the screen state awake with calls and texts first, then the freezes, then the call half of M6.3. |
40165a6 to
d2cf621
Compare
…in for a local build The M6 series (derekross#556) was cherry-picked onto main c3cfd86, where 0.1.18-0.1.20 and 0.3.33-0.3.34 are already taken. Versions move again at merge. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Thanks for both reviews.
One question: on #232 rebased onto the current |
d2cf621 to
e08d92d
Compare
|
Thank you for this push, and for the care in it. Going through my list: the screen state and the sleep hook are behind CI is waiting for my approval. I ran the gate and all three packages' tests on a merge with main. Four things before this can go in:
Smaller: device-cheetah 0.1.52 was taken on main last night, so I'll set the next number when I merge, nothing for you to do. The sleep hook's 10 s hold is counted on a clock that stops during the freeze, so after a wake the modem can stay on "screen off" a few seconds with the panel lit; a line in the hook's header is enough. And the commit that says "On the 7 Pro (LTE, idle)" means your phone; I'll word the squash that way. Order: #555 first, then the NR fix on its own, then this one after linux-omarchy-mobile#232 is merged, so the switch never ships ahead of the kernel that makes it work. My run on my 7 Pro will be: the screen state awake with calls and texts while the screen is dark, then two freezes in one boot through |
e08d92d to
b9f5827
Compare
b9f5827 to
6047d54
Compare
6047d54 to
fe9349c
Compare
|
@ikegam, I ran #556's |
|
One observation for M6's userspace half, from running kernel #232 on a Pixel 9a today (the full result is on that pull request): with What the journal shows at each request, in the same 100 ms:
With the data service stopped there is no route through the bearer, nothing is sent, and the link was idle 5 or 6 s after "screen off". Nothing here is the 9a's alone, as far as I can see: the fallback route and NetworkManager's sleep handling are the same on the 7 Pro, and how often it bites depends on what is talking when the phone goes to sleep. Refusals did no harm in my runs, but a phone on Wi-Fi with anything chatty would rarely sleep with the modem up. Two ways I can see, both in
I can write and test either on the 9a against #232 if you want it; say which, or that you'd rather handle it in #556. |
|
I went ahead with A so there is something to look at and numbers to weigh: #750 (draft). On the 9a against kernel #232, with Wi-Fi connected and the data service running: 0 of 14 sleeps entered as on main, 20 of 20 with the route stepping aside and coming back only after Wi-Fi. Fold it in here or drop it as you see fit. |
fe9349c to
6eddef2
Compare
|
Rebased on today's main and took @W4HO-ham's #750 in as is (author kept), thanks! device-cheetah is 0.1.56 now, since #554 has 0.1.55. A/B on my 7 Pro (kernel #232 + 6.1/6.2 on
Ping 3/3 and IMS registered after every run, no One note for testers: today's sit puts |
|
This branch's What ran. The package built from this head merged with #697 (the 9a's daily phone packages are #697's build; the one conflict, in
So on the 9a the two halves of this pull request do what the 7 Pro showed: yesterday the same kernel needed "screen off" sent by hand and the route change to get from 0 of 14 to 299 of 300, and with this package it needs neither. Not covered here. A call or a text arriving with One small thing from the hook's comment, as you note there already: after a short sleep the modem can stay on "screen off" for the rest of the 10 s hold with the panel lit. I didn't see an effect of it in this run, the panel being dark throughout. |
… nothing by hand (2026-11-14) 30 of 30 requests entered with omarchy-mobile#556's phone-service package and follow_screen on: sitd told the modem the screen state itself, the sleep hook ran each time, and the route change that was derekross#750 is part of derekross#556 now.
|
The call and text test with Calls into a sleep: 4 of 4 woke the palmtop and rang. The sleeps had lasted 82 s, 3 min 41 s, 5 min 38 s and 6 min 17 s, each after "screen off" was told. Wake source Texts into a sleep: 2 of 2 woke it (the carrier's missed-call and voicemail notices, 8 s and 15 s into a sleep): "SMS stored and acknowledged" 0.06 and 0.08 s after the suspend exit. A text sent while a call was ringing was stored 11 s into the ring, and the call still ended normally. Awake, with the screen dark and "screen off" told: three calls rang and four texts were stored. Sleeps that were called off cost nothing. Six requests this morning didn't go through: three refused before the freeze with the link up, three ended in noirq by CPIF ( One call left a stale So on the 9a I'd call the condition in the config comment met for waking and ringing, with that one open point, which isn't this pull request's to fix. |
…m sleep, auto-sleep by default, the charging boot, power off at a critical battery (#730) * omamobile-device-cheetah 0.1.56: double tap wakes the phone from sleep With auto-sleep on, the phone really sleeps (suspend-to-idle) 30 s after the screen goes off, and then only the power key woke it: the touch driver turned its interrupt off for the whole sleep. linux-omarchy-mobile#248 makes the touchscreen wakeup capable, off by default; this udev rule turns it on for the 7 Pro's Synaptics S3908. On a kernel without #248 there is no power/wakeup attribute and the rule does nothing. Tested on the reference phone on 2026-11-13 with the rule's effect set by hand (echo enabled > power/wakeup) on a kernel with #248: asleep through omamobile-sleepd, a double tap woke it on the touchscreen's interrupt and lit the lock screen. 0.1.54 and 0.1.55 are claimed by open pull requests (#556, #554). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * omamobile-device-cheetah: auto-sleep on by default on the Pixel 7 Pro Ship /usr/share/omamobile/auto-sleep-default, which omamobile-shell 0.2.129's user setup reads (#737): suspend on this phone is verified (SUSPEND-PLAN, 2026-11-13), and with this package's touch-wake rule a double tap wakes it from sleep, so auto-sleep no longer costs double tap. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * device-cheetah 0.1.55: off-mode charging instead of starting the phone on its cable A 7 Pro powered off on its cable is started by the bootloader with androidboot.mode = "charger", where stock runs only a charging screen. We started the whole phone (2026-11-09: both boots after a power off on the cable read "charger"). omamobile-charger-mode-generator makes omamobile-charger.target the default of such a boot (early folder; /etc/omamobile/charger-mode-disable turns it off). The target starts no session, modem, Wi-Fi or AoC, and keeps SSH over USB as on a normal boot (usb-rescue, usb-mac, ufw). omamobile-charger-mode turns the panel off, restarts into the phone on Power held for a second, and powers off five seconds after the cable is out. Needs linux-omarchy-mobile#233: without it, power off restarts. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * NOTES: power off restarted the 7 Pro (the PMIC's WTSR), and the charger boot On a second 7 Pro, not the reference phone. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * omamobile-device-cheetah 0.1.55: power off at a critical battery upower's default critical action is a suspend; suspended at 2 % the phone runs flat asleep within about 20 minutes, a brown-out with the root file system mounted. Power off now works (linux-omarchy-mobile#233, in kernel-2026.11.13, on the development channel), and an off phone on a charger starts the dark charging boot (#554's charger target, carried in this pull request). So the drop-in of SUSPEND-PLAN 6.6: PowerOff at 3 %. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> Co-authored-by: Hiroyuki Ikegami <ikegam@mixallow.net>
…h [control] follow_screen The screen-state request (SET_SCREEN_STATE, then SET_IND_CMD_FILTER) was in the service but never sent, so the modem reported as for a lit screen all the time; each report wakes the AP and the link. With follow_screen = yes (off by default) sitd follows the panel's bl_power, never "off" during a call, and a systemd-sleep hook asks for "off" before a sleep. Without it sitd sends nothing new and the hook answers "not told". On a second 7 Pro (mine; LTE, idle): 47 indications in 60 s with the screen on, none with it off. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…only on the Pixel 7 Pro /etc/omamobile/modem-suspend-enable lifts the modem's sleep inhibitor for MODEM-PLAN M6, but only beside /usr/lib/omamobile-modem/suspend-runbook, a comment-only marker that only device-cheetah ships. The inhibitor unit is skipped only when both exist; the start script follows the same two files and says when the enable file is ignored. Without both, nothing changes. The link tests no longer read the machine's own enable file. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The plan, the runbook and the results so far, on a second Pixel 7 Pro. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…r a system sleep With the modem up and Wi-Fi connected, a system sleep was refused every time on the Pixel 9a: NetworkManager takes Wi-Fi down at logind's announcement, the bearer's metric-700 default route is then the only one, whatever was talking over Wi-Fi sends through the bearer at once, and the modem's link is up when the kernel looks (linux-omarchy-mobile#232's sleep guard). omamobile-sit-data now listens for logind's PrepareForSleep (a busctl monitor, no new dependency) and takes its default route away when a sleep is announced; the bearer's address stays. After the sleep the route waits for another default route to be back, or ten seconds without one: put back at once it carried a few seconds of traffic at every wake, and the answers ended the next sleeps early. A route that wasn't there (a silent bearer, roaming) is not brought back, and without busctl nothing changes.
…radio_on on this phone Asked in derekross#701's review: the plan says which boots each count covers, and the two journal lines from a boot of the merged option. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KgnCmDwY8r4r1jCa2SVYLN
2cbd403 to
fba9cd5
Compare
…gap named (#790) Auto-sleep is on by default on the development channel since 2026-11-14, double tap wakes the phone from sleep, standby is about 21 h, power off and the critical battery work. With the modem up the phone still stays awake until kernel #232 (with its analysis fix) and #556 land; both passed every step on the reference phone on 2026-11-14. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
|
Thank you. This is carried in #791 with your commits and authorship kept (cherry-picked onto today's main, version files resolved; a few renumbered at the top of #791), together with the change that turns sleep with the modem up on by default on the Pixel 7 Pro. Its tests pass. I'll close this one when #791 merges. |
…1.57, omamobile-shell 0.2.131: sleep with the modem up on by default on the 7 Pro (carries #555 and #556) (#791) * omamobile-modem 0.1.24, omamobile-shell 0.2.128: turn the modem on or off from the Mobile network page On the Pixel 7 Pro the modem stack starts at boot through device-cheetah's vendor wants link, so keeping it off meant `systemctl mask omamobile-modem-boot.target` over SSH. A phone whose modem drivers have loaded never sleeps (omamobile-modem-inhibit holds until the reboot) and runs warm, so the owner needs that switch on the phone. omamobile-modem-switch (pkexec, org.omamobile.modem.switch, the active local user without a password) masks the target for "off" and stops nothing in this boot: a stopped modem can't start again before a reboot, the sleep inhibitor stays anyway, and every modem power-off costs a UFS error-handler pass (MODEM-PLAN M2.6). "on" unmasks it and starts the stack only when this boot's modem never started. Its status reads without root; props.conf sits in a root-only folder, which counts as provisioned there. The switch exists only where the target is wanted at boot (`systemctl show -p WantedBy`, which sees vendor and /etc links) or masked. On the 9a, with its own modem start, and the 6 Pro, nothing wants it: status says "available": false, the page hides the switch, and "on" and "off" refuse, so the shell never starts a modem outside that phone's own starter. The Mobile network page shows the switch in its ready and off states, says when the change takes effect at the next restart, says the phone can't sleep only while the modem's sleep block is held (a start refused before any driver releases it), and offers "Restart now". Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * omamobile-shell: the Mobile network page with the modem off, from the 7 Pro test of #555 Found on the reference phone on 2026-11-13, testing #555's modem switch: - With the modem switched off for the boot, the only way to the page that turns it back on (the Mobile data tile's chevron) was hidden, and once shown it was greyed out with the tile. tile-state.sh now reports data_switch=off from omamobile-modem-switch, the tile says Modem off and keeps a working chevron (only in that case). - Right after switching it on, the page said the modem service isn't running and starts once the modem is set up; it now says it is starting until the phone service reports. - The heading was centred on the glyph and clipped when taller than it. - The page had no back arrow; it now has one, as the Wi-Fi and Bluetooth pages do, and Escape goes back to quick settings too. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * omamobile-modem-sit 0.3.37: tell the modem the screen state, only with [control] follow_screen The screen-state request (SET_SCREEN_STATE, then SET_IND_CMD_FILTER) was in the service but never sent, so the modem reported as for a lit screen all the time; each report wakes the AP and the link. With follow_screen = yes (off by default) sitd follows the panel's bl_power, never "off" during a call, and a systemd-sleep hook asks for "off" before a sleep. Without it sitd sends nothing new and the hook answers "not told". On a second 7 Pro (mine; LTE, idle): 47 indications in 60 s with the screen on, none with it off. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * omamobile-modem 0.1.25, device-cheetah 0.1.56: modem-suspend-enable, only on the Pixel 7 Pro /etc/omamobile/modem-suspend-enable lifts the modem's sleep inhibitor for MODEM-PLAN M6, but only beside /usr/lib/omamobile-modem/suspend-runbook, a comment-only marker that only device-cheetah ships. The inhibitor unit is skipped only when both exist; the start script follows the same two files and says when the enable file is ignored. Without both, nothing changes. The link tests no longer read the machine's own enable file. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * MODEM-PLAN: M6, suspend with the modem online The plan, the runbook and the results so far, on a second Pixel 7 Pro. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * omamobile-modem-sit 0.3.37: the cellular default route steps aside for a system sleep With the modem up and Wi-Fi connected, a system sleep was refused every time on the Pixel 9a: NetworkManager takes Wi-Fi down at logind's announcement, the bearer's metric-700 default route is then the only one, whatever was talking over Wi-Fi sends through the bearer at once, and the modem's link is up when the kernel looks (linux-omarchy-mobile#232's sleep guard). omamobile-sit-data now listens for logind's PrepareForSleep (a busctl monitor, no new dependency) and takes its default route away when a sleep is announced; the bearer's address stays. After the sleep the route waits for another default route to be back, or ten seconds without one: put back at once it carried a few seconds of traffic at every wake, and the answers ended the next sleeps early. A route that wasn't there (a silent bearer, roaming) is not brought back, and without busctl nothing changes. * MODEM-PLAN: which boots the NR counts cover, and the merged nr_after_radio_on on this phone Asked in #701's review: the plan says which boots each count covers, and the two journal lines from a boot of the merged option. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KgnCmDwY8r4r1jCa2SVYLN * omamobile-modem 0.1.26: one sleep policy for the inhibitor, with a kernel guard and an owner's opt-out Whether the phone may sleep with the modem up was two path conditions on omamobile-modem-inhibit.service and the same two files in the start script. It is now one script, omamobile-modem-sleep-policy, that both ask: the unit through ExecCondition= (inhibit: exit 0 holds the lock, 1 skips it) and the start script through check. Yes needs all of: - the device package's declaration, /usr/lib/omamobile-modem/suspend-verified (device-cheetah only, after MODEM-PLAN M6 passed on the reference 7 Pro on 2026-11-14), or the attended runbook's pair from before (the owner's modem-suspend-enable beside a device's suspend-runbook); - no /etc/omamobile/modem-suspend-disable, the owner's opt-out; - a running kernel whose modem link refuses a sleep early, from a PM_SUSPEND_PREPARE notifier, while the link is up (linux-omarchy-mobile#232, da171eae4cb7). Without it a sleep with the link up is refused only at noirq, and a run of those left mobile data dead until a reboot on 2026-11-13. The kernel adds no sysfs attribute or module parameter for it and development releases don't order, so the policy reads the running kernel's pcie-gs201-cp module file (modinfo -n; the start script hasn't loaded it yet) for the notifier's log line or its function name. kernel-2026.11.13's module has neither; the M6 test kernels' modules have both. Anything else, an error included, keeps the inhibitor. A policy that can't run skips the unit (systemd counts a failed exec as a skip), but the start script's call then fails too, it waits for a lock that never comes and loads no driver: the phone never sleeps with the modem up by accident. No other device ships the declaration, so the 9a and the 6 Pro keep the inhibitor. The tests run the policy for every combination and the start script with it (old kernel, opt-out, missing policy, the old pair), and the unit check in place of systemd-analyze condition. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * omamobile-modem-sit 0.3.40: a device may turn follow_screen on in its drop-in A device's modem-sit.conf.d file was read for [audio] only. sitd now also takes [control] follow_screen from it (and nothing else from [control]: the socket's group stays the owner's), so the Pixel 7 Pro can tell its modem the screen state by default now that MODEM-PLAN M6 passed there, with texts and calls arriving and waking the phone with the screen dark (2026-11-14). A value in /etc/omamobile/modem-sit.conf still wins, and without a device default it stays off. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * omamobile-device-cheetah 0.1.57: sleep with the modem up on by default (MODEM-PLAN M6) The maintainer approved it on 2026-11-14 ("approve modem sleep by default on the 7 Pro"), after the reference phone passed every step of M6: two sleeps, ten sleeps refused before the freeze with data busy and the ping unbroken, a text and a call each waking the phone, audio both ways. The package now ships /usr/lib/omamobile-modem/suspend-verified, the phone's declaration that omamobile-modem 0.1.26's sleep policy reads, in place of the runbook marker, and [control] follow_screen = yes in its modem-sit defaults. No file of the owner's is needed; the policy still keeps the inhibitor on a kernel without linux-omarchy-mobile#232's early refusal and where the owner has made /etc/omamobile/modem-suspend-disable. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * MODEM-PLAN, SUSPEND-PLAN, DEVICES: M6 done on the 7 Pro, on by default from kernel-2026.11.15 MODEM-PLAN section 7's status says M6 passed on the reference phone on 2026-11-14 and links SUSPEND-PLAN's record of it; 7.5 says what turns it on by default (the device's declaration, follow_screen, the sleep policy), the kernel guard and why it reads the module, the owner's opt-out, and the check after Updates. SUSPEND-PLAN's status line says the same. DEVICES' Suspend cell stays "partial", now saying the modem-up gap closes with kernel-2026.11.15 and these packages; it moves to "works" only after the release is checked on the phone. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * AGENTS: sleep with the modem up is on by default on the 7 Pro with kernel-2026.11.15 The maintainer approved it on 2026-11-14. The suspend-and-modem entry now says that on the Pixel 7 Pro with a kernel carrying linux-omarchy-mobile#232 and omamobile-modem 0.1.26 with device-cheetah 0.1.57 the phone sleeps with the modem up, that the sleep policy keeps the inhibitor on an older kernel, and that the owner can opt out. The rest of the entry, the 9a's rules among it, stands unchanged for every other phone, and going round a held inhibitor on a 7 Pro stays the maintainer's attended test. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * omamobile-shell 0.2.131: above main's 0.2.129 for #555's Mobile network page #555's page and the page fixes carried in this branch were numbered 0.2.128, which main has since passed (0.2.129), and 0.2.130 is taken by an open pull request. No code change here. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Hiroyuki Ikegami <ikegam@mixallow.net> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> Co-authored-by: W4HO <87742609+W4HO-ham@users.noreply.github.com>
…fault order A value that isn't yes or no (nr_after_radio_on = ja) stopped the start with "Not a boolean" after the attach settings were sent. Now it logs the value and sets the NR mode as by default, as [control] follow_screen does in derekross#556. Asked in derekross#701's review. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KgnCmDwY8r4r1jCa2SVYLN
What
The userspace half of suspend with the modem online on the Pixel 7 Pro (MODEM-PLAN section 7, M6). The kernel half is derekross/linux-omarchy-mobile#232. Rebased on main of 2026-11-15; versions 0.3.37 (after #701's 0.3.36), 0.1.25 (after #555's 0.1.24) and device-cheetah 0.1.56 (after #730's 0.1.55) can move at merge.
[control] follow_screen = yesinmodem-sit.conf. Without it sitd sends nothing new, the hook answers "not told", and the 9a's one "screen on" at start is sent as before (its comment now says so)./etc/omamobile/modem-suspend-enablelifts the modem's sleep inhibitor only beside/usr/lib/omamobile-modem/suspend-runbook, a comment-only marker that only device-cheetah ships. The inhibitor unit has two triggering conditions (ConditionPathExists=|!on each file), so it is skipped only when both exist. The start script follows the same two files. On the 9a or the 6 Pro, the owner's file alone changes nothing, and the script says it was ignored.Your review
Screen state on every phone: behind
follow_screen(default off), the hook included. Tests check that with the default no request is sent, and that the hook getsfollowing: false.Whose phone: 7.4 and both status lines say M6 ran on a second Pixel 7 Pro (mine) and what has run.
After the two runs that lost the modem: the phone was rebooted, with the unit's stop (
CP OFFLINE,modem-upremoved), and the modem was never restarted within a boot. "No UFS line" was read in that same boot's kernel log, which runs on past the stop (to 855 s and 1387 s), so the stop's CP power-off is covered.NV checks: 7.4 has a table per M6 boot. Every modem start's RAM copies were 5 of 5 against the backup's sums, and the NV files 3 of 3. One honest correction: no
tools/nv-backup --checkran at each boot. One ran on 2026-11-11 after all of them (NV partitions the same,devinfodifferent as expected). From M6.4 it runs before each boot.Tests for the inhibitor branch: start-harness cases for:
test/allalso evaluates the unit's conditions withsystemd-analyze conditionfor all four combinations. Inverting the script's check, or dropping the unit's second condition, fails the suite.Second review, (4), the enable file on other phones: the marker above, with a device-cheetah test that it is staged as a plain, comment-only file.
Smaller points:
PM: suspend entry/exitpairs and no failure; 7.4's earlier "seven" was one short and is corrected.systemctl suspendin M6.4: noted in 7.3/7.4. The earlier freezes went straight to/sys/power/state, so they skipped the hooks and inhibitors.Tested
Pixel 7 Pro (the second one), LTE SIM with data and SMS (no voice), on the charger:
7.3.0-rc6-omamobile-push1-g33179249011e(omamobile-omarchy 0.1.23: no launch toast for a desktop entry that runs omarchy-shell #232 on today'somamobile),omamobile-modem0.1.23,omamobile-modem-sit0.3.36 and device-cheetah with the marker. Over two boots:rmnet03/3;ConditionResult=no) and the start script went on.tools/pr-check origin/main, andtest/allofomamobile-modem,omamobile-modem-sit(sitd againsttools/sit-sim) andomamobile-device-cheetah, pass.Not run here: no sleep cycles on this kernel yet (M6.4, with
systemctl suspend), and the call half of M6.3 (needs your voice SIM).🤖 Generated with Claude Code