Repository navigation
omamobile-modem-sit 0.3.41: a mistyped nr_after_radio_on keeps the default order - #760
Conversation
…fault order A value that isn't yes or no (nr_after_radio_on = ja) stopped the start with "Not a boolean" after the attach settings were sent. Now it logs the value and sets the NR mode as by default, as [control] follow_screen does in derekross#556. Asked in derekross#701's review. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KgnCmDwY8r4r1jCa2SVYLN
9f937c0 to
99f48b9
Compare
|
Thank you, this is exactly the follow-up I hoped for from #701, and thanks for rebasing it onto 0.3.41 so quickly. I checked that a real One small wording point, not a blocker: the line also prints when When I squash it I'll keep your |
The follow-up from #701's review: a value that isn't yes or no (
nr_after_radio_on = ja) no longer stops the start after the attach settings were sent. sitd logs the value and sets the NR mode as by default, asfollow_screendoes in #556.jakeeps the default order and logs the line; it fails without the fix.test/allandtools/pr-checkpass. Not run on a phone (the path only changes for a mistyped value).🤖 Generated with Claude Code