Skip to content

omamobile-modem-sit 0.3.41: a mistyped nr_after_radio_on keeps the default order - #760

Merged
derekross merged 1 commit into
derekross:mainfrom
ikegam:omamobile-sit-nr-mistyped
Nov 15, 2026
Merged

derekross merged 1 commit into
derekross:mainfrom
ikegam:omamobile-sit-nr-mistyped

Conversation

@ikegam

@ikegam ikegam commented Nov 14, 2026 •

Copy link
Copy Markdown
Contributor

The follow-up from #701's review: a value that isn't yes or no (nr_after_radio_on = ja) no longer stops the start after the attach settings were sent. sitd logs the value and sets the NR mode as by default, as follow_screen does in #556.

🤖 Generated with Claude Code

…fault order

A value that isn't yes or no (nr_after_radio_on = ja) stopped the start
with "Not a boolean" after the attach settings were sent. Now it logs the
value and sets the NR mode as by default, as [control] follow_screen does
in derekross#556. Asked in derekross#701's review.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01KgnCmDwY8r4r1jCa2SVYLN
@ikegam
ikegam force-pushed the omamobile-sit-nr-mistyped branch from 9f937c0 to 99f48b9 Compare November 15, 2026 02:48
@ikegam ikegam changed the title omamobile-modem-sit 0.3.38: a mistyped nr_after_radio_on keeps the default order omamobile-modem-sit 0.3.41: a mistyped nr_after_radio_on keeps the default order Nov 15, 2026
@ikegam

ikegam commented Nov 15, 2026

Copy link
Copy Markdown
Contributor Author

Rebased on today's main, now 0.3.41 after #791's 0.3.40. And thanks for carrying #555 and #556 in #791, Derek.

@derekross

Copy link
Copy Markdown
Owner

Thank you, this is exactly the follow-up I hoped for from #701, and thanks for rebasing it onto 0.3.41 so quickly.

I checked that a real yes or no takes the same branch as before in every case (radio already on or not, NR on or off), and that only a value that isn't a boolean changes: it used to stop the start after the attach settings had gone out, and now it keeps today's order with a line in the journal. The new test fails on the old code and passes here, and the package's tests pass on top of today's main.

One small wording point, not a blocker: the line also prints when nr isn't off, where the NR mode isn't set at all, so "isn't yes or no; using no" would read right in every case. I'm happy to merge it as it is.

When I squash it I'll keep your Co-Authored-By: line and leave out the Claude-Session: link, since that points at a private session.

@derekross
derekross merged commit b0378f8 into derekross:main Nov 15, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants