Repository navigation
Conversation
|
Thank you for turning the issue into this so carefully: everything I asked for on #729 is here, the pending dial is kept out exactly as I hoped, and the two simulator modes make the case easy to follow. The phone logs for both the hung-up and the answered call are very clear. One thing needs changing, and it's small:
And a few smaller things:
Before merging I'll run an ordinary call on my Pixel 7 Pro with this branch, as I said on the issue. In that run I'd also like to see what the modem answers to Thanks again, this is a nasty failure (no calls or texts until a reboot) and the fix is well thought through. |
…e, sitd keeps running
A call to a number that forwards straight back to this phone rings here
while the outgoing call is still dialing. The outgoing call then ends
with cause 17, and the modem never mentions the incoming one again: it
refuses AIMS_ANSWER and AIMS_HANGUP with error 2 and GET_CURRENT_CALLS
lists no call. sitd kept the call as ringing-in, and 12 s after the
first refused request the hangup deadline expired and it stopped itself
("Call release was not confirmed"): no calls or SMS until a reboot
(derekross#729, a Pixel 9a, twice on 2026-11-13).
Before giving a call up as unconfirmed, sitd now asks the modem
(Service.reconcile): when a hang-up or an answer is refused, when the
hangup deadline expires, and at the service stop before
unconfirmed_release(). If GET_CURRENT_CALLS is empty, the calls it still
shows end here (terminated, reason error), the audio route is released
and sitd goes on. The dial action already relies on the same answer
before it dials.
A dial whose setup is still pending is left out: while self.pending is
set, or a live call has no modem ID yet, the modem is not asked and the
old path runs. The same deadline is armed when a dial times out, the
modem may not list a late dial yet, and ending it here would drop the
status of a call that then connects. A modem that still lists a call,
or doesn't answer the question, also stays with unconfirmed_release().
tools/sit-sim: --forwarded-back (a ring for a second call ID, the
dialled call ended with cause 17, an empty call list, answer and
hang-up refused with error 2) and --silent-dial (AIMS_DIAL never
answered, no call listed).
Tests: test_sim.py runs the forwarded call with a refused hang-up, a
refused answer and a service stop (sitd keeps running past the 12 s
deadline, the call ends, no radio-off; the stop exits 0), and the
pending dial, which still ends in the unconfirmed release without a
second GET_CURRENT_CALLS. test_service.py has the same cases as unit
tests, plus a modem that still lists a call and a call check that
fails. test/all (run on the Pixel 9a itself, aarch64): passes.
On a Pixel 9a (2026-11-14, 7.3.0-rc6-omamobile-push1-gcbb1a7eb0a78):
this head's lib/service.py over the installed 0.3.35 (the file is the
same in 0.3.35 and on main), then a reboot. An ordinary outgoing call,
hung up while it rang: AIMS_HANGUP error 0, as before. The forwarded
call, twice, the returning call hung up and then answered through
omamobile-mmd: error 2 each time, "the modem lists no call; 1 stale
call(s) ended here", the call terminated, the audio routes restored,
sitd still running 16 s later and the next dial accepted. Not run on a
phone: the service stop with a stale call and the pending dial (both
in the simulator only).
Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
…-off reconcile() caught ModemError, TimeoutError and OSError from GET_CURRENT_CALLS, but the transport also raises a plain RuntimeError (invalid SIT framing, a short SIT write, the unprocessed indication limit) and EOFError when the channel closes. Those left reconcile() before unconfirmed_release() ran: with a ringing call and an expired deadline, main raises UnconfirmedRelease after one radio-off, and the branch raised the RuntimeError with none. Any failure of the check now returns False, so the old path runs. A test with both errors; MODEM-CLIENT.md says that sitd asks the modem first. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
2705b25 to
40194ec
Compare
|
Thanks, you're right about the transport's own errors; I had only looked at what Rebased onto main (
On One thing I saw on the way and left alone, since it is the same on main: after the radio-off, |
L-776: a fallback helper is checked against every exception its transport raises (#754). L-777: a DMA master running vendor firmware with its IOMMU in bypass stays disabled behind an overlay until the IOMMU is described (kernel #250, the maintainer's decision of 2026-11-15). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Thank you, this is exactly what I asked for, and the extra test covering Thanks also for spotting the There's nothing more for you to change here. What's left is mine: the ordinary call on my Pixel 7 Pro, recording what the modem answers to On the version: another change to the same package (#817, the internet bearer set up again after the modem drops it) is likely to merge first as 0.3.42, so 0.3.43 on your branch is probably right as it stands. I'll set it at merge either way. The two changes merge cleanly, and the package's tests pass with both. |
What and why
Part of #729, as asked for there. A call to a number that forwards straight back to this phone rings here while the outgoing call is still dialing. The outgoing call ends with cause 17, and the modem never mentions the incoming one again: it refuses
AIMS_ANSWERandAIMS_HANGUPwith error 2 and lists no call. sitd kept the call asringing-in, and 12 s after the first refused request it stopped itself ("Call release was not confirmed"), so calls and SMS were gone until a reboot.sitd now asks the modem before it gives a call up as unconfirmed (
Service.reconcile). IfGET_CURRENT_CALLSis empty, the calls it still shows end here (terminated, reasonerror), the audio route is released and sitd goes on. It asks in four places:unconfirmed_release().The points from the issue:
The path. The change is in
packages/omamobile-modem-sit/lib/service.py.A pending dial is left out. While
self.pendingis set, or a live call has no modem ID yet, the modem isn't asked and the old path runs. A modem that still lists a call, or doesn't answer the question, also stays withunconfirmed_release().The stop path. The
finallyinmain()reconciles before itsunconfirmed_release().Tests.
tools/sit-simhas two new modes:--forwarded-back: a ring for a second call ID, the dialled call ended with cause 17, an empty call list, answer and hang-up refused with error 2.--silent-dial:AIMS_DIALis never answered and no call is listed.test_sim.pyruns the forwarded call with a refused hang-up, a refused answer and a service stop: sitd keeps running past the 12 s deadline, the call ends, there is no radio-off, and the stop exits 0. It also runs the pending dial, which still ends in the unconfirmed release without a secondGET_CURRENT_CALLS.test_service.pyhas the same cases as unit tests, plus a modem that still lists a call and a call check that fails.The version. It says 0.3.43 (rebased onto main at 0.3.41 on 2026-11-15; omamobile-modem-sit 0.3.42: a default route on a down link no longer keeps the cellular route away #759 says 0.3.42). Please set it as you need at merge.
Ending a
ringing-incall that has had no status for a while is not in here. I can do that as a separate change.Device and build
uname -r): 7.3.0-rc6-omamobile-push1-gcbb1a7eb0a78Checks (no phone needed)
tools/pr-check origin/mainpassestests/allpasses: not completely. I ran it on the phone itself (I have no other machine with the tree at hand today), and there it stops attests/boot-method("display-msm should log not stamping on empty tree"). That one fails the same way on unchanged main on the phone, so the tests after it didn't run. Of those I rantests/tools-help,tests/grep-q-pipesandtests/pr-checkby hand: they pass. CI will show the rest.tests/packagespasses for the package I touched:packages/omamobile-modem-sit/test/all, with the simulator (16 simulator tests, 30 intest_service.py)versionbumped, and the new version is in the commit subjectCo-Authored-By:orAssisted-by:trailer, never aSigned-off-by:On the phone
lib/service.pyover the installed file (sha256d3b87cd7d22d…, the same as in this branch), then rebooted.service.pyis identical in 0.3.35 and on main, so the service code that ran is this pull request's. The rest of the package is 0.3.35, so main'snr_after_radio_on(0.3.36, off by default) was not on the phone. It is not a package built from this head.AIMS_HANGUPerror 0, the call terminated, no call check. Pass.stage running, IMS registered, no live call, call audio not running. The dial that followed the first one was accepted.userdata, weakens the storage guard, or reads registers from userspace (AGENTS.md §1)The returning call hung up (sitd never logs numbers; nothing is cut out):
The returning call answered:
About the phone, so the report below reads right: it runs a local kernel build and local units for the modem (from #372 before it merged), and cpif's
keep_link_up=Ywith a helper that polls the modem once a second (the workaround described in #672). The smoke report was taken five minutes after the boot the tests ran in. Its package list shows 0.3.35-1 for the reason given above.tools/phone-smokereportphone-smoke: unknown
Kernel
7.3.0-rc6-omamobile-push1-gcbb1a7eb0a78, tools atunknown, 2026-11-14T06:20Z.Packages: hyprland 0.57.0-3.4, libcamera 0.7.2-4.23, mesa 1:26.2.4-1.4, omacam 0.3.3-1, omamessages 0.2.2-1, omamobile-apps 0.2.3-1, omamobile-audio 0.5.18-1, omamobile-device-tegu 0.2.18-1, omamobile-firstboot 0.1.5-1, omamobile-gnss 0.2.9-1, omamobile-keyring 20261026-1, omamobile-mirror 0.1.1-1, omamobile-mmd 0.1.4-1, omamobile-modem 0.1.21-1, omamobile-modem-sit 0.3.35-1, omamobile-omarchy 0.1.44-1, omamobile-owl-widgets 0.1.2-1, omamobile-sensors 0.2.1-1, omamobile-settings 0.1.2-1, omamobile-shell 0.2.127-1, omamobile-voice 0.1.0-1, omaphone 0.2.3-1, omarchy 4.5.0-3, omatel-agent 0.2.4-2, quickshell 0.3.2.r7.g2b4501a-1
🤖 Generated with Claude Code