Repository navigation
Conversation
MONOTONIC excludes suspend, so an expired request can accept a reply when execution resumes. Use BOOTTIME for SIT transport waits and check expiry again before interpreting a matching reply. Keep indications queued and do not replay a timed-out request. Socket regressions reproduce late success on the old implementation and pass with the fix. They model a BOOTTIME jump with MONOTONIC frozen, cover the deadline boundary and a scheduling pause after packet receipt, and retain indications without retransmission. The package's unit/RIL simulator and staged-install checks pass. This is offline preparation only: select still has a relative timeout, the modem sleep inhibitor remains, and no device was accessed. Document the remaining awake-device smoke and modem-on suspend qualification. Co-Authored-By: OpenAI Codex <noreply@openai.com>
|
Thank you for this, and for being so clear about what it is and isn't: no phone, the inhibitor untouched, no claim about modem-on suspend. The tests are careful work. I ran them here: both new tests fail on main's I don't want to merge it as it stands, though, because I'm not convinced either change makes the outcome better. Two questions:
Smaller things:
This package runs on my Pixel 7 Pro at every boot, so whatever remains gets a boot there with a call and an SMS before it merges; you don't need a phone for that part. |
What and why
SIT transport deadlines currently use MONOTONIC, which excludes suspend. A matching reply can also cross the deadline during a read or scheduling pause and still be accepted. This changes transport deadline accounting to BOOTTIME and checks expiry before interpreting a matching response.
The socket regressions reproduce the old behavior and pass with the fix. They hold MONOTONIC still while advancing BOOTTIME across real socket reads, cover the before/at/after deadline boundary, preserve indications, verify no transport retransmission, and reject both success and modem-error replies after a scheduling pause.
This is a narrow offline prerequisite for MODEM-PLAN M6/section 6.3, not an implementation or qualification of modem-on suspend. The sleep inhibitor is unchanged. Relative select waits do not become wake alarms or guarantee immediate expiry on resume without socket activity. A timeout does not cancel a modem operation or prove it did not execute.
Device and build
Checks (no phone needed)
tools/pr-check origin/mainpasses.tests/allpasses, with its environment-dependent skips.tests/packages omamobile-modem-sitpasses: unit tests, real RIL against sit-sim, staged layout/config/units.The repository-wide run skipped optional paths requiring lz4, Docker/Arch image, AOSP boot-image tools, dtc, repo-add, Unicorn/pyelftools, bsdtar, Node, and a built root image. The modified modem package's RIL simulator did run. Host dependencies binutils and build-essential were installed for the checks.
On the phone
tools/phone-smokereport.Hardware validation outstanding: no device smoke report is available. The code is ready for maintainer review; device qualification is not claimed. MODEM-CLIENT documents the verification boundary, stop conditions and rollback. CPIF/PCIe suspend, incoming call/SMS wake, IMS continuity and battery behavior remain untested. Do not bypass the inhibitor to test this patch.
tools/phone-smokereportNot run: no physical device accessed.