Repository navigation
Fix: Lay the page area out again whether or not the frame view's layout is recorded - #191
Merged
Merged
Conversation
…ut is recorded Whale records no frame view layout, so Rivet's relayout took the frame change path and the page area stayed where it was after the appbar showed again. The browser view's page area is now laid out first on every path. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Nov 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After #190, bar-folded passes on Chrome and Edge (.scratch\bar-rows-after3), and appbar-width, appbar-peek, split and sidebar pass on Chrome, Edge and Whale. Whale's bar-folded still fails. Its trace says "caption_layout: not in this build (frame view layout is not recorded for this build)", so
frame_layout::relayoutreturns false andrelayouttakes the SWP_FRAMECHANGED path, which #190 did not touch. The page area relayout now runs first on every path. The bar-folded row is the test.🤖 Generated with Claude Code