Skip to content

Fix: Lay the page area out again whether or not the frame view's layout is recorded #191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
b-re-w merged 1 commit into from
Nov 9, 2026
Merged

Fix: Lay the page area out again whether or not the frame view's layout is recorded #191

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions rivet/runtime/windows/src/frame.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2028,12 +2028,12 @@ unsafe fn sync_strip(window: HWND) {
unsafe fn relayout(window: HWND) {
// The frame view lays out again on request, which also works for a maximized window.
crate::features::vertical_tabs::invalidate_strip(window);
// The frame view lays its client view out again only when the client view's bounds change,
// and a new appbar width can leave them as they were while the page area must move. The
// browser view lays its page area out again here, whether or not the frame view's own layout
// is recorded, as on Brave and Whale the page otherwise waits for the next input.
crate::hooks::page_area::relayout(window);
if frame_layout::relayout(window) {
// The frame view lays its client view out again only when the client view's bounds
// change, and a new appbar width can leave them as they were while the page area must
// move. The browser view lays its page area out again here, as on Brave and Whale it
// otherwise waits for the next input.
crate::hooks::page_area::relayout(window);
if is_waiting(window) {
crate::trace::trace("attach: asked the frame view to lay out again");
}
Expand Down
Loading