Repository navigation
Fix: Lay the non-client view out with the frame view when the appbar changes width - #193
Merged
Merged
Conversation
…changes width The client view takes its bounds from the frame view only when the non-client view above both lays out. On Brave the page stayed under the appbar after it showed again, as only the frame view and the browser view were laid out. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Nov 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After #190 and #191, Brave's bar-folded still fails (.scratch\bar-rows-after3): after "appbar: hidden false" the page keeps the folded width 1424 even though the browser view laid out again.
views::NonClientView::Layoutis what gives the client view the frame view'sGetBoundsForClientView, andframe_layout::relayoutlaid out only the frame view.It now also lays out the frame view's parent. The parent is found through the recorded view parent offset (
chromium::view::parent_of), and only when that place is readable and holds an object whose table pointer lies in the browser module. Chrome, Edge and Samsung already passed; the bar-folded row is the test on all five.🤖 Generated with Claude Code