Repository navigation
Fix: Lay the non-client view out from the browser view when the appbar changes width - #194
Merged
Merged
Conversation
…r changes width Whale records no frame view layout, so the non-client view above its browser view was never laid out and the page stayed where it was after the appbar showed again. Rivet now finds it as the browser view's grandparent and lays it out first. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Whale's bar-folded still fails after #191 (.scratch\fold-whale-191). Whale has no recorded frame view layout, so #193's frame view parent is not available there.
hooks::page_area::relayoutnow lays out the browser view's grandparent first: client view, then non-client view, throughchromium::view::parent_of, which checks that the place is readable and the object's table lies in the module. Then it lays out the browser view as before. The bar-folded row is the test.🤖 Generated with Claude Code