Repository navigation
Fix: Resize a window once when a fold or show leaves its page panel where it was - #195
Merged
Merged
Conversation
…here it was Brave and Whale keep the client area they laid out until the window's size changes, so after the appbar folded or showed the page stayed where it was. When the relayout did not move the page panel, a window of its own size is shrunk by one pixel without drawing and put back at its exact rect, which lays it out at once, and the trace says so. The browser view and non-client view layouts tried before did not help and are taken out. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brave and Whale bar-folded still fail after #190, #191, #193 and #194 (.scratch\fold-194). After a show, the page stays at its folded width under the appbar.
toggle_appbarrecords the page panel's x before the toggle and afterrelayout. If the panel did not move, and the window is not minimized, maximized, snapped or fullscreen,nudge_sizemakes one size change: height minus one with SWP_NOREDRAW, then back to the exact rect, checked after. Each nudge is traced with the panel before and after.chromium::view::parent_of) are removed. They did not change the results.Test:
fr2_a_fold_resizes_the_window_only_when_its_panel_did_not_move. The bar-folded row runs on all five, three times.🤖 Generated with Claude Code