fix(supply-chain): retire unsafe Replit Zipkin bootstrap - #169
Draft
seonghobae wants to merge 6 commits into
Draft
fix(supply-chain): retire unsafe Replit Zipkin bootstrap#169seonghobae wants to merge 6 commits into
seonghobae wants to merge 6 commits into
Conversation
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Aug 9, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Advance #168 with a bounded supply-chain/operability repair from protected
develop@622e5e6c3d534f230c390f10e3832efadfc01825. The protected Replit configuration executed a tracked opaque rootzipkin.jar, piped mutablehttps://zipkin.io/quickstart.shinto a shell, and allowed overlapping service-start authorities.Status:
active_pr. This PR remains Draft; nothing here isimplemented_on_developuntil protected integration.Exact current identity
develop@622e5e6c3d534f230c390f10e3832efadfc01825;fix/replit-zipkin-bootstrap-supply-chain-622e5e6;50426b24de3c51a112f608fbdb8c3a86f4fc4a8d;9e7b280f1fcc6718f4252a3f725a204aaa587f6c;Every predecessor-head check/review/approval is historical after a head/base change.
TDD / RCA
RED 1 — unsafe bootstrap authority
Fail-first
45d9a5ac09c791ab4ac87ec24e659e86547b0815added onlyRepositoryRuntimeSupplyChainTest. Hosted CI failed on all three OS lanes specifically because.replitexecutedjava -jar zipkin.jarand used mutablecurl ... | bash; the test reached the repository runtime boundary rather than a fixture/setup error.GREEN 1
9c62b78853b847a9590503718e016decfe02d0c1removed Replit Zipkin JAR execution, mutable remote-shell bootstrap, obsolete Replit-only Zipkin publication, and changed the surviving service-start wait boundary to Eureka 8761.RED 2 / GREEN 2 — competing service starts
5333bbb12a21746a480cc89a86ffbdabe4b85064required the top-levelProjectrun button to delegate exactly one microservice topology,Run Microservices;71c3ea4813075905b796b59f73ee0cf46cf8513dremoved duplicate top-level service delegates.The first Windows run then exposed a test parser defect rather than a product defect: the parser searched an LF-only marker while checkout materialized CRLF. Exact current source head
50426b24de3c51a112f608fbdb8c3a86f4fc4a8dnormalizes CRLF/lone CR to LF only inside that structural test. It does not change product/runtime semantics.Current hosted evidence
For exact source head
50426b24de3c51a112f608fbdb8c3a86f4fc4a8d, every exposed aggregate workflow is now terminal-success:31337937439;31337937448;31337937434;31337937464;31337937440.This is not literal-source acceptance evidence: current protected PR workflows still execute GitHub's generated pull-request merge revision. Aggregate green cannot change the revision actually checked out. The shared JaCoCo defect also remains separately owned by #162/#164; a tree that can report
Analyzed bundle 'etl-service' with 0 classesis not accepted as 100% owned-production coverage evidence.No formal review or unresolved review thread exists on this unchanged head; CodeRabbit Draft-skip/status evidence is not a qualifying independent approval.
Bounded scope / remaining #168 work
This PR intentionally leaves
docker-compose.ymlto #167. The root trackedzipkin.jaralso remains for now because protectedREADME.mdstill documents an execution path involving that artifact while canonical docs PR #149 is concurrently owned by another writer. Deleting it here would knowingly race the documentation authority and break a documented path.Full #168 closure remains: remove the opaque tracked JAR once the canonical documentation/runtime lane is safe, reconcile supported startup/provenance guidance, and add a machine-checkable contract preventing opaque executable reintroduction. Do not invent a checksum/version, substitute another unpinned download, suppress scanner visibility, or add a fake collector.
Merge boundary
Keep Draft. Merge only after accepted source-identity controls, non-vacuous coverage, current security/dependency/SBOM/SAST evidence, zero valid unresolved findings, applicable qualifying independent non-author approval, and branch protection/rulesets all pass on the unchanged exact head. No old-head/base evidence transfers.