test(cdc): preserve zero Kafka retry semantics

[seonghobae]

Protected develop@f340d37caba9df0d4aeb88e5d18b78bd8cca4b60 already contains the core #250 fail-closed production fix: negative retry backoff and negative retry-attempt values are rejected before Spring FixedBackOff construction. This PR now carries only the remaining quality delta after a non-destructive refresh onto that live base.

Exact current state:

• head: 8703321886643edc5e20d85d6dad3157f531d5b1
• live base: develop@f340d37caba9df0d4aeb88e5d18b78bd8cca4b60
• merge ancestry: predecessor 97245cb9921b68a48410a8dfc8cc3c992abb57a7 + live protected base

Unique delta:

• regression coverage proving zero backoff and zero max-attempts remain valid explicit Spring semantics;
• beginner-readable public Javadocs for kafkaListenerContainerFactory(...) and its record-level acknowledgement/error-handler contract.

No duplicate production validation is reintroduced. Existing positive/default behavior, DLT routing, exception classification, listener concurrency and RECORD acknowledgement remain inherited from protected develop.

Fresh current-head workflow aggregates completed successfully for CI, Dependency Review, Generate SBOM, SAST, and Security. Those status aggregates are not substitutes for literal exact-head execution, complete non-vacuous owned-production coverage, complete dependency-vulnerability materialization, or a qualifying independent non-author formal APPROVED review. Historical predecessor evidence does not transfer.

[coderabbitai]

Warning

Review limit reached

@seonghobae, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 57 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 0ac9914c-dc7b-4e3b-a2e4-dde358c5a247

📥 Commits

Reviewing files that changed from the base of the PR and between f340d37 and 8703321.

📒 Files selected for processing (2)

• cdc-service/src/main/java/com/xtrmetl/cdc/config/KafkaConfig.java
• cdc-service/src/test/java/com/xtrmetl/cdc/config/KafkaConfigTest.java

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[seonghobae]

@coderabbitai review

Please review exact current source head 13d3bf6372abf8ae6cf214e3d5728aceaace2101. Treat predecessor-head results as stale. Focus on Kafka retry-setting validation semantics, zero-value compatibility, DLT/error-handler behavior, diagnostics safety, and test adequacy. This request does not constitute merge approval.

[coderabbitai]

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
set -euo pipefail

printf '%s\n' '== revision =='
git rev-parse HEAD
git status --short
printf '%s\n' '== diff summary from stated base =='
git diff --stat 942d164ceb7af497bb28a95f842db96429d1bdc4..13d3bf6372abf8ae6cf214e3d5728aceaace2101
printf '%s\n' '== changed paths =='
git diff --name-status 942d164ceb7af497bb28a95f842db96429d1bdc4..13d3bf6372abf8ae6cf214e3d5728aceaace2101
printf '%s\n' '== KafkaConfig candidates =='
fd -t f 'KafkaConfig(\.java|Test\.java)$' .
printf '%s\n' '== structural outlines =='
while IFS= read -r file; do
  printf '\n-- %s --\n' "$file"
  ast-grep outline "$file" --items all --type class,method
done < <(fd -t f 'KafkaConfig(\.java|Test\.java)$' .)
printf '%s\n' '== targeted diff =='
git diff --find-renames --find-copies --unified=80 \
  942d164ceb7af497bb28a95f842db96429d1bdc4..13d3bf6372abf8ae6cf214e3d5728aceaace2101 \
  -- $(fd -t f 'KafkaConfig(\.java|Test\.java)$' .)

Length of output: 1922

---

🏁 Script executed:

#!/bin/bash
set -euo pipefail

main_file="cdc-service/src/main/java/com/xtrmetl/cdc/config/KafkaConfig.java"
test_file="cdc-service/src/test/java/com/xtrmetl/cdc/config/KafkaConfigTest.java"

printf '%s\n' '== AST outlines =='
ast-grep outline "$main_file" --items all --type class,method
ast-grep outline "$test_file" --items all --type class,method

printf '%s\n' '== KafkaConfig.java =='
cat -n "$main_file"

printf '%s\n' '== KafkaConfigTest.java =='
cat -n "$test_file"

printf '%s\n' '== exact current diff =='
git diff --unified=100 942d164ceb7af497bb28a95f842db96429d1bdc4..HEAD -- \
  "$main_file" "$test_file"

printf '%s\n' '== retry setting declarations and uses =='
rg -n -C 4 --glob '*.java' --glob '*.yml' --glob '*.yaml' --glob '*.properties' \
  'xtrmetl\.replica\.kafka\.retry-(backoff-ms|max-attempts)|retryBackoff|retryMaxAttempts|FixedBackOff|kafkaListenerErrorHandler\s*\(' \
  .

Length of output: 52484

---

🏁 Script executed:

#!/bin/bash
set -euo pipefail

printf '%s\n' '== base relation and diff hygiene =='
git merge-base --is-ancestor 942d164ceb7af497bb28a95f842db96429d1bdc4 HEAD
printf 'merge-base: '
git merge-base 942d164ceb7af497bb28a95f842db96429d1bdc4 HEAD
git diff --check 942d164ceb7af497bb28a95f842db96429d1bdc4..HEAD

printf '%s\n' '== XtrmetlProperties Kafka declaration =='
sed -n '1,235p' cdc-service/src/main/java/com/xtrmetl/cdc/config/XtrmetlProperties.java

printf '%s\n' '== configuration resources that define the Kafka retry keys =='
rg -n -C 4 --glob '*.yml' --glob '*.yaml' --glob '*.properties' \
  'retry-backoff-ms|retry-max-attempts|xtrmetl:' cdc-service

printf '%s\n' '== retry-related test coverage outside KafkaConfigTest =='
rg -n -C 3 --glob '*Test.java' --glob '*IT.java' \
  'retry-backoff-ms|retry-max-attempts|retryBackoffMs|retryMaxAttempts' cdc-service

Length of output: 10158

---

@seonghobae Reviewed exact source head 13d3bf6372abf8ae6cf214e3d5728aceaace2101 against base 942d164ceb7af497bb28a95f842db96429d1bdc4.

I found no actionable issues in the requested scope.

• KafkaConfig.kafkaListenerErrorHandler(...) rejects both negative settings before it creates the DLT recoverer or FixedBackOff.
• Zero values remain valid. The test verifies interval 0 and max attempts 0.
• Valid-setting DLT routing, non-retryable exception classification, record acknowledgement, and common error-handler wiring remain unchanged.
• Failure messages name the configuration key and fixed constraint. They do not include the supplied deployment value.
• Focused tests cover each invalid setting and both zero-value semantics.
• git diff --check reported no whitespace errors.

I did not execute repository code or tests in this sandbox. This review does not approve the PR or change its Draft status.

⚠️ Action not completed

Review rate limited.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.