test(gateway): bind bootstrap API and public documentation - #224
Draft
seonghobae wants to merge 3 commits into
Draft
test(gateway): bind bootstrap API and public documentation#224seonghobae wants to merge 3 commits into
seonghobae wants to merge 3 commits into
Conversation
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Aug 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Advance #223 with a path-disjoint gateway quality slice from exact protected
develop@622e5e6c3d534f230c390f10e3832efadfc01825. ProtectedZuulGatewayApplicationhad the required Spring Boot/discovery bootstrap annotations and public entry point but no beginner-readable Javadoc and no focused bootstrap contract.This Draft deliberately does not overlap active gateway security PR #142: it changes only
ZuulGatewayApplicationand a focused bootstrap test. It does not change JWT/resource-server behavior, routing,application.yml,pom.xml, discovery destinations, identity configuration, or claim repository-wide coverage (#205).Exact current identity
develop@622e5e6c3d534f230c390f10e3832efadfc01825;quality/gateway-bootstrap-docs-tests-622e5e6;f37206616f009e856274f13e9f63f72270da1a63;75a540deb09a39c25d64168c5384639e938fb6b0;3bba9f8fc0c850461c54cba35c5a1edb4ae4ca7f;Every check/review from another source head/base is historical and does not transfer.
RED → GREEN
ZuulGatewayApplicationContractTestwas added before production changed. It preserves@SpringBootApplication,@EnableDiscoveryClient, and the public-staticmain(String[])entry point and requires beginner-readable class/method Javadoc.Hosted CI on fail-first head
f37206616f009e856274f13e9f63f72270da1a63reached the real gateway module after successful preceding production/test compilation. The structural annotation/main assertions passed and exactlypublicBootstrapApiHasBeginnerReadableJavadocfailed because protectedZuulGatewayApplication.javalacked the required public documentation. That is valid RED at the intended production/documentation boundary rather than setup/import/dependency failure.Exact current source head
75a540deb09a39c25d64168c5384639e938fb6b0applies the smallest correction proven by RED: Javadoc only. It explains that the class starts the standalone mightyETL gateway with service discovery during bootstrap and documentsmain(String[])plus its Spring Boot argument contract. Annotations andSpringApplication.run(...)behavior are unchanged.Current hosted evidence
All exposed workflow aggregates for the exact current source head are terminal-success:
31371785995: success on Ubuntu, macOS and Windows;31371785779: success;31371785729: success;31371785715: success;31371786135: aggregate success.CI macOS job
93402154438checked out GitHub synthetic merge3bba9f8fc0c850461c54cba35c5a1edb4ae4ca7f, not literal source head. On that integration tree the full reactor completedBUILD SUCCESS;ZuulGatewayApplicationContractTestpassed 3/3 and the gateway module passed 6/6. This is merged-tree structural/documentation evidence, not literal-source acceptance.Security Scan Trivy job
93402154770likewise checked out synthetic merge3bba9f8.... It printedDependency version cannot be determined. Child dependencies will not be found.before reporting zero CRITICAL/HIGH/MEDIUM findings, so #196 remains the scanner-completeness authority and the aggregate green is not accepted as complete same-revision Maven vulnerability evidence. The scan also still observes the tracked 82 MBzipkin.jar, owned by #168/#169.The same current CI log reproduces the inherited JaCoCo false-green:
Analyzed bundle 'etl-service' with 0 classesfollowed by coverage success. #162/#164 own selected ETL non-vacuity and #205 owns repository-wide owned-production coverage scope.Scope / merge boundary
Keep Draft. This branch fixes one real public bootstrap documentation/test gap but does not close #142 gateway authentication, #196 scanner completeness, #162/#164 non-vacuous selected coverage, #205 repository-wide coverage, #121/exact-source control dependencies, or independent protected review/merge governance. Merge only after the unchanged exact source head satisfies every live applicable gate; no predecessor-head, other-PR, incomplete-scanner, status-only, skipped-required or synthetic-only evidence transfers.