fix(cdc): keep invalid replica configuration out of diagnostics - #211
fix(cdc): keep invalid replica configuration out of diagnostics#211seonghobae wants to merge 6 commits into
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
📝 WalkthroughWalkthroughCDC 설정 및 검증 오류 메시지에서 원본 입력값과 원인 예외 노출을 제거했습니다. 관련 Javadoc과 민감한 값 및 제어 문자의 재출력을 검증하는 테스트를 추가했습니다. Changes진단 정보 비노출 강화
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related issues
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Current security evidence update for exact source
Therefore the aggregate green is not accepted as complete mightyETL vulnerability evidence under #196: source identity and dependency-graph completeness are independently non-passing. The PR remains Draft. CI, Dependency Review, SBOM and SAST are terminal-success compatibility evidence; protected JaCoCo also remains non-vacuous only after #162/#164/#205 or equivalent accepted integration. |
|
@coderabbitai review |
✅ Action performedReview finished.
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@cdc-service/src/test/java/com/xtrmetl/cdc/util/ValidationUtilsTest.java`:
- Around line 59-96: Extend
invalidConfigurationDiagnosticsDoNotRepublishRejectedValues with a port input
that passes the port-format validation but causes Integer.parseInt to throw,
then assert the resulting IllegalStateException has a null cause to cover
ValidationUtils port NumberFormatException handling. Update assertSafeDiagnostic
to explicitly assert that the diagnostic message contains neither
carriage-return nor newline characters, while retaining the existing key and
sensitive-fragment checks.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 0b57a3e1-b003-4a92-b0fe-99a51ddc1c94
📒 Files selected for processing (4)
cdc-service/src/main/java/com/xtrmetl/cdc/config/ReplicaJdbcTemplateConfig.javacdc-service/src/main/java/com/xtrmetl/cdc/util/ValidationUtils.javacdc-service/src/test/java/com/xtrmetl/cdc/config/ReplicaJdbcTemplateConfigTest.javacdc-service/src/test/java/com/xtrmetl/cdc/util/ValidationUtilsTest.java
1 participant
Superseded by #301
Closed as superseded after revalidating unique-work preservation against #301 exact current head
9eef90b09bb14a72ac63478dacaacae8222f2b51.The successor preserves this PR's complete four-file product boundary:
ValidationUtilskeeps the same fail-closed host/port/identifier diagnostics and the same no-cause overflow handling, with public Javadocs.ReplicaJdbcTemplateConfigkeeps invalid Hikari timeout values and parser causes out of diagnostics, with public Javadocs.ValidationUtilsTest.invalidConfigurationDiagnosticsDoNotRepublishRejectedValuesis preserved, including the all-digit oversized-port path, null cause, credential-like input, and explicit CR/LF/log-forging assertions that CodeRabbit required on this PR.ReplicaJdbcTemplateConfigTestin test(cdc): replay replica diagnostic confidentiality on live develop #301 now strengthens the timeout contract further: rejected values and authorization-like content are omitted, CR and LF are independently excluded, and direct failure cause is asserted null.No CI, security, review, approval, or synthetic-merge evidence from this stale branch transfers. #301 must satisfy all gates independently on its unchanged current head before merge.
Issue #210 remains the product owner for the capability until a successor is merged.