test(eureka): bind bootstrap API and public documentation - #206
Draft
seonghobae wants to merge 2 commits into
Draft
test(eureka): bind bootstrap API and public documentation#206seonghobae wants to merge 2 commits into
seonghobae wants to merge 2 commits into
Conversation
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Aug 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Close a path-disjoint quality/documentation gap on protected
develop@622e5e6c3d534f230c390f10e3832efadfc01825:eureka-serverhistorically had no tests in the hosted reactor and its publicEurekaServerApplicationbootstrap class/method had no beginner-readable Javadoc even though repository policy requires public production APIs to be documented.This Draft is intentionally bounded to the Eureka bootstrap surface. It does not implement service-registry authentication (#185), change port/network exposure (#180/#195), alter Eureka client identity, change Maven dependencies, or claim repository-wide coverage (#205).
Exact current identity
develop@622e5e6c3d534f230c390f10e3832efadfc01825;quality/eureka-bootstrap-docs-tests-622e5e6;b899c62712e6df9e81b4be80a2b1c619fba8c402;f96369312ffcb6ec0581bdfe463e2a9fb43ab395;b70f6207b2921ae9f30f6ff504963ed32b17cfe5;Every check/review from the RED head or another base is historical after the source movement.
RED — hosted production-boundary proof
Commit
b899c62712e6df9e81b4be80a2b1c619fba8c402added onlyEurekaServerApplicationContractTest. Two assertions preserve the real@SpringBootApplication/@EnableEurekaServerbootstrap and public-staticmainentry point; the third requires beginner-readable public Javadoc.CI run
31351668125, macOS job93343552628, checked out GitHub synthetic merge3f416a15ba22915b40150abcdd0262373efdd500(Merge b899c627... into 622e5e6...). The reactor compiled all preceding production/test modules successfully.eureka-serverthen compiled its new test and ran exactly 3 tests with exactly 1 failure and 0 errors/skips:EurekaServerApplicationContractTest.publicBootstrapApiHasBeginnerReadableJavadoc—expected: <true> but was: <false>.The annotation and entry-point assertions were green. This is valid RED at the intended Eureka public-documentation boundary rather than a setup/import/fixture/dependency failure. It is still synthetic-merge execution, not literal-source acceptance evidence.
GREEN candidate and hosted evidence
Exact current source head
f96369312ffcb6ec0581bdfe463e2a9fb43ab395applies the smallest correction proven by RED: it changes onlyEurekaServerApplication.javaJavadoc while preserving annotations andSpringApplication.run(...)behavior.The class now explains that it starts the standalone mightyETL Eureka service registry, distinguishes bootstrap ownership from the separate production authentication/service-identity decision in #185, and documents
main(String[])plus its Spring Boot argument contract. No security mechanism, credential, endpoint, dependency, port or lifecycle behavior is invented.All exposed workflow aggregates for this exact source head are now terminal-success:
31351787414: success on macOS, Ubuntu and Windows;31351787350: success;31351787356: success;31351787365: success;31351787334: success.CI macOS job
93343884562checked out synthetic mergeb70f6207b2921ae9f30f6ff504963ed32b17cfe5, not literal source head. The full reactor completedBUILD SUCCESS;eureka-serverran the new 3 tests with 0 failures/errors/skips. This is strong merged-tree structural/documentation evidence, not literal-source proof.Security Scan hard Trivy job
93343884375likewise scanned synthetic mergeb70f6207.... It printedDependency version cannot be determined. Child dependencies will not be found.before reporting 0 CRITICAL/HIGH/MEDIUM findings. Therefore the aggregate green is not accepted as complete Maven dependency-vulnerability evidence; #196 owns that scanner-completeness root cause. The same scan also still sees the tracked 82 MBzipkin.jar, whose retirement is separately owned by #168/#169.Current CI also reproduces the independent protected coverage defect: JaCoCo reports
Analyzed bundle 'etl-service' with 0 classesbefore passing. #162/#164 owns non-vacuity for that selected ETL bundle, and #205 owns repository-wide coverage-scope completeness.Shared acceptance boundaries
This branch fixes one concrete no-test/no-public-Javadoc gap but does not close:
Keep Draft. A passing three-test Eureka bootstrap contract is structural/documentation evidence; it is not a claim that the Eureka module has complete behavioral/security coverage or that the registry is production-secure. Any head/base movement invalidates the current check/review facts.