feat(zotero): add authenticated Zotero 10 transport - #17
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@coderabbitai review |
|
@codex review |
|
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
# Conflicts: # docs/TRD.md # docs/adr/0007-reviewed-zotero-write-plan.md # docs/product-technical-gap-baseline.md
Non-force two-parent restack onto current multilingual/write-execution parent. Preserve the Zotero 10 transport delta while inheriting the repaired Foundation CI contract and current receipt lineage. Signed-off-by: Seongho Bae <me@seonghobae.me>
# Conflicts: # docs/TRD.md # docs/product-technical-gap-baseline.md
|
Current-stack correction (2026-09-05): exact base |
# Conflicts: # docs/PRD.md
# Conflicts: # crates/conceptweave-zotero/src/lib.rs
…ty safety Preserve original transport and parent fixes. Resolve documentation by retaining transport contracts and replacing obsolete causal inference descriptions, without changing authentication or write authority.
Current source-scope and uncertain-write integration — 2026-09-06
Exact head
06d836a07fdb434683f88a31b45150a8a06f27f7normally retains prior transportc88f9a34c1fc4e72e38cf66b1d2f3fcb305e560aand parent84b27fb6b2563e0d4661905aa57702a0dde082ba. Original transport implementation is preserved while inheriting complete report/scope admission, required receipt binding and unknown-request semantics.Independent review requested executor+HTTP coverage:
97cce5a, strengthened by29a3771, composes synthetic authenticated transport with a failed POST followed by fully matching observed metadata. Exactly one POST, complete submitted request and observation, retained proposal digest, continued uncertainty and no applied/inverse operations are asserted. No real Zotero port/key or live mutation is used. Existing proxy and wire-contract tests are preserved.Local validation:123tests/19suites including3doctests; strictClippy,rustdoc,fmt,CI-contract,diff and unchangedcoverage gate.226/226functions,2022/2022normalizedregions,354/354normalizedbranches. RawLLVM2508/2560lines,3799/3880regions,314/354branches is not100%. Static review is not independent GitHub approval.
OPEN Draft behind existing stack. No hostedGREEN,protectedmerge,release,peer-authentication,live write/recovery or actual paper decisions claimed. PR18 then PR19 must inherit all scope/unknown-request fields without converting audit JSON to authority. Previous body below is historical; post-read completion/rollback inference is superseded.
Latest bounded-read integration checkpoint
Exact head
c88f9a34c1fc4e72e38cf66b1d2f3fcb305e560anormally merges parent044018cef4e5d3e919b278a1cfebe56857863601while retaining previous childcf93f5323d97e718c8ff986c8e780bfaa26fb765. Base remainsautoresearch/zotero-multilingual-abstention. The #9 whole-snapshot elapsed-time repair and its RED/GREEN evidence are inherited without reverse-merging later features or discarding predecessor deltas.This exact head passes Rust 1.98.0 locked workspace tests=100 suites=19, including doctests and excluding filtered subprocess duplicates, strict all-target Clippy, warnings-denied rustdoc, formatting, the existing CI contract and diff checks. Log:
/private/tmp/conceptweave-deadline-pr17-20260906.log. Intermediate coverage is not inferred from owner/final-endpoint coverage. No new dependency, actual paper read/decision, Zotero mutation or authority issuer was used.Draft and protected prerequisites remain. Local tests are not hosted GREEN, independent approval, merged/released source or evidence for another head. Earlier checkpoints below are retained history, not the current head.
Verified local approval-order repair — 2026-09-06 checkpoint
Exact head:
autoresearch/zotero10-authenticated-transport@cf93f5323d97e718c8ff986c8e780bfaa26fb765. Exact base:autoresearch/zotero-multilingual-abstention@873c46b7dcf2930a98cf7ef7ff8bdcbcf04f17d5.Original planner owner #13 preserves regression
505e111c993d8269e5b7b9e17a25a5ce20f8606eand repair8a684882005085d8b3cb47812e185975084e0475. Every existing local request/mode/item/metadata check finishes before the external approval verifier. Invalid requests invoke it zero times; valid complete requests invoke it exactly once. Local validation errors intentionally precede approval denial. Deterministic operations and complete before/after/rollback metadata are unchanged.This exact head passed locked Rust 1.98.0 workspace tests (97 tests / 19 unfiltered suites, doctests included), strict all-target Clippy, formatting, warnings-denied rustdoc, CI contract and diff checks before normal push. Normal parent integration retains both the prior child and verified parent as ancestors. Coverage from another stack head is not attributed to this head.
Keep Draft behind the existing prerequisite stack. This is local verification, not hosted current-head GREEN, independent approval, protected merge or release. No later full-text feature was reverse-merged into an earlier owner. Full-text-aware write admission, authentic decisions and independent authority remain separate gaps; no real Zotero/model request, label, approval or write was performed for this repair.
Earlier coordinates and status claims below are historical.
Prior PR description, retained without discarding evidence
Current source-integrity note — 2026-09-05
autoresearch/zotero10-authenticated-transport@d1e88ad309848cba9cb8028d2b5f04bcab067837.autoresearch/zotero-multilingual-abstention@61ff1e2653dc2adf9c770f3f474a6019d0e7640e.e7d4e59f1b55b5954c5f8436527bc96e7ef2fb13through ordinary merge ancestry. The source-snapshot digest binds complete captured raw provider JSON and the actual typed classifier inputs; source evidence and derived proposals retain separate identities.GoldenSetApproval.proposal_digestis required and binds the complete proposal records used for evaluation. The current proposal digest is checked before the caller-owned governance verifier. Do not backfill old receipts: regenerate evidence and obtain a new approval bound to the reviewed evidence.Earlier heads, runtime snapshots, campaign counts, and verification statements below are historical notes, not current acceptance evidence.
Historical PR notes — original text retained
Outcome
Add the ConceptWeave-owned Zotero 10+ Local API transport required by Issue #8 without claiming a live write. The adapter keeps the user-granted key private, pins the server partition, rejects redirects, bounds reads, and uses one-item POST so library and item versions are checked atomically. Stable reads distinguish library-wide and object versions; write responses must prove the exact key, advanced versions, collections and typed tags, while lost responses remain subject to the existing reconciliation receipt path.
Current exact stack — 2026-09-05
autoresearch/zotero-multilingual-abstention@d02d0f98ed5a2799a5735a6499b4f3eb66220611;47e86b5e4dc51b32d9f756db35cc7ca18ea8f2c2;Remaining boundary
The locally observed installation is Zotero 9.0.6. Approved live Zotero 10 write, partial-failure and rollback evidence remains incomplete; this PR contains no key and performs no live mutation during tests. #18 adds the explicit authorization/threat-model boundary and remains the dependent security gate.
Keep Draft behind #16 and the full predecessor stack. No descendant evidence may back-prove this exact transport head.