feat(zotero): retain private report-bound full-text evidence - #36
Draft
seonghobae wants to merge 35 commits into
Draft
feat(zotero): retain private report-bound full-text evidence#36seonghobae wants to merge 35 commits into
seonghobae wants to merge 35 commits into
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Integrate PR 34 at b0119a5 without rewriting either history. Preserve all inherited transport regressions and existing full-text and proxy tests. Keep the identical bounded reader once at its original metadata-owner location; no production behavior or coverage exclusion is removed. Verification: 186 workspace tests across 37 unfiltered suites, strict Clippy, fmt, rustdoc, CI contract and existing coverage gate pass. Source-normalized regions 3710/3710 and branch outcomes 674/674; functions 347/347. Raw LLVM totals are not 100%. Independent source review found no actionable merge finding; no hosted approval or protected merge is claimed.
Preserve the failed coverage checkpoint and its canonical deterministic regression, completed ordinary-merge ancestry, raw versus source-normalized coverage and pending central CodeQL handoffs. Classification and approval remain zero; local evidence is not protected acceptance.
# Conflicts: # crates/conceptweave-zotero/src/main.rs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Latest bounded-read integration checkpoint
Exact head
d3f991dcc1b746afed7c36f315e8937c39390c5enormally merges parentb9060df2cb1ea02314be429932031fc07de1de30while retaining previous child87f02a91a9b5ea83ae842ef6b7eb83141aebfd66. Base remainsautoresearch/zotero-reviewed-batch-patch. The #9 whole-snapshot elapsed-time repair and its RED/GREEN evidence are inherited without reverse-merging later features or discarding predecessor deltas.This exact head passes Rust 1.98.0 locked workspace tests=201 suites=38, including doctests and excluding filtered subprocess duplicates, strict all-target Clippy, warnings-denied rustdoc, formatting, the existing CI contract and diff checks. Log:
/private/tmp/conceptweave-deadline-pr36-20260906.log. Intermediate coverage is not inferred from owner/final-endpoint coverage. No new dependency, actual paper read/decision, Zotero mutation or authority issuer was used.Draft and protected prerequisites remain. Local tests are not hosted GREEN, independent approval, merged/released source or evidence for another head. Earlier checkpoints below are retained history, not the current head.
Verified local approval-order repair — 2026-09-06 checkpoint
Exact head:
codex/zotero-fulltext-capture@87f02a91a9b5ea83ae842ef6b7eb83141aebfd66. Exact base:autoresearch/zotero-reviewed-batch-patch@853517c1c43fdaeea0cef57b2f0e63a34b0fe2db.Original planner owner #13 preserves regression
505e111c993d8269e5b7b9e17a25a5ce20f8606eand repair8a684882005085d8b3cb47812e185975084e0475. Every existing local request/mode/item/metadata check finishes before the external approval verifier. Invalid requests invoke it zero times; valid complete requests invoke it exactly once. Local validation errors intentionally precede approval denial. Deterministic operations and complete before/after/rollback metadata are unchanged.This exact head passed locked Rust 1.98.0 workspace tests (198 tests / 38 unfiltered suites, doctests included), strict all-target Clippy, formatting, warnings-denied rustdoc, CI contract and diff checks before normal push. Normal parent integration retains both the prior child and verified parent as ancestors. Coverage from another stack head is not attributed to this head.
Keep Draft behind the existing prerequisite stack. This is local verification, not hosted current-head GREEN, independent approval, protected merge or release. No later full-text feature was reverse-merged into an earlier owner. Full-text-aware write admission, authentic decisions and independent authority remain separate gaps; no real Zotero/model request, label, approval or write was performed for this repair.
Earlier coordinates and status claims below are historical.
Prior PR description, retained without discarding evidence
Current repair checkpoint — 2026-09-05
Exact head:
6b33c071a6e1ded610fc9634db51f7a56ed90868. Named base:autoresearch/zotero-reviewed-batch-patchatb69f97792a5b3f48f627b50ede200c45eccf6050when checked.This ordinary merge retains old head
1e7d23c91116d84a455b6e6e5a6fb00a5e004c04and its repaired named parent as ancestors. It carries PR #29's earliest-owner static private-JSON diagnostic, inclusive 16 MiB pre-create metadata writer guard and regression tests, plus PR #28's fixture warning repair. Existing child functionality remains intact; full-text features were not reverse-merged into earlier owners.This exact head passed
cargo +1.98.0 test --locked --workspace(193 tests across 38 unfiltered suites, including doctests), strict Clippy across all targets, formatting, warnings-denied rustdoc, the CI contract check andgit diff --check. Nested filtered subprocess results are not counted twice. Coverage was not rerun at this particular new head; historical or later-child coverage is not transferred to it.Normal push preserves history and the existing Draft/prerequisite boundary. These are local results, not hosted current-head GREEN or independent protected approval. All required reviews/checks must be revalidated on the unchanged current head after prerequisites integrate. No force push, close, retarget, self-approval, dismissal, protected merge, new label, model request or Zotero write occurred. Authentic decisions and independently approved labels remain separately 0/3,715.
Preserved earlier description and historical checkpoints
Scope and dependency
Draft successor of #34, whose verified named head is b0119a5. Preserve every predecessor delta; this does not replace or close earlier PRs. Research Intake remains in ConceptWeave, with no new dependency, service, utility repository, provider bypass or Zotero mutation.
The capture command preserves exact attachment metadata, full-text JSON, observed status/version, original-report digests, the full bibliographic denominator and read interval in a new owner-only file. It re-enumerates from zero and checks bookends without claiming an atomic provider snapshot. Retained text does not modify proposals or renew approval.
Root-cause repairs
Live capture evidence
Release-build execution at 2c2226f made 6,950 read requests, retaining 3,473 manifest responses: 3,432 successful, 41 missing, five empty. Nonempty text is retained for 3,203/3,715 papers; 512 remain without demonstrated nonempty text. The new 0600 file is 235,602,798 bytes, and the original report hash is unchanged. No raw bibliography or text is committed. See capture evidence and its audit.
The earlier availability sweep's 800/1,000 abstract-missing subgroup is historical; it was not independently remeasured for the retained capture and is not transferred to that artifact.
Exact verification checkpoints
Research and remaining gates
The selected ontology-source audit is 15 of 76 repositories, with 61 source audits remaining. Four selected GitHub releases resolve to commits, including proprietary naruon; release existence is not adoption. Existing contextual-orchestrator release PR #1030 owns the missing immutable artifact/schema/deployed-gateway evidence. Catalog-sync deployment success is not a serving gateway, and no direct-provider substitute was used.
Independent review, prerequisite protected integration, current-head checks, released contextual-orchestrator adoption and authentic full-review approval remain outstanding. Actual decisions and approved labels remain 0/3,715. No self-approval, force push, admin bypass or protected merge is claimed.