Skip to content

feat(zotero): emit reversible write execution receipts - #15

Draft
seonghobae wants to merge 28 commits into
autoresearch/zotero-reviewed-write-planfrom
autoresearch/zotero-write-execution-receipt
Draft

feat(zotero): emit reversible write execution receipts#15
seonghobae wants to merge 28 commits into
autoresearch/zotero-reviewed-write-planfrom
autoresearch/zotero-write-execution-receipt

Conversation

@seonghobae

@seonghobae seonghobae commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Current source-integrity note — 2026-09-05

  • Exact head: autoresearch/zotero-write-execution-receipt@4ae166c501c83f6508011bcd31526815b69dd391.
  • Exact base: autoresearch/zotero-reviewed-write-plan@e35f42e2a552ba8da26250bf084462a36d1c986d.
  • This head inherits PR feat(research): add steward golden-set evaluation #10 root e7d4e59f1b55b5954c5f8436527bc96e7ef2fb13 through ordinary merge ancestry. The source-snapshot digest binds complete captured raw provider JSON and the actual typed classifier inputs; source evidence and derived proposals retain separate identities.
  • GoldenSetApproval.proposal_digest is required and binds the complete proposal records used for evaluation. The current proposal digest is checked before the caller-owned governance verifier. Do not backfill old receipts: regenerate evidence and obtain a new approval bound to the reviewed evidence.
  • Keep Draft. This note does not claim current exact-head hosted GREEN, independent approval, protected merge, live Zotero mutation, or governed publication. Root, predecessor, and terminal-stack local test evidence is not transferred as per-PR hosted evidence.

Earlier heads, runtime snapshots, campaign counts, and verification statements below are historical notes, not current acceptance evidence.

Historical PR notes — original text retained

Outcome

Provide the deterministic Zotero write-execution receipt boundary without claiming a live mutation. Complete reviewed-plan preflight precedes the first write; identity and full collection/tag state are verified around adapter calls; secret-free applied/failed/untouched evidence and reverse rollback operations are retained.

Current exact stack — 2026-09-05

Repaired receipt invariants

ClassificationWriteReceipt is bound to review, authority, server, Zotero version, library version, rule revision and snapshot digest across DryRun, Applied, PreflightFailure and PartialFailure. DryRun performs no adapter calls and enumerates every plan operation as not attempted. Confirmed unexpected mutation retains inverse evidence only when server/item identity remains proven; identity drift does not fabricate rollback evidence. Execution-critical plan fields remain private with read-only accessors.

Credentials remain outside serializable plans/receipts. Writes replace only complete reviewed collection/tag state for top-level items; complete preflight precedes mutation, later failure stops subsequent writes, and rollback operations remain reverse ordered.

Merge gate

Keep Draft behind #13 and the complete Foundation/Zotero prerequisite stack. Require one unchanged exact head with terminal Product/security/SAST/dependency/review evidence before integration. No self-approval, admin bypass, force-push, destructive rebase, predecessor-evidence transfer, or live mutation claim.

Refs #8.

@coderabbitai

coderabbitai Bot commented Sep 4, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@seonghobae

Copy link
Copy Markdown
Contributor Author

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 4, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-04T15:09:13.726700Z 585f383 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@seonghobae

Copy link
Copy Markdown
Contributor Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

@seonghobae

Copy link
Copy Markdown
Contributor Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Sep 4, 2026

Copy link
Copy Markdown
⚠️ Action not completed

Review rate limited.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 585f383bfc

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread crates/conceptweave-zotero/src/lib.rs Outdated
Comment thread crates/conceptweave-zotero/src/lib.rs
Comment thread crates/conceptweave-zotero/src/lib.rs Outdated
Comment thread crates/conceptweave-zotero/src/lib.rs
@seonghobae

Copy link
Copy Markdown
Contributor Author

@coderabbitai review

@seonghobae

Copy link
Copy Markdown
Contributor Author

@codex review

@coderabbitai

coderabbitai Bot commented Sep 4, 2026

Copy link
Copy Markdown
❌ Action failed

Review failed.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

@seonghobae

Copy link
Copy Markdown
Contributor Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

@seonghobae
seonghobae marked this pull request as draft September 4, 2026 15:28
seonghobae added a commit that referenced this pull request Sep 4, 2026
Non-force restack PR #16 onto PR #15 current head while preserving multilingual abstention tests. This adds only the three current receipt/execution RED contracts from #15; no production repair or predecessor GREEN is claimed.
seonghobae added a commit that referenced this pull request Sep 4, 2026
Non-force restack PR #17 onto PR #16 current head. Preserve the authenticated transport delta while carrying PR #15's current receipt/execution RED contracts through the prerequisite chain; no production repair or predecessor GREEN is claimed.
seonghobae added a commit that referenced this pull request Sep 4, 2026
Non-force restack PR #18 onto PR #17 current head. Preserve authorization, threat-model, SECURITY, TRD and bibliography repairs while carrying PR #15's current receipt/execution RED contracts through ancestry; no predecessor GREEN is claimed.
seonghobae added a commit that referenced this pull request Sep 4, 2026
Non-force restack PR #20 onto PR #19 current head. Preserve rollback semantics while carrying PR #15's current receipt/execution RED contracts and inherited transport-security boundary through ancestry; no predecessor GREEN is claimed.
Non-force two-parent restack onto current reviewed write-plan parent. Preserve the receipt/execution repairs while inheriting the repaired Foundation CI contract through the dependency chain.

Signed-off-by: Seongho Bae <me@seonghobae.me>

Copy link
Copy Markdown
Contributor Author

Current-stack correction (2026-09-05): exact base #13 8271d741b5027c65831a2e89d23f6bcd880d30b3; exact head 017c02f217fa2cb1c0e6a98c0dc910137851bd01. Non-force restack preserves the receipt-binding/DryRun/conditional-inverse repairs. Older body coordinates are historical; exact-head evidence remains independent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant