feat(zotero): export bounded steward review batches - #33
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@coderabbitai full review |
|
|
@coderabbitai full review |
|
seonghobae
left a comment
There was a problem hiding this comment.
Current-head review at 03dafd3cb47fa0568dd9fa0ac8f7b565c3b07d0b found no new actionable semantic/security defect in the bounded review-batch slice. The implementation validates the worksheet against the canonical report before selecting pending rows, preserves canonical decision order, binds library/rule/snapshot/item revision coordinates, keeps the batch non-reserving, and reuses the repaired owner-only private-artifact boundary inherited from #30. The completed batch remains only patch-shaped local input; it does not create approval or publication authority. Exact-head hosted check-runs are currently absent, so the local test/coverage evidence in the PR body is not treated as protected GREEN and Draft status remains appropriate.
|
@coderabbitai full review |
Rate Limit Exceeded
|
|
@coderabbitai full review |
|
|
Current-stack correction (2026-09-05): exact base |
Signed-off-by: Seongho Bae <me@seonghobae.me>
Signed-off-by: Seongho Bae <me@seonghobae.me>
|
Live authority correction (2026-09-05): GitHub's current PR fields are |
Verified local approval-order repair — 2026-09-06 checkpoint
Exact head:
autoresearch/zotero-steward-review-batch@18932783aeb336a6d58e8a19f6d7dd6ecfb9ab3a. Exact base:autoresearch/zotero-review-decision-cli@f0bf02a8a600924d254adfa7b4796aa2ef868165.Original planner owner #13 preserves regression
505e111c993d8269e5b7b9e17a25a5ce20f8606eand repair8a684882005085d8b3cb47812e185975084e0475. Every existing local request/mode/item/metadata check finishes before the external approval verifier. Invalid requests invoke it zero times; valid complete requests invoke it exactly once. Local validation errors intentionally precede approval denial. Deterministic operations and complete before/after/rollback metadata are unchanged.This exact head passed locked Rust 1.98.0 workspace tests (163 tests / 36 unfiltered suites, doctests included), strict all-target Clippy, formatting, warnings-denied rustdoc, CI contract and diff checks before normal push. Normal parent integration retains both the prior child and verified parent as ancestors. Coverage from another stack head is not attributed to this head.
Keep Draft behind the existing prerequisite stack. This is local verification, not hosted current-head GREEN, independent approval, protected merge or release. No later full-text feature was reverse-merged into an earlier owner. Full-text-aware write admission, authentic decisions and independent authority remain separate gaps; no real Zotero/model request, label, approval or write was performed for this repair.
Earlier coordinates and status claims below are historical.
Prior PR description, retained without discarding evidence
Current repair checkpoint — 2026-09-05
Exact head:
e6a94178c929b47a23a2ef3d5b00afba5a997363. Named base:autoresearch/zotero-review-decision-cliatbd7669d28abfd3476106362b790198f6dd9d2e2cwhen checked.This ordinary merge retains old head
ecddb799d1dc968e26614c735c9c345cba1182eeand its repaired named parent as ancestors. It carries PR #29's earliest-owner static private-JSON diagnostic, inclusive 16 MiB pre-create metadata writer guard and regression tests, plus PR #28's fixture warning repair. Existing child functionality remains intact; full-text features were not reverse-merged into earlier owners.This exact head passed
cargo +1.98.0 test --locked --workspace(158 tests across 36 unfiltered suites, including doctests), strict Clippy across all targets, formatting, warnings-denied rustdoc, the CI contract check andgit diff --check. Nested filtered subprocess results are not counted twice. Coverage was not rerun at this particular new head; historical or later-child coverage is not transferred to it.Normal push preserves history and the existing Draft/prerequisite boundary. These are local results, not hosted current-head GREEN or independent protected approval. All required reviews/checks must be revalidated on the unchanged current head after prerequisites integrate. No force push, close, retarget, self-approval, dismissal, protected merge, new label, model request or Zotero write occurred. Authentic decisions and independently approved labels remain separately 0/3,715.
Preserved earlier description and historical checkpoints
Current source-integrity note — 2026-09-05
autoresearch/zotero-steward-review-batch@cdc7f697fd72e41947e70dc05e42dae7e3b4a712.autoresearch/zotero-review-decision-cli@8c9eac55c904916334637c03c6f9c3621a2084bc.e7d4e59f1b55b5954c5f8436527bc96e7ef2fb13through ordinary merge ancestry. The source-snapshot digest binds complete captured raw provider JSON and the actual typed classifier inputs; source evidence and derived proposals retain separate identities.GoldenSetApproval.proposal_digestis required and binds the complete proposal records used for evaluation. The current proposal digest is checked before the caller-owned governance verifier. Do not backfill old receipts: regenerate evidence and obtain a new approval bound to the reviewed evidence.Earlier heads, runtime snapshots, campaign counts, and verification statements below are historical notes, not current acceptance evidence.
Historical PR notes — original text retained
Outcome
Provide deterministic owner-only review batches so a human steward can work through the 3,715-record campaign in bounded patch-compatible units without inventing labels or copying the full report.
Current exact stack — 2026-09-05
0ac89b6c5c319ae003611572ce60b8f1e4c0d43a;4feb387c3fd418a24bb14afae2d7309271157f33;Contract
--review-batch REPORT CURRENT_WORKSHEET LIMIT BATCHaccepts 1–100 rows, selects the first pending decisions in canonical item-key order, skips already decided rows, and is deterministic/non-reserving on unchanged input. It retains only the sensitive human-visible context necessary for review and omits broader snapshot/audit/approval state. Owner-only, bounded, no-follow input and create-new0600output protections remain in force.Completed batch JSON is not directly authoritative. #34 reconstructs the exact expected pending batch from immutable report/worksheet state, compares all displayed context, and only then converts completed decisions to the atomic patch boundary.
No live steward decision, Zotero mutation, reservation/assignment, governance approval or publication is claimed. Unverified worksheet decisions and externally approved labels remain separately
0 / 3,715.Merge gate
Keep Draft behind #32 and the full predecessor stack. Require one unchanged exact head with terminal Product/security/SAST/dependency/review evidence, independent approval where applicable, and zero valid unresolved findings. No force-push, destructive rebase, self-approval, predecessor-evidence transfer, live Zotero mutation or authority promotion.