Skip to content

feat(zotero): finalize complete steward worksheets - #27

Draft
seonghobae wants to merge 23 commits into
autoresearch/zotero-worksheet-clifrom
autoresearch/zotero-worksheet-finalization
Draft

feat(zotero): finalize complete steward worksheets#27
seonghobae wants to merge 23 commits into
autoresearch/zotero-worksheet-clifrom
autoresearch/zotero-worksheet-finalization

Conversation

@seonghobae

@seonghobae seonghobae commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Latest bounded-read integration checkpoint

Exact head 3df0c124f390797bacaba8ffdf229f502b0e9bf3 normally merges parent e2dc6006ed3e56d8388e82912826cf37efed0541 while retaining previous child 9c4ecf5fc8bc3e16c3aaffc10ba0498e59128f9d. Base remains autoresearch/zotero-worksheet-cli. The #9 whole-snapshot elapsed-time repair and its RED/GREEN evidence are inherited without reverse-merging later features or discarding predecessor deltas.

This exact head passes Rust 1.98.0 locked workspace tests=133 suites=25, including doctests and excluding filtered subprocess duplicates, strict all-target Clippy, warnings-denied rustdoc, formatting, the existing CI contract and diff checks. Log: /private/tmp/conceptweave-deadline-pr27-20260906.log. Intermediate coverage is not inferred from owner/final-endpoint coverage. No new dependency, actual paper read/decision, Zotero mutation or authority issuer was used.

Draft and protected prerequisites remain. Local tests are not hosted GREEN, independent approval, merged/released source or evidence for another head. Earlier checkpoints below are retained history, not the current head.

Verified local approval-order repair — 2026-09-06 checkpoint

Exact head: autoresearch/zotero-worksheet-finalization@9c4ecf5fc8bc3e16c3aaffc10ba0498e59128f9d. Exact base: autoresearch/zotero-worksheet-cli@f60c07ff0dc0b6933bbf5fa097b5bb72b0b24fea.

Original planner owner #13 preserves regression 505e111c993d8269e5b7b9e17a25a5ce20f8606e and repair 8a684882005085d8b3cb47812e185975084e0475. Every existing local request/mode/item/metadata check finishes before the external approval verifier. Invalid requests invoke it zero times; valid complete requests invoke it exactly once. Local validation errors intentionally precede approval denial. Deterministic operations and complete before/after/rollback metadata are unchanged.

This exact head passed locked Rust 1.98.0 workspace tests (130 tests / 25 unfiltered suites, doctests included), strict all-target Clippy, formatting, warnings-denied rustdoc, CI contract and diff checks before normal push. Normal parent integration retains both the prior child and verified parent as ancestors. Coverage from another stack head is not attributed to this head.

Keep Draft behind the existing prerequisite stack. This is local verification, not hosted current-head GREEN, independent approval, protected merge or release. No later full-text feature was reverse-merged into an earlier owner. Full-text-aware write admission, authentic decisions and independent authority remain separate gaps; no real Zotero/model request, label, approval or write was performed for this repair.

Earlier coordinates and status claims below are historical.

Prior PR description, retained without discarding evidence

Current source-integrity note — 2026-09-05

  • Exact head: autoresearch/zotero-worksheet-finalization@61fee4c3acada36355fbaaa0020828f3a7081555.
  • Exact base: autoresearch/zotero-worksheet-cli@1b5dfde3e09339605ebe3782c51aa265bec3d864.
  • This head inherits PR feat(research): add steward golden-set evaluation #10 root e7d4e59f1b55b5954c5f8436527bc96e7ef2fb13 through ordinary merge ancestry. The source-snapshot digest binds complete captured raw provider JSON and the actual typed classifier inputs; source evidence and derived proposals retain separate identities.
  • GoldenSetApproval.proposal_digest is required and binds the complete proposal records used for evaluation. The current proposal digest is checked before the caller-owned governance verifier. Do not backfill old receipts: regenerate evidence and obtain a new approval bound to the reviewed evidence.
  • Finalizer repair lineage: committed RED regression 4718073e36f80ea2dfe111232425d9f5127fb809 → local GREEN repair 61fee4c3acada36355fbaaa0020828f3a7081555. Finalization rejects blank or mismatched proposal approval digests before producing a reviewed golden set, including title/evidence edits that leave worksheet coordinates unchanged.
  • Keep Draft. This note does not claim current exact-head hosted GREEN, independent approval, protected merge, live Zotero mutation, or governed publication. Root, predecessor, and terminal-stack local test evidence is not transferred as per-PR hosted evidence.

Earlier heads, runtime snapshots, campaign counts, and verification statements below are historical notes, not current acceptance evidence.

Historical PR notes — original text retained

Outcome

Finalize only a fully decided, snapshot-bound steward worksheet into the existing reviewed golden-set input without treating local decisions as governance authority.

Current exact stack — 2026-09-05

Contract

reviewed_golden_set_from_worksheet rebuilds the canonical worksheet from the original ClassificationReport and rejects shifted library/rule/digest/item coordinates, changed proposed dispositions or abstention reasons, missing decisions, duplicate/invalid identity, and NeedsStewardReview as reviewed truth. The resulting labels remain input to the existing evaluator; external governance receipt verification remains authoritative and is not replaced by local finalization.

The live completion claim remains 0/3,715. This branch contains no steward decisions, external approval, Zotero mutation or governed publication. Keep Draft behind #26 -> #25 -> #24 -> #23 -> #22 -> #21 -> #20 -> #19 -> #18 -> #17 -> #16 -> #15 -> #13 -> #12 -> #11 -> #10 -> #9 -> Foundation and require one unchanged exact head with terminal required evidence before integration.

@coderabbitai

coderabbitai Bot commented Sep 4, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@seonghobae

Copy link
Copy Markdown
Contributor Author

@coderabbitai full review

@seonghobae

Copy link
Copy Markdown
Contributor Author

@codex review

@coderabbitai

coderabbitai Bot commented Sep 4, 2026

Copy link
Copy Markdown
⚠️ Action not completed

Review rate limited.


Your included review limit is currently reached under our Fair Usage Limits Policy. This review may still proceed through usage-based billing if eligible. Your next included review will be available in 17 minutes.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

@seonghobae

Copy link
Copy Markdown
Contributor Author

@coderabbitai full review

@coderabbitai

coderabbitai Bot commented Sep 4, 2026

Copy link
Copy Markdown
⚠️ Action not completed

Review rate limited.


Your included review limit is currently reached under our Fair Usage Limits Policy. This review may still proceed through usage-based billing if eligible. Your next included review will be available in 17 minutes.

Non-force restack PR #27 onto PR #26 current head. Preserve snapshot-bound finalization semantics while carrying current predecessor receipt RED contracts and inherited security boundary through ancestry; no predecessor GREEN is claimed.
seonghobae added a commit that referenced this pull request Sep 4, 2026
Non-force restack PR #28 onto PR #27 current head. Preserve parent-aware report roundtrip and governance semantics while carrying current predecessor receipt RED contracts and inherited security boundary through ancestry; no predecessor GREEN is claimed.

Copy link
Copy Markdown
Contributor Author

Current-stack correction (2026-09-05): exact base #26 dd391e5bd1417cf69ea8e532ca5efa8d17b094bf; exact head 42994f771cc1bbacf09cf0d9d1ba0d5057f77c41. Worksheet-finalization semantics are preserved by non-force parent adoption; local decisions still do not constitute governance approval.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant