Repository navigation
Conversation
(ai: vllm-qwen/qwen3.8-27b) 查重: 不重复. This PR (#6138, SSE native-compaction terminal framing) is distinct from two open siblings by the same author — #6136 ("honor native compaction JSON terminal status", fixes the Triage (verified before judging):
Regression review: single caller — Test validity: the 9 new cases have teeth — proven fail-on-base / pass-on-fix. Coverage spans truncated header/data, missing data, malformed JSON, multiline JSON split one-char-per-chunk across LF/CRLF/lone-CR, and failure-data-over-success-header. Real regression gate, not tautology. Code quality (§5b): clear naming, DRY (delegates to sse-util), no dead code, intentional error handling, style-consistent, no new deps. Meets the bar — no forced restructuring needed. Coordination (non-blocking, owner awareness):
CI (live-verified just now): 0 failed / 7 pending — build-artifact, version-guard, gate, test-import-graph, lane-guard already green; remaining lanes still queued. Full-suite verdict pending on the pushed head. 结构化八问
结论:可合(CI 转绿后)。 修复打在根因上、测试是真回归、无回归面、代码整洁,建议 owner 在 CI 全绿后合并(合并权在 human)。#6136 建议与之一并跟进落地,避免只修一半。 |
|
Thanks for the review; I’ll keep #6136 coordinated with this change. I rechecked CI for The run was cancelled at 15:52 UTC, leaving all ten other core shards incomplete. Could a maintainer resume this PR’s incomplete core CI when it fits the queue? The real Codex workflow ran only its gate and skipped the E2E job, so that success status adds no real-client test evidence. |
(ai: vllm-qwen/qwen3.8-27b) CI status update (re-checked live): 0 failed across all 30 checks. Every completed check is |
(ai: vllm-qwen/qwen3.8-27b) Correcting my earlier CI line (Floor 5 said "0 failed"): the mirror cache I read then was a pre-completion snapshot. Re-verified live just now — the authoritative state has settled and differs: Live CI on head That one failure is environmental, not a code regression:
Code verdict unchanged: ready to merge once the core shards re-run green. No code change clears this — it's a flaky install network-reset plus a run cancelled before the remaining shards finished. On your re-run request: resuming/re-running the cancelled core shards is a maintainer/owner action, and it's already in the CI-engineer lane (Floor 4); the coordination home for CI reds is #4599. I left the PR branch untouched upstream (my earlier local rebase was review-only, never pushed), so nothing blocks a clean re-run. I'll re-verify the shards once they complete. |
(ai: vllm-qwen/qwen3.8-27b) Status after my session was force-restarted — no code work was lost, and nothing material has changed on the thread since my last note (Floor 8): Done (my part): the full structured review (Floor 2) and the live-CI reconciliation (Floor 8) are both posted. Verdict: ready to merge once the core shards re-run green. The fix is sound (root-cause, genuine regression tests, no regression surface, clean code). The only red is Current live CI (re-checked just now): unchanged — Blocked on (not me): resuming/re-running the cancelled core shards is a maintainer/owner action, already owned by the CI-engineer lane (Floor 4; coordination home #4599). I left the upstream branch untouched, so nothing blocks a clean re-run. Once those shards go green I'll re-verify them and confirm the all-green verdict — stopping here rather than looping on re-checks. |
[ework] auto-fix stalled: test (windows-latest, 22, 4) — stopping for human review |
|
Landed via batch PR #6439 (merged) — closing as superseded. |
(ai: vllm-qwen/qwen3.8-27b) Confirmed. #6439 is merged (2026-11-12 14:01 UTC) and its diff includes both My review (Floor 2) stands as the analysis record; the verdict was "mergeable once the core shards re-run green," and the content has now landed through #6439. Nothing further needed from me on this thread. |
(ai: vllm-qwen/qwen3.8-27b) Re-triggered on this thread — nothing has changed that requires action. The owner already decided to close #6138 as superseded (Floor 14) because the fix landed in master via batch PR #6439 (merged 2026-11-12 14:01 UTC; its diff includes Taking no further action: no re-review, no new PR (the change is already in master), and I will not close the issue myself — per the no-mutation rule the close is the owner's action / mirror sync, not mine. If the mirror still shows it open, that close is pending on the owner's side. |
Problem
The native-compaction observer accepts event: response.completed before receiving data or a dispatching blank line. Truncated or malformed terminal events can authorize a rebase. Line-by-line parsing also misses multiline data and lone-CR framing.
Changes
Assemble complete events with existing streaming line-ending normalizers. Parse joined data only after the blank-line boundary, ignore undispatched/malformed events, and let explicit failure data prevent a conflicting success header from authorizing rebase.
Validation
Checked #323, SSE history and prior Afloat16 contributions. This changes native-compaction event dispatch boundaries independently of whole-body JSON classification.
Base: e1e33a9.
Closes #6137