Repository navigation
Conversation
…ror still fails Additive review follow-up on PR ranxianglei#6136: the fix checks the error payload before honoring status=completed, but no test pinned that ordering. A {"status":"completed","error":{...}} body must stay failed so a contradictory completion claim cannot schedule a rebase.
(ai: vllm-qwen/qwen3.8-27b) Duplicate screening: NOT a duplicate. Searched open + closed issues/PRs by failure signature (native-compaction terminal state / Labels applied: Triage verification (performed locally, base e1e33a9 vs head 5caa9a1):
Adjacent paths checked: the local 八问(结构化审核结论)
Verdict: mergeable. Root cause fixed at the decision point, regression matrix fully closed, tests exercise the real |
|
Landed via batch PR #6439 (merged) — closing as superseded. |
…ror still fails Additive review follow-up on PR ranxianglei#6136: the fix checks the error payload before honoring status=completed, but no test pinned that ordering. A {"status":"completed","error":{...}} body must stay failed so a contradictory completion claim cannot schedule a rebase. (cherry picked from commit e5235f1)
(ai: vllm-qwen/qwen3.8-27b) Confirmed, thread done. Progress note (my process was restarted mid-idle; the review itself finished and posted before that):
|
(ai: vllm-qwen/qwen3.8-27b) Final wrap-up for this thread (closing summary — details are in my review comment above): What I did: full review of @Afloat16's fix for the JSON terminal-status observer ( Evidence (all verified by me, locally + CI):
Verdict: mergeable. Outcome: you landed the fix via batch PR #6439 (merged 2026-11-12, merge commit Remaining: nothing. One honest caveat: the shared GitHub API token is currently rate-limited, so I could not re-pull the PR object this minute, and the mirror still lists the thread as open — I read that as mirror sync lag, not a reopen. No follow-ups, no issues to file. |
Problem
The JSON observer accepts any output array as completion even with failed, incomplete, cancelled, queued or in_progress status, scheduling an invalid context rebase. A normal error:null field conversely blocks a successful rebase.
Changes
Honor semantic failure states, keep pending/unknown statuses fail-closed, and accept null error on successful output. Status-less compact endpoint responses remain supported.
Validation
Checked #323, #2311 and previous Afloat16 contributions. No kernel or configuration changes.
Base: e1e33a9.
Closes #6135