Repository navigation
Conversation
[bot] 🏷 (ai: vllm-qwen/qwen3.8-27b) Duplicate screening: this PR duplicates an earlier open PR by the same author — 查重: 重复 #6579.
Both are by @Afloat16, both modify the same file Disposition (先来后到 / first-come-first-served): the earlier #6579 is the canonical one and should be kept; the later #6665 should be closed in its favor (likewise #6664 is a duplicate of #6578). Per the no-source-mutation rule I am not relabeling or closing #6665 myself — that call is yours. Say the word and I'll apply the The two fixes differ in approach, so there is a real choice to make:
I'm running a full correctness comparison of both (mixed line endings, chunk-boundary CRLF, fragmented UTF-8, blank-line spanning chunks) and will post the detailed review + 8-question next so you have the evidence to pick which one to keep. |
|
Thanks for the duplicate screening. I am keeping #6579 as the canonical PR and #6578 as the tracking issue, and closing #6665 and #6664 in their favor. The commits, benchmark, and regression cases on this branch remain available for the correctness comparison you described. Any remaining findings can be tracked on #6579 so the two approaches do not create parallel landing paths. |
Closes #6664
Problem
Native compaction can include a large encrypted-content field in a single SSE event.
observeSseTerminalStatecurrently normalizes and searches the full unfinished event after every chunk, so a fragmented event is repeatedly flattened and scanned before its terminal decision can finish.Changes
scripts/bench-terminal-sse.mjsto measure the exported observer with configurable frame size, chunk size and line endings.Validation
stream-terminal,terminal-sse-framing,terminal-sse-fragments,native-compact-terminal, andcodex-compact-e2e(the native integration case was rerun after the final payload assertion adjustment).npm run build, andgit diff --check: pass.Local benchmark
Node v24.22.1, Linux, 16 MiB encrypted-content field, 64 KiB chunks, three iterations per case. Each iteration validates
completed; frame construction/import are outside the interval and decoding/framing/JSON classification are included.Reproduce with
node --import tsx scripts/bench-terminal-sse.mjs 16 64 lfand the same command ending incrlf. These measurements concern this observer and vary with runtime/load; they are not end-to-end proxy throughput claims. The observer still retains one unfinished event and validates its complete JSON; this change introduces no new frame-size limit.Compatibility
The SSE protocol decisions from #6138 and JSON status handling from #6136 are unchanged. No configuration, wire shape, kernel logic or dependency changes.