Repository navigation
[PR] chore(batch): land 50 open Afloat16 fixes in one history-preserving batch - #6439
Merged
Merged
Conversation
(cherry picked from commit 0d2ee1d)
(cherry picked from commit 30bbd3d)
(cherry picked from commit e1706ab)
(cherry picked from commit 4bead21)
(cherry picked from commit 6f2a546)
(cherry picked from commit 95f6818)
(cherry picked from commit 3a9ceb4)
(cherry picked from commit 981fea2)
(cherry picked from commit b0a7c7f)
(cherry picked from commit 866f496)
(cherry picked from commit 83689e9)
(cherry picked from commit 7ae67d6)
(cherry picked from commit a3d29b5)
The existing split-SSE case passes on unpatched source too (its large
frame carries no trip-worthy run), so the /^[{\[]/ gate added alongside
the frame-boundary fix had no regression coverage. This frame is a single
>=64KB SSE event whose pretty-printed payload spans many data: lines and
ends in a 200-codepoint run: without the gate the NDJSON fallback engages
on the first chunk and drops every unparseable line, missing the trip.
Reviewer addition for #6128.
(cherry picked from commit b8e6d9d)
Review follow-up for the frame-boundary fix (issue #6127): - Tolerate leading blank lines/whitespace before the first NDJSON line (gate /^[{\[]/ -> /^\s*[{\[]/): an NDJSON stream opening with a stray blank line would otherwise never engage the fallback and lose text-run detection for the whole stream. SSE field lines never open with whitespace, so oversized split SSE events stay protected by the gate. - Document the non-obvious framing invariants at their sites: the cursor re-anchor after each consumed frame, sticky NDJSON mode, retained partial tail, and why the JSON-token gate exists. Adds a regression test: leading-blank-line NDJSON trips once its repeated delta completes across chunks (fails on the pre-change gate). (cherry picked from commit 3b150bf)
(cherry picked from commit 84d84ed)
Reviewer alignment for PR #6131 (fixes #6130): test-only, no behavior change. The four original cases passed under every leaf permutation, so the one named "preserves text order" pinned no ordering; renamed it to what it actually asserts (mixed array/object visitation plus cross-leaf run continuity) and added one positive and one negative wire-order case (separated vs contiguous 150-runs against the 200 default threshold). Both new cases fail against a forward-push (reversed-order) variant of the walker and pass on this implementation. (cherry picked from commit 5aa1d6b)
(cherry picked from commit 70f175b)
(cherry picked from commit 5caa9a1)
…ails Additive review follow-up on PR #6136: the fix checks the error payload before honoring status=completed, but no test pinned that ordering. A {"status":"completed","error":{...}} body must stay failed so a contradictory completion claim cannot schedule a rebase. (cherry picked from commit e5235f1)
(cherry picked from commit d48b0a9)
(cherry picked from commit 4f04a7a)
(cherry picked from commit bf3509d)
(cherry picked from commit 70bc835)
(cherry picked from commit 9bfdd92)
… tool media (#6146) Review supplement to PR #6147: #3617 gate discipline requires both directions of a gate. The image/* mime filter on the Gemini note path had only its positive case pinned. Adds a nested application/pdf case asserting it is billed and counted but earns no recovery note — the note carries a decompress({imageRef}) recovery ref, and the restore channel indexes nested google media for image/* mimes only (src/image-restore.ts), so a note there would promise a restore it cannot deliver. Billing stays mime-agnostic. Also drops a stray double blank line in tests/preflight-google-summary.test.ts. (cherry picked from commit 5f3d479)
(cherry picked from commit 378ba55)
(cherry picked from commit a10e38f)
(cherry picked from commit 9af4b7f)
(cherry picked from commit 68429e1)
This was referenced Nov 12, 2026
Closed
Closed
Closed
Closed
This was referenced Nov 12, 2026
ranxianglei
pushed a commit
that referenced
this pull request
Nov 14, 2026
…merge commit These files (issue-number lists recording the superseded closings of the previous four batches #6439/#6455/#6464/#6482) are present in neither parent of the #6574 merge commit yet appear in its result, and survive to the branch tip. They are not part of any source PR, are referenced nowhere, are not mentioned in the PR description, and the previous four batch merges never committed such files to master. Process scratch data does not belong at the repo root; the closing record already lives in GitHub history.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
chore(batch): land 50 open Afloat16 fixes in one history-preserving batch
This batch lands the 50 currently-open PRs from @Afloat16 (67 non-merge commits) on top of master, in original PR order. Every commit keeps its original author and a
cherry picked fromtrailer pointing at the source PR, so per-PR provenance and history are preserved in one reviewable unit.Why batched
The 50 PRs are small, individually CI-green fixes found by Afloat16's agent (2026-11-09 to 11-11). Merging them one by one forces 50 rounds of merge/rebase churn on master; landing them as a single ordered sequence lets CI validate the combined state once. Three same-file touchpoints needed manual conflict resolution (mysql.ts import line, live-files.mjs test whitelist, listKv prefix clause); all resolutions are union/superset, no semantics dropped.
All 50 source PRs are individually reviewed (full diff audit, not just CI status): each verified against the surrounding implementation, no fix found incorrect or unsafe.
Original PRs
Closing the linked issues (the 50 source PRs are superseded by this batch and will be closed manually on merge):
Closes #6077 #6083 #6085 #6087 #6091 #6093 #6095 #6097 #6099 #6101 #6127 #6130 #6133 #6135 #6137 #6139 #6141 #6144 #6146 #6148 #6174 #6175 #6176 #6177 #6179 #6180 #6196 #6200 #6202 #6204 #6206 #6208 #6210 #6212 #6214 #6218 #6222 #6224 #6225 #6226 #6227 #6228 #6229 #6230 #6231 #6235 #6241 #6243 #6248
Verification
git cherry-pick -xof all 67 commits over master (ascending PR order); 3 conflicts resolved by union — no semantics droppednpm run typecheck: passTo remove an individual fix
Each commit message names its source PR in the
cherry picked fromtrailer; drop the corresponding commit(s) with an interactive rebase before merge.