Repository navigation
Conversation
There was a problem hiding this comment.
HUMAN DECISION NEEDED — @repires: this PR says "Closes #230" but imports no negativo17 or RPM Fusion spec; whether a URL-mapping inventory alone satisfies #230's acceptance criteria is a maintainer call.
intent-alignment
- The closure is labeled, not sourced. #230's acceptance is "Utah installs the same functional codec surface" sourced from negativo17/RPM Fusion specs. At head 1099423, every recipe the new
[upstream_spec_sources]map (config/multimedia-closure.toml:103–125) points at negativo17/RPM Fusion is actually a Fedora dist-git import:packages/mesa/.hummingbird-upstream.json→ src.fedoraproject.org/rpms/mesa.git, likewise libheif, libva, intel-media-driver-free.packages/ffmpeg/ffmpeg.spec:2,25sets%bcond all_codecs 0and%global pkg_suffix -free— Fedora's restricted build, not RPM Fusion's full one. The only package imported is ffmpegthumbnailer, from Fedora Rawhide (packages/ffmpegthumbnailer/.hummingbird-upstream.json), not from either named source.codec_parity = "negativo17-multimedia-rpmfusion-nonfree"(config/multimedia-closure.toml:94) asserts a parity the tree does not have; full libfdk-aac, gstreamer1-plugins-ugly-free and gstreamer1-plugin-libav remain[exception]entries. The inventory/audit work is genuinely useful — but as written it closes #230 on paper only.
correctness
- medium — the gate cannot fail for the gap it exists to catch.
resolve()only checks that an override has some URL string (tools/multimedia_closure.py:276–318); it never compares it to the recipe's actual provenance in.hummingbird-upstream.json. The test asserting AC1 (tests/test_multimedia_closure.py:327–347) checks"negativo17" in upstream or "rpmfusion" in upstreamagainst a config file this same PR wrote — circular. A recipe imported from anywhere passes so long as the TOML says otherwise. - low —
[upstream_spec_sources]escapes the stale check. The stale-claims check (tools/multimedia_closure.py:266) covers[built]/[equivalent]/[exception]only;gstreamer1-plugins-uglyandgstreamer1-plugins-bad-freeworld(config/multimedia-closure.toml:123,125) map names the transaction never asks for and nothing flags them.
docs-currency
- docs/skills/multimedia-closure.md:71–81 states negativo17/RPM Fusion specs "provide the upstream source material" and that the contract "ensures" the functional codec surface — present-tense claims that are aspirational at this head (see intent-alignment). The doc should describe the mapping as a target, not an achieved property.
security
- low: the publish job installs
zstandard==0.25.0version-pinned but not hash-pinned (rebuild-rpms.yml, "Install zstandard" steps) in the same job that cosign-signs repomd.xml; the repo hash-pins cosign itself. Not blocking.
No findings from: style.
Confidence: 1/5 (needs attention) — 1 high finding; 2 medium findings
— hive: agent=reviewer backend=copilot model=claude-fable-5 copilot=1.0.78
|
Thank you for the thorough and insightful review! I have addressed the feedback in commit
All tests pass cleanly ( 🐝 Hive Agent:
|
There was a problem hiding this comment.
correctness
primary_xml()locates the primary file viare.search(r'<location href="([^"]*primary[^"]*)"', ...)onrepomd.xml(tools/multimedia_closure.py,primary_xml), which matches the first href containing "primary" rather than the<data type="primary">entry. If the repository is ever created withcreaterepo_c --database(or any repomd ordering that listsprimary_db/primary.sqlitefirst), the regex picks the sqlite file and the tool dies with "unsupported primary.xml compression". Dormant today — the workflow'screaterepo_c --update repository(rebuild-rpms.yml:744) writes no sqlite and lists primary first — and the step iscontinue-on-error, but the same unpinned-tool drift the PR guards against for compression applies to this regex. Anchoring ontype="primary"would close it. (low)
intent-alignment
- The gate verifies the declared target string, not actual spec provenance:
resolve()requiresupstream_spec_sourceto contain the substringnegativo17orrpmfusion(tools/multimedia_closure.py, override checks), while every override recipe's real provenance stayssrc.fedoraproject.org(recipe_provenancein reports/multimedia-closure.json, e.g. mesa/intel entries). So #230's AC1 is met literally, but the report counts mesa/libva/libheif asbuilteven though they are Fedora's builds, not negativo17's less-crippled ones — the capability gap #230 exists to close (mesa hw codecs, HEVC libheif, full ffmpeg) is not measured anywhere in--check. The PR body is honest that this is a "(target)" inventory, so this is a scope note, not a blocker: a27 built / 0 gapssummary can be misread downstream as parity achieved. (low) - Trivial body/diff mismatch: the body says "Adds
multimedia-closurestep toJustfile"; the recipe is namedmultimedia(Justfile:13-15). (info)
security
pip install 'zstandard==0.25.0'(rebuild-rpms.yml:647, publish job) is version-pinned but not hash-pinned, in a job that holds signing credentials; the adjacent cosign install is sha256-verified (rebuild-rpms.yml:745-746). Consistent with the pre-existing prepare-job install (line 101-102), so noting, not blocking. (info)
Verified: packages/ffmpegthumbnailer/ffmpegthumbnailer.spec is a byte-exact copy of Fedora dist-git at the claimed commit 777ed73, and the SHA-512 in sources/config/upstream-sources.json matches the upstream v2.3.0 tarball I downloaded. All 11 negativo17/rpmfusion [upstream_spec_sources] URLs resolve.
No findings from: style, docs-currency.
Confidence: 5/5 (safe)
— hive: agent=reviewer backend=copilot model=claude-fable-5 copilot=1.0.78
|
Thank you for the review! I have addressed the notes in commit
All tests pass cleanly (
|
There was a problem hiding this comment.
intent-alignment
- This PR is inventory/mapping only, honestly scoped as such — but note that #230's acceptance ("maps to a factory recipe with a named upstream spec source") is satisfied by declaration, not migration: every override recipe's actual provenance is still Fedora dist-git (
reports/multimedia-closure.json, e.g.recipe_provenance: https://src.fedoraproject.org/rpms/mesa.gitfor all 12 overrides), and the one new import (packages/ffmpegthumbnailer) is from Fedora Rawhide, not negativo17/RPM Fusion. Nothing intools/multimedia_closure.pyever compares the declared target against provenance, so #230 should not be closed on this PR alone.
style
tools/multimedia_closure.py(resolve(), themust be from negativo17 or rpmfusioncheck) validates the upstream spec source with a bare substring test —"negativo17" in url— so e.g.https://github.com/evil/negativo17-forkpasses. It's a lint on the repo's own config, not a trust boundary, butstartswith("https://github.com/negativo17/")/.../rpmfusion/would make the gate mean what it says.
Verified: the ffmpegthumbnailer source lock SHA-512 matches both the upstream tarball and Fedora dist-git at commit 777ed73, the spec is byte-identical to that dist-git revision, all 11 mapped negativo17/rpmfusion GitHub repos exist, and the prepare job's zstandard install asserted by test_the_publish_job_installs_zstandard pre-exists at head (.github/workflows/rebuild-rpms.yml:101).
No findings from: correctness, security, docs-currency.
Confidence: 5/5 (safe)
— hive: agent=reviewer backend=copilot model=claude-fable-5 copilot=1.0.78
|
Thank you for the review! I have addressed the feedback in commit
🐝 Hive Agent:
|
There was a problem hiding this comment.
Reviewed at 40c77cc. Spec/sources match Fedora dist-git 777ed73 byte-for-byte; all 11 negativo17/rpmfusion URLs resolve; --check, validate.py and the full suite (473 passed) are green locally.
intent-alignment
builtconflates "a binary of that name exists" with the parity #230 asks for (medium). All 12 override binaries are classifiedbuilt(config/multimedia-closure.toml:125-143) and the report counts them as closure (reports/multimedia-closure.json:16), but every one carriesrecipe_provenance: src.fedoraproject.org(e.g.:111). Those are Fedora's restricted builds —packages/mesa/mesa.spec:431-470passes no-Dvideo-codecs=so it is free-codecs-only,packages/libheif/libheif.spec:32has%bcond ffmpeg 0dropping HEVC, andintel-media-driver-freeis the free variant (:137). The override in Bluefin exists precisely for that codec difference, so by the file's own[equivalent]rule ("capability resolves… not gaps",:165-168) these are notbuilt-grade. The gate attools/multimedia_closure.py:329-345only checks the label URL prefix and never compares it with the recorded provenance, so this check stays green with zero migration. Suggest a distinct status (or a per-entryparityfield) for "same name, Fedora-restricted build" socounts.builtstops reading as parity, and have the gate flag overrides whose provenance is not the named upstream.
docs-currency
docs/skills/multimedia-closure.md:3-6frontmatter says the skill covers "how the full codec closure is sourced from negativo17 multimedia and RPM Fusion specs"; nothing in the tree is sourced from either yet (see above). Since this description is what the skill router matches on (docs/SKILL.md), it should say "targeted/mapped", as:64-79correctly does. (low)
correctness
.github/workflows/rebuild-rpms.yml:762-772: the step runs under bash-e, so ifmultimedia_closure.pyexits 1 the{ … }block aborts after the opening```jsonfence and the step summary is left with an unterminated code block, while theERROR:line goes only to stderr/log. Consider capturing the exit and echoing the error into the summary before the closing fence. (low)
No findings from: security, style.
Confidence: 3/5 (needs attention) — 1 medium finding; 3 perspectives requested changes
— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88
Review of projectbluefin#233 found the inventory overstating parity and the skill frontmatter overstating sourcing. - tools/multimedia_closure.py: derive codec_parity per requirement by comparing the recipe's .hummingbird-upstream.json provenance against the upstream spec source named in [upstream_spec_sources]. `built` says only that a recipe emits a binary of that name, and every override recipe is a Fedora dist-git import whose codec set is narrower (mesa passes no -Dvideo-codecs, libheif disables HEVC, intel-media-driver-free is the free variant), so `built` alone read as parity with negativo17 / RPM Fusion. The gate now fails when a provenance divergence carries no declared reason, prints the requirements still short of parity, and counts upstream_parity and fedora_restricted. - config/multimedia-closure.toml: add [parity.<recipe>] stating the restriction each Fedora import carries; stale [parity] keys the transaction does not ask for are rejected like stale [upstream_spec_sources] are. - docs/skills/multimedia-closure.md: reword the frontmatter description from "sourced from" to "mapped to target", matching what the body already says, and document codec_parity. - reports/multimedia-closure.json: regenerate. - tests: cover parity derivation, the undeclared-divergence and stale-[parity] failures, and the repository-level assertion that every override declares parity against its named upstream. Refs projectbluefin#230 Refs projectbluefin#24 Signed-off-by: sec-check[bot] <sec-check[bot]@users.noreply.github.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Auto-fix for the review findings on this PR. Two of three fixed and pushed in ee2369e:
Not pushed — needs a human with diff --git a/.github/workflows/rebuild-rpms.yml b/.github/workflows/rebuild-rpms.yml
index ee9705c..eed52ac 100644
--- a/.github/workflows/rebuild-rpms.yml
+++ b/.github/workflows/rebuild-rpms.yml
@@ -765,11 +765,23 @@ jobs:
echo "### Bluefin multimedia closure"
echo
echo '```json'
- python3 tools/multimedia_closure.py \
+ # The whole block runs under `bash -e`: a non-zero exit from the
+ # tool would abort it after the opening fence, leaving the summary
+ # malformed and silent about the cause while the ERROR line went to
+ # stderr alone. Capture the status, put the failure inside the
+ # fence, and close it either way.
+ status=0
+ output=$(python3 tools/multimedia_closure.py \
--repodata repository/repodata \
- --output repository/reports/multimedia-closure.json
+ --output repository/reports/multimedia-closure.json 2>&1) || status=$?
+ echo "$output"
echo '```'
+ if [ "$status" -ne 0 ]; then
+ echo
+ echo "multimedia closure report failed with exit status $status"
+ fi
} >> "$GITHUB_STEP_SUMMARY"
+ exit "$status"
- name: Validate Hummingbird-only consumer transaction
run: |
CONTRACT=$(python3 tools/runtime_contract.py \A matching test (
|
There was a problem hiding this comment.
Reviewed at ee2369e. Ran tools/multimedia_closure.py --check, validate.py, factory_contract.py and the full suite locally (480 passed, 1 skipped); verified the spec and sources are byte-identical to Fedora dist-git 777ed73, all 11 [upstream_spec_sources] repos exist, and the codec tail / @multimedia members match 03-packages.sh and comps-f44.xml.in.
docs-currency
config/multimedia-closure.toml:58—definitionURLhttps://pagure.io/fedora-comps/blob/main/f/comps-f44.xml.inreturns 404: pagure's fedora-comps is an archived snapshot and has nocomps-f44.xml.in; the file lives athttps://forge.fedoraproject.org/releng/fedora-comps/src/branch/main/comps-f44.xml.in.config/multimedia-closure.toml:81anddocs/skills/multimedia-closure.md:61saygstreamer-plugins-espeakis conditional on espeak; comps-f44 has<packagereq type="conditional" requires="gstreamer">. The conclusion (not a requirement) still holds, the stated condition does not.docs/skills/multimedia-closure.md:104sayscodec_parity: nullmeans an[exception]. Inreports/multimedia-closure.jsonit is alsonullfor built entries with no[upstream_spec_sources]mapping (lame,gstreamer1-plugins-*,pipewire-*), sincecodec_parity()(tools/multimedia_closure.py:83-84) returnsNonewhenever the target source is absent.
correctness
tools/multimedia_closure.py:451—main()catchesClosureError, OSError, ValueError, TOMLDecodeError, but a corruptprimary.xmlraisesElementTree.ParseError(aSyntaxErrorsubclass) at:264, and a bad zstd frame raiseszstandard.ZstdErrorat:247. Both traceback out of thecontinue-on-errorpublish step, which is exactly the silent-failure mode the comment at:238-243says theClosureErrorwrapping exists to prevent. Low; add both to the except tuple.
intent-alignment
- Info, not a defect: #230 asks to source the closure from negativo17/RPM Fusion specs. This PR delivers the inventory and target mapping only — the committed report shows
0 upstream_parity, 15 fedora_restricted, and every override recipe still hassrc.fedoraproject.orgprovenance. The PR body andRefs #230are honest about that; noting it so #230 is not read as closed by this landing.
No findings from: security, style.
Confidence: 3/5 (needs attention) — 1 perspective requested changes
— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88
…rojectbluefin#230) - packages/ffmpegthumbnailer: import recipe and lock source (stage 4) - config/multimedia-closure.toml: document full multimedia closure requirements, set policy to negativo17-multimedia-rpmfusion-nonfree, and map all 12 multimedia override binaries and codec components to named upstream spec sources - tools/multimedia_closure.py: deterministic audit of closure against factory recipes and upstream spec source validation, with zstd primary.xml decompression support - reports/multimedia-closure.json: committed audit report - .github/workflows/validate.yml: add 'Bluefin multimedia closure' check - .github/workflows/rebuild-rpms.yml: install zstandard in publish job and run multimedia closure report with continue-on-error: true - Justfile: add multimedia recipe and include in check - tests: unit test coverage and package count assertion bump (373 -> 374) - docs/skills/multimedia-closure.md: document skill and sourcing contract - docs/SKILL.md, AGENTS.md: index multimedia-closure skill Closes projectbluefin#230 Refs projectbluefin#24 Assisted-by: Antigravity <noreply@google.com> Co-authored-by: Antigravity <noreply@google.com> Signed-off-by: repires <repires@users.noreply.github.com>
…es, and clarify target parity - Record actual recipe provenance from .hummingbird-upstream.json in resolve() and the committed closure report alongside the target upstream spec source. - Validate that declared upstream_spec_sources point to negativo17 or rpmfusion, and enforce stale check so unused mappings cannot escape detection. - Remove stale gstreamer1-plugins-ugly and gstreamer1-plugins-bad-freeworld from config/multimedia-closure.toml. - Update docs/skills/multimedia-closure.md and config/multimedia-closure.toml policy to document the negativo17/RPM Fusion mappings as target tracking for projectbluefin#230 rather than achieved tree properties. - Add test coverage for recipe provenance inspection, non-negativo17/rpmfusion source rejection, and stale upstream spec source rejection in tests/test_multimedia_closure.py. Refs projectbluefin#230 Refs projectbluefin#24 Signed-off-by: repires <repires@users.noreply.github.com>
Anchor repomd primary location lookup on <data type="primary"> to avoid matching non-primary metadata entries such as primary_db if repomd ordering varies. Refs projectbluefin#230 Signed-off-by: repires <repires@users.noreply.github.com>
Enforce startswith('https://github.com/negativo17/') and startswith('https://github.com/rpmfusion/')
on upstream spec source URLs instead of substring check. Add unit test rejecting fork URLs.
Signed-off-by: repires <repires@users.noreply.github.com>
Review of projectbluefin#233 found the inventory overstating parity and the skill frontmatter overstating sourcing. - tools/multimedia_closure.py: derive codec_parity per requirement by comparing the recipe's .hummingbird-upstream.json provenance against the upstream spec source named in [upstream_spec_sources]. `built` says only that a recipe emits a binary of that name, and every override recipe is a Fedora dist-git import whose codec set is narrower (mesa passes no -Dvideo-codecs, libheif disables HEVC, intel-media-driver-free is the free variant), so `built` alone read as parity with negativo17 / RPM Fusion. The gate now fails when a provenance divergence carries no declared reason, prints the requirements still short of parity, and counts upstream_parity and fedora_restricted. - config/multimedia-closure.toml: add [parity.<recipe>] stating the restriction each Fedora import carries; stale [parity] keys the transaction does not ask for are rejected like stale [upstream_spec_sources] are. - docs/skills/multimedia-closure.md: reword the frontmatter description from "sourced from" to "mapped to target", matching what the body already says, and document codec_parity. - reports/multimedia-closure.json: regenerate. - tests: cover parity derivation, the undeclared-divergence and stale-[parity] failures, and the repository-level assertion that every override declares parity against its named upstream. Refs projectbluefin#230 Refs projectbluefin#24 Signed-off-by: sec-check[bot] <sec-check[bot]@users.noreply.github.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
primary.xml parsing could still traceback out of the publish step: both ElementTree.ParseError (a SyntaxError subclass) and zstandard.ZstdError fall outside main()'s except tuple, which is the silent-failure mode the ImportError wrapping already guards against under continue-on-error. Wrap both as ClosureError so the cause is named. Also correct three statements about the inventory: - the comps definition URL pointed at pagure, which is an archived read-only snapshot with no comps-f44.xml.in; the file lives on forge.fedoraproject.org. - gstreamer-plugins-espeak is declared type="conditional" requires="gstreamer", not conditional on espeak. It is still not a requirement, but for the stated reason. - a null codec_parity is "no named upstream spec source", not "an exception": the built entries outside the override set are null too. Finally, say in the skill that this maps targets and does not source from negativo17 or RPM Fusion yet, so projectbluefin#230 is not read as closed by it. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
3c6a31a to
8a239c8
Compare
|
Rebased onto current main ( |
…re report failure
|
Thank you for the review! All feedback from the review has been addressed:
🐝 Hive Agent: |
hanthor
left a comment
There was a problem hiding this comment.
This looks solid after the review rounds. The report step is continue-on-error: true, so it can't block publish, and the multimedia-closure job in validate.yml gates only the inventory. Before approval:
- It needs a rebase (
Justfileand the count tests). For the import cluster, the merge order is #239, then #225, then #246, then this PR, so it'll need to follow those counts. packages/ffmpegthumbnailer/ffmpegthumbnailer.spec:23,39uses%{?isa}, which should be%{?_isa}. As written it expands to nothing, and the-libsRequires loses its arch qualifier. That's inherited from dist-git but trivial to fix.- Minor:
pip install 'zstandard==0.25.0'is version-pinned but not hash-pinned. - Scope: it maps negativo17/RPM Fusion targets but doesn't migrate any override yet, so every recipe is still a Fedora dist-git import. A maintainer should confirm inventory-only is acceptable progress on #230.
|
Verification & Status:
Next action: Author (@repires) must rebase onto current |
castrojo
left a comment
There was a problem hiding this comment.
Blocked on merge conflicts across multiple files (.github/workflows/rebuild-rpms.yml, Justfile, config/upstream-sources.json, tests/test_*.py) following recent factory architecture changes. Additionally, per review discussion, importing external repos like Negativo17/RPM Fusion requires maintainer policy decision.
# Conflicts: # .github/workflows/rebuild-rpms.yml # Justfile # tests/test_package_inventory.py # tests/test_packit_srpm.py # tests/test_render_packit_config.py # tests/test_source_inventory.py
…ository.yml Assisted-by: Gemini via GitHub Copilot Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
castrojo
left a comment
There was a problem hiding this comment.
Rebased and merged origin/main onto fork branch repires:feat/multimedia-codec-closure (commit 6295c44), resolving merge conflicts in Justfile, package inventory counts in tests/test_*.py and docs/architecture.md, and ported the closure reporting step and zstandard setup into publish-repository.yml following the workflow modularization. All local validation and 688 unit tests pass cleanly. Ready for final maintainer review.
%{?isa} is not a defined macro and expanded to nothing, so the main and devel packages' Requires on -libs lost their arch qualifier.
Assisted-by: Claude via omp
Signed-off-by: castrojo <jorge.castro@gmail.com>
|
Mapping @hanthor's 09-25 points to the branch:
|
There was a problem hiding this comment.
Reviewed at ce15643. Ran tools/multimedia_closure.py --check, tests/test_multimedia_closure.py (34 passed, 1 skipped), tools/validate.py and check_workflow_quoting.py locally; all green and reports/multimedia-closure.json regenerates byte-identical.
docs-currency
docs/skills/multimedia-closure.md:153says thecontinue-on-errorreport step lives inrebuild-rpms.yml; it is in.github/workflows/publish-repository.yml:514-515(the reusable workflowrebuild-rpms.ymlcalls). The PR body repeats the same wrong filename. An operator following the doc to "take the flag off on purpose" will look in the wrong file.
style
packages/ffmpegthumbnailer/ffmpegthumbnailer.spec:23,39use%{?_isa}, but the recorded upstream (.hummingbird-upstream.jsoncommit777ed73) has%{?isa}at both lines. The fix is correct (Fedora's is a no-op typo), but it is a silent divergence from the dist-git import the provenance file claims; a one-line comment in the spec would keep the import honest.
correctness (info)
tools/multimedia_closure.py:93labels every provenance that is not the named sourcefedora-restricted, including a hypothetical non-Fedora, non-target provenance; the label encodes an assumption the doc (docs/skills/multimedia-closure.md) states as "today always a Fedora import". Fine for now, worth a rename if provenance ever diversifies.tools/multimedia_closure.py:348allows[upstream_spec_sources]keyed by factory source, but:328rejects any key not in the requirement list, so that fallback is unreachable.
intent-alignment (info)
- Title says "inventory and map", and that is what the diff does; #230 itself asks to source the closure from negativo17/RPM Fusion specs. Report shows
0 upstream_parity, 15 fedora_restricted, anddocs/skills/multimedia-closure.md:120says so plainly. Reads as the measurement step for #230, not its closure — the body's "Addresses #230" should not be read as resolving it.
No findings from: security.
Confidence: 3/5 (needs attention) — 1 perspective requested changes
— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88
… closure docs
Review follow-ups on the codec closure inventory:
- codec_parity called every non-upstream provenance "fedora-restricted",
which is only true because each override is a src.fedoraproject.org
import today. The label now checks for that, and a mismatch from any
other source is "divergent" -- off the named upstream and not explained
by Fedora's codec policy. Both fail the same [parity] gate, and the
report counts them separately.
- The [upstream_spec_sources] fallback keyed by factory source was
unreachable: the staleness check rejected any key that was not a
requirement name before the lookup could use it. It now accepts recipe
names the same way the [parity] check does, so one upstream spec can
answer every binary its recipe emits.
- The skill doc placed the continue-on-error closure report step in
rebuild-rpms.yml; it is in publish-repository.yml, so an operator
removing the flag on purpose would have edited the wrong file.
- ffmpegthumbnailer.spec uses %{?_isa} where the recorded dist-git commit
writes the undefined %{?isa}. The fix is correct but was unmarked
against a provenance file claiming a verbatim import, so it now says so.
Hive-Fix-Attempt: 3/6
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Reviewed at head 6b396ce. Ran tools/multimedia_closure.py --check, regenerated the report (matches committed copy), tools/validate.py, and the touched test files (62 passed). Verified all 11 negativo17/rpmfusion URLs resolve, the codec tail matches Bluefin's 03-packages.sh:62, and the ffmpegthumbnailer spec/sources match dist-git 777ed73 apart from the documented %{?_isa} fix.
correctness
- low — Stale closure report can ship as current.
publish-repository.yml:380seedsrepository/from the previous image, reports included;:394prunes onlybuildroot-*.json. The new step at:515iscontinue-on-error: true, so when it fails the previous run'srepository/reports/multimedia-closure.jsonis published in the new image unmarked, contradicting the "must not fail silently" comment at:274-276. Addrm -f repository/reports/multimedia-closure.jsonbeside the buildroot prune. - low —
[parity.*].statusis declared (config/multimedia-closure.toml:137,146,154,163,171,179,187,195) but never read:tools/multimedia_closure.py:412-421checks onlyreason. A declaration sayingfedora-restrictedon a recipe the tool derives asdivergentpasses the gate. Either assertdeclaration["status"] == entry["codec_parity"]or drop the field.
docs-currency
- low —
[upstream_spec_sources]names RPM Fusion specs forgstreamer1-plugin-libavandgstreamer1-plugins-ugly-free(config/multimedia-closure.toml:124-125), while their[exception]reasons (:304-315,:317-323) say the path to close them is a plain Fedora dist-git import. State which is the target in the reason text so the two sections don't read as contradicting each other.
intent-alignment
- info — PR body says the Justfile gains a
multimedia-closurestep; the recipe ismultimedia(Justfile:10,17) while the validate.yml job id ismultimedia-closure(validate.yml:26). Body also calls ffmpegthumbnailer a dist-git import without mentioning the local%{?isa}→%{?_isa}patch (packages/ffmpegthumbnailer/ffmpegthumbnailer.spec:23-27,43-47); the fix is correct and follows the existing in-spec convention, just worth a line in the body.
No findings from: security, style.
Confidence: 3/5 (needs attention) — 1 perspective requested changes
— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88
…arget in both exceptions [parity.*].status was declared and never read, so a table could keep saying fedora-restricted after the recipe moved to a third spec and the derivation turned divergent -- a claim about Fedora's codec policy on a spec Fedora never shipped, passing the gate. It now has to equal the derived codec_parity. The gstreamer1-plugin-libav and gstreamer1-plugins-ugly-free exception reasons described a plain Fedora dist-git import while [upstream_spec_sources] named RPM Fusion specs, leaving the target ambiguous. Both reasons now say which is which: the planned import closes the requirement by name at fedora-restricted parity, and the named upstream stays the codec target. Hive-Fix-Attempt: 4/6 Assisted-by: Claude Opus 5 via GitHub Copilot Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Review fixes pushed as One finding could not be pushed. The stale-report prune in - # The seed carries the previous run's reports back with it, and one
- # of those is an attestation rather than a description: a buildroot
- # snapshot says which root *this* run built in. The download below
- # normally replaces it, but preflight is skipped outright on a
- # cleanup-only run and the download is continue-on-error, so the
- # stale file would survive into the manifest as a root nothing here
- # measured. Drop it; only this run's artifact may put one back. The
- # source reports stay: they describe the seeded RPMs, which are still
- # in the repository being published.
+ # The seed carries the previous run's reports back with it, and two
+ # of those are attestations rather than descriptions: a buildroot
+ # snapshot says which root *this* run built in, and the multimedia
+ # closure report says which NEVRAs *this* repository publishes. The
+ # steps that write them normally replace both, but preflight is
+ # skipped outright on a cleanup-only run, the buildroot download is
+ # continue-on-error, and the closure report step is too -- so a stale
+ # file would survive into the manifest describing a root nothing here
+ # measured, or a repository this run no longer publishes. Drop them;
+ # only this run's artifacts may put them back. The source reports
+ # stay: they describe the seeded RPMs, which are still in the
+ # repository being published.
rm -f repository/reports/buildroot-*.json
+ rm -f repository/reports/multimedia-closure.jsonGates run locally on the full change: 🐝 Hive Agent: — hive: agent=scanner backend=copilot model=claude-opus-5 copilot=1.0.88 |
There was a problem hiding this comment.
Reviewed at 78c6af6 (tree checked out; --check, full pytest 839 passed, validate.py, and a byte-compare of reports/multimedia-closure.json all reproduced locally; spec diffed against dist-git 777ed73 — only the two %{?_isa} fixes; all 11 negativo17/rpmfusion URLs in [upstream_spec_sources] resolve).
correctness
- low —
tests/test_multimedia_closure.py:355-359skipstest_a_zstd_compressed_primary_is_readwheneverzstandardis absent, and.github/workflows/validate.yml:53installs onlypytest+pyyaml, so the zstd branch ofprimary_xml()(tools/multimedia_closure.py:256-272) is never executed in CI — the PR body lists "zstd decompression" under test coverage, but only the module-missing path (:374) actually runs there. Addingzstandard==0.25.0to the validate.yml pip line makes the skip go away.
No findings from: security, intent-alignment, style, docs-currency.
Confidence: 5/5 (safe)
— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88
|
Re-checked at the 9/29 head: the 🤖 Generated with Claude Code |
Assisted-by: GPT-6 via GitHub Copilot Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Superseded by maintainer-owned #414, rebased onto current main with an indexed-metadata regression fix and fresh ffmpegthumbnailer source verification. Native required Canary and package compilation must pass before merge. This inventories multimedia closure; #230 and #24 remain open for codec migration and runtime acceptance. |
…414) * feat(terminal): import ptyxis and vte291 recipes for Hummingbird Utah's payload image ships no terminal emulator: ptyxis, gnome-console, kgx and vte291 are in none of the repositories the image enables, and Hummingbird's public repository carries no VTE library at all (20,351 packages checked, zero vte* names). A terminal recipe alone therefore builds but installs nowhere, so this imports the VTE stack underneath it in the same change. - Import ptyxis 50.1 and vte291 0.84.1 from Fedora Rawhide dist-git, with provenance recorded in .hummingbird-upstream.json. - Lock both to their download.gnome.org release tarballs: SHA-512 pinned against the dist-git sources manifests, SHA-256 against the upstream .sha256sum files, Fedora lookaside carried as fallback_urls only. - Stage vte291 at 5 (above gtk4) and ptyxis at 7 (above libadwaita, libportal and vte291), because stage N resolves only against stages below it. - Regenerate .packit.yaml, and move the inventory count assertions from 352 to 354 (351 to 353 for the Hummingbird-supplied skip count). - Record the measurement and the resulting ordering in docs/skills/terminal-emulator-recipes.md, indexed in docs/SKILL.md. Resolves #224 Assisted-by: deepseek/deepseek-v4.1-flash via Claude Code Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: sramkrishna <sramkrishna@users.noreply.github.com> * fix(terminal): drop dist-git automation leftovers from ptyxis and vte291 The imported recipes carried Fedora dist-git's own automation config: .packit.yaml declaring koji_build/bodhi_update jobs against fedora-stable, README.packit, and monitoring.toml. None of that runs in this factory -- Packit here is driven by the rendered top-level .packit.yaml -- so the files are dead config that invites confusion about which one is live. Strip them so packages/ptyxis and packages/vte291 match the shape every other import already has (packages/gtk4, packages/tecla). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * feat(multimedia): source codec closure from negativo17 and rpmfusion (#230) - packages/ffmpegthumbnailer: import recipe and lock source (stage 4) - config/multimedia-closure.toml: document full multimedia closure requirements, set policy to negativo17-multimedia-rpmfusion-nonfree, and map all 12 multimedia override binaries and codec components to named upstream spec sources - tools/multimedia_closure.py: deterministic audit of closure against factory recipes and upstream spec source validation, with zstd primary.xml decompression support - reports/multimedia-closure.json: committed audit report - .github/workflows/validate.yml: add 'Bluefin multimedia closure' check - .github/workflows/rebuild-rpms.yml: install zstandard in publish job and run multimedia closure report with continue-on-error: true - Justfile: add multimedia recipe and include in check - tests: unit test coverage and package count assertion bump (373 -> 374) - docs/skills/multimedia-closure.md: document skill and sourcing contract - docs/SKILL.md, AGENTS.md: index multimedia-closure skill Closes #230 Refs #24 Assisted-by: Antigravity <noreply@google.com> Co-authored-by: Antigravity <noreply@google.com> Signed-off-by: repires <repires@users.noreply.github.com> * fix(multimedia): record recipe provenance, check stale upstream sources, and clarify target parity - Record actual recipe provenance from .hummingbird-upstream.json in resolve() and the committed closure report alongside the target upstream spec source. - Validate that declared upstream_spec_sources point to negativo17 or rpmfusion, and enforce stale check so unused mappings cannot escape detection. - Remove stale gstreamer1-plugins-ugly and gstreamer1-plugins-bad-freeworld from config/multimedia-closure.toml. - Update docs/skills/multimedia-closure.md and config/multimedia-closure.toml policy to document the negativo17/RPM Fusion mappings as target tracking for #230 rather than achieved tree properties. - Add test coverage for recipe provenance inspection, non-negativo17/rpmfusion source rejection, and stale upstream spec source rejection in tests/test_multimedia_closure.py. Refs #230 Refs #24 Signed-off-by: repires <repires@users.noreply.github.com> * fix(multimedia): anchor repomd primary lookup on data type="primary" Anchor repomd primary location lookup on <data type="primary"> to avoid matching non-primary metadata entries such as primary_db if repomd ordering varies. Refs #230 Signed-off-by: repires <repires@users.noreply.github.com> * fix(multimedia): enforce prefix validation on upstream spec source URLs Enforce startswith('https://github.com/negativo17/') and startswith('https://github.com/rpmfusion/') on upstream spec source URLs instead of substring check. Add unit test rejecting fork URLs. Signed-off-by: repires <repires@users.noreply.github.com> * fix(multimedia): measure codec parity separately from the built label Review of #233 found the inventory overstating parity and the skill frontmatter overstating sourcing. - tools/multimedia_closure.py: derive codec_parity per requirement by comparing the recipe's .hummingbird-upstream.json provenance against the upstream spec source named in [upstream_spec_sources]. `built` says only that a recipe emits a binary of that name, and every override recipe is a Fedora dist-git import whose codec set is narrower (mesa passes no -Dvideo-codecs, libheif disables HEVC, intel-media-driver-free is the free variant), so `built` alone read as parity with negativo17 / RPM Fusion. The gate now fails when a provenance divergence carries no declared reason, prints the requirements still short of parity, and counts upstream_parity and fedora_restricted. - config/multimedia-closure.toml: add [parity.<recipe>] stating the restriction each Fedora import carries; stale [parity] keys the transaction does not ask for are rejected like stale [upstream_spec_sources] are. - docs/skills/multimedia-closure.md: reword the frontmatter description from "sourced from" to "mapped to target", matching what the body already says, and document codec_parity. - reports/multimedia-closure.json: regenerate. - tests: cover parity derivation, the undeclared-divergence and stale-[parity] failures, and the repository-level assertion that every override declares parity against its named upstream. Refs #230 Refs #24 Signed-off-by: sec-check[bot] <sec-check[bot]@users.noreply.github.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * fix(multimedia): name the parse failures and correct the comps citations primary.xml parsing could still traceback out of the publish step: both ElementTree.ParseError (a SyntaxError subclass) and zstandard.ZstdError fall outside main()'s except tuple, which is the silent-failure mode the ImportError wrapping already guards against under continue-on-error. Wrap both as ClosureError so the cause is named. Also correct three statements about the inventory: - the comps definition URL pointed at pagure, which is an archived read-only snapshot with no comps-f44.xml.in; the file lives on forge.fedoraproject.org. - gstreamer-plugins-espeak is declared type="conditional" requires="gstreamer", not conditional on espeak. It is still not a requirement, but for the stated reason. - a null codec_parity is "no named upstream spec source", not "an exception": the built entries outside the override set are null too. Finally, say in the skill that this maps targets and does not source from negativo17 or RPM Fusion yet, so #230 is not read as closed by it. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * fix(ci): ensure publish summary closes code fence on multimedia closure report failure * docs: update architecture package counts to 402 for ptyxis and vte291 Assisted-by: Gemini via GitHub Copilot Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * ci(multimedia): port closure reporting and zstandard into publish-repository.yml Assisted-by: Gemini via GitHub Copilot Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * fix(ffmpegthumbnailer): qualify the -libs Requires with %{?_isa} %{?isa} is not a defined macro and expanded to nothing, so the main and devel packages' Requires on -libs lost their arch qualifier. Assisted-by: Claude via omp Signed-off-by: castrojo <jorge.castro@gmail.com> * fix(multimedia): label non-Fedora provenance honestly and correct the closure docs Review follow-ups on the codec closure inventory: - codec_parity called every non-upstream provenance "fedora-restricted", which is only true because each override is a src.fedoraproject.org import today. The label now checks for that, and a mismatch from any other source is "divergent" -- off the named upstream and not explained by Fedora's codec policy. Both fail the same [parity] gate, and the report counts them separately. - The [upstream_spec_sources] fallback keyed by factory source was unreachable: the staleness check rejected any key that was not a requirement name before the lookup could use it. It now accepts recipe names the same way the [parity] check does, so one upstream spec can answer every binary its recipe emits. - The skill doc placed the continue-on-error closure report step in rebuild-rpms.yml; it is in publish-repository.yml, so an operator removing the flag on purpose would have edited the wrong file. - ffmpegthumbnailer.spec uses %{?_isa} where the recorded dist-git commit writes the undefined %{?isa}. The fix is correct but was unmarked against a provenance file claiming a verbatim import, so it now says so. Hive-Fix-Attempt: 3/6 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * fix(multimedia): gate the declared parity status and name the codec target in both exceptions [parity.*].status was declared and never read, so a table could keep saying fedora-restricted after the recipe moved to a third spec and the derivation turned divergent -- a claim about Fedora's codec policy on a spec Fedora never shipped, passing the gate. It now has to equal the derived codec_parity. The gstreamer1-plugin-libav and gstreamer1-plugins-ugly-free exception reasons described a plain Fedora dist-git import while [upstream_spec_sources] named RPM Fusion specs, leaving the target ambiguous. Both reasons now say which is which: the planned import closes the requirement by name at fedora-restricted parity, and the named upstream stays the codec target. Hive-Fix-Attempt: 4/6 Assisted-by: Claude Opus 5 via GitHub Copilot Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * fix(terminal): expose first-import provider edges to the build graph Assisted-by: GPT-6 via GitHub Copilot Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --------- Signed-off-by: sramkrishna <sramkrishna@users.noreply.github.com> Signed-off-by: repires <repires@users.noreply.github.com> Signed-off-by: sec-check[bot] <sec-check[bot]@users.noreply.github.com> Signed-off-by: castrojo <jorge.castro@gmail.com> Co-authored-by: sramkrishna <sramkrishna@users.noreply.github.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: repires <repires@users.noreply.github.com> Co-authored-by: Antigravity <noreply@google.com> Co-authored-by: sec-check[bot] <sec-check[bot]@users.noreply.github.com> Co-authored-by: castrojo <castrojo@users.noreply.github.com> Co-authored-by: castrojo <jorge.castro@gmail.com> Co-authored-by: hive-scanner <hive-scanner@users.noreply.github.com>
Summary
Partially addresses #230 (parent goal #24). This inventories the complete Bluefin multimedia override and codec closure in-factory and maps target upstream spec sources from negativo17 and RPM Fusion, without enabling third-party repositories at build or runtime.
Scope: this measures #230, it does not close it. Nothing here is sourced from negativo17 or RPM Fusion yet — every override recipe still carries
src.fedoraproject.orgprovenance, which is why the report reads0 upstream_parity, 15 fedora_restricted. #230 stays open untilupstream_paritystarts rising; this contract is the measurement that will show it, not the migration itself.ffmpegthumbnailer: Dist-git recipe import from Fedora Rawhide (v2.3.0, commit777ed73), stage 4 inconfig/upstream-sources.json, SHA-512 source-locked, with.packit.yamlentry. The import is not verbatim: the spec carries one local fix, Rawhide's%{?isa}(undefined, so the dependency degrades to an unqualified name) corrected to%{?_isa}, documented in-spec at the two call sites.config/multimedia-closure.toml):config/bluefin-packages.toml, 12 codec tail packages from03-packages.sh, and 16@multimediacomps members).codec_parity = "negativo17-multimedia-rpmfusion-nonfree (target)"tracking parity: source the full codec closure from negativo17 multimedia + RPM Fusion nonfree specs #230 and parity: build the complete Bluefin multimedia override closure #24.intel-gmmlib,intel-mediasdk,intel-vpl-gpu-rt,libheif,libva,libva-intel-media-driver, and all 6mesa-*packages) to an in-factory recipe with a named target upstream spec source fromnegativo17/fedora-multimedia.RPM Fusion.tools/multimedia_closure.py):.hummingbird-upstream.jsonin the resolved report alongside target upstream spec sources.[upstream_spec_sources]and verifies upstream domains againstnegativo17andrpmfusion.primary.xmldecompression viarepomd.xmlindex lookup, raisingClosureErroron missing zstandard module.reports/multimedia-closure.json):multimediarecipe to theJustfile(included incheck) and amultimedia-closurejob to.github/workflows/validate.yml; both runpython3 tools/multimedia_closure.py --check.zstandard==0.25.0in the publish job in.github/workflows/publish-repository.yml(the reusable publish workflow thatrebuild-rpms.ymlcalls) and publishes the closure report there withcontinue-on-error: true.tests/test_multimedia_closure.py(covering synthetic resolution, provenance extraction, stale upstream checking, zstd decompression, workflow zstandard installation, and upstream spec source verification for all 12 override binaries).docs/skills/multimedia-closure.md, indexed indocs/SKILL.mdandAGENTS.md.Test Coverage
just checkgreen (factory-check,validate,multimedia,workflow-quoting,runtime-contract,test).just testgreen (471 passed, 1 skipped).python3 tools/check_workflow_quoting.pyclean across all 12 workflows.Refs #230
Refs #24