Repository navigation
fix(sources): reject new Fedora primary URLs in the source lock - #310
Merged
Merged
Conversation
tools/source_pipeline.py fetches each entry's primary url directly, so the 254 locks pointing at src.fedoraproject.org build from Fedora's lookaside rather than from the project's own release -- the dependency the direct-source pipeline exists to remove. bootstrap_upstream_sources.py already refuses a Fedora host when generating candidates, but nothing enforced that against the committed file, so the set could keep growing. tools/validate.py now reads config/fedora-primary-sources.txt as a ratchet: the packages still on a Fedora primary url are recorded there, anything outside the list fails with the remediation (move Fedora to fallback_urls, which source_pipeline already consults after a transport failure), and an entry re-pinned upstream must be deleted from the list, so it only shrinks. The bulk re-pin itself is unchanged work; this stops the gap widening while it happens. Signed-off-by: scanner <scanner@hive.kubestellar.io>
Contributor
Author
|
Important Held for human review by the hive's ACMM level gate. This PR was opened by the "scanner" agent while Hive policy required a human checkpoint for that agent. Non-outreach agents are held at ACMM L3–L5; the Hive will automatically remove the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
Step 3 of #42 — the one the issue says "stops the gap reopening" and "should land with or before the bulk re-pin".
tools/source_pipeline.pyfetches each lock entry's primaryurldirectly, so an entry pointing atsrc.fedoraproject.orgtakes its payload from Fedora's lookaside instead of the project's own release.tools/bootstrap_upstream_sources.pyalready refuses a Fedora host when generating candidates (FEDORA_HOSTS), but nothing enforced that against the committed file — the set has grown from the 114 of 193 the issue recorded to 254 of 401.tools/validate.pynow readsconfig/fedora-primary-sources.txtas a ratchet:urlfails, with the remediation spelled out (pointurlat the upstream release, keep Fedora infallback_urls, whichsource_pipeline.pyalready consults after an upstream transport failure; use atools/generated_sources.pygenerator where no upstream artifact exists verbatim);Files/functions claimed:
tools/validate.py(fedora_primary_sources,read_fedora_primary_baseline,check_fedora_primary_sources), newconfig/fedora-primary-sources.txt,tests/test_validate.py, plus the rule statement inAGENTS.mdand the gate table indocs/architecture.md. Noconfig/upstream-sources.jsonentry is touched, so this is disjoint from #198, #225 and #233, which only add or edit lock entries.Refs #42 — the bulk re-pin (steps 1, 2 and 4: re-pointing 254 entries at their upstream releases, demoting Fedora to
fallback_urls, and thegenerateentries for gcc/intel-media) is deliberately left open; it is per-package work with its own verification and does not fit one reviewable diff.Tests:
python3 -m pytest tests/ -q— 810 passed, 1 skipped, 2325 subtests.python3 tools/validate.py—validated 401 source RPMs (398 rawhide, 3 upstream). Both new failure modes were exercised against the real tree: an injected Fedora-primary entry and a stale baseline line each exit 1 with their own message.Filed by scanner agent (ACMM L5 — hold-gated mode). Hold-gated: human review required.
— hive: agent=scanner backend=copilot model=claude-opus-5 copilot=1.0.88 requested_by=@castrojo