Skip to content

feat(multimedia): measure recipe closure and honor indexed metadata - #414

Merged
hanthor merged 30 commits into
mainfrom
fix/review-media-closure
Oct 7, 2026
Merged

hanthor merged 30 commits into
mainfrom
fix/review-media-closure

Conversation

@hanthor

@hanthor hanthor commented Oct 7, 2026 •

Copy link
Copy Markdown
Member

Inventory Bluefin's 38 multimedia requirements and their target negativo17/RPM Fusion recipe sources, while recording the current Fedora recipe provenance honestly: 27 recipe-built names, 3 equivalents, 8 exceptions, and zero measured upstream codec parity. This report measures #230 and #24; those migration and runtime acceptance issues remain open.

Import ffmpegthumbnailer 2.3.0, with its fresh upstream archive matching the SHA-512 lock. Reconcile the PR with current main and regenerate Packit and inventory reports. Fix primary metadata selection: an existing repomd.xml is authoritative, so a missing indexed file fails rather than falling back to an older directory entry. XML parsing handles namespace formatting and quoted attributes.

Includes a regression for a missing indexed primary with stale metadata present, plus the multimedia-closure skill learning. At 93dec2c, full just check passed (1,180 tests and 2,616 subtests) and full pre-commit passed after reconciling current main. Pinned-runner ffmpegthumbnailer compilation passed at 025193b: https://github.com/projectbluefin/utah-packages/actions/runs/37572326128. Current-head required native Canary passed: https://github.com/projectbluefin/utah-packages/actions/runs/37578884724.

Maintainer-owned replacement for #233; native required Canary passed before merge. The publish-time report remains advisory; it does not establish codec functionality.

Refs #230. Refs #24.

sramkrishna and others added 23 commits September 23, 2026 17:00
Utah's payload image ships no terminal emulator: ptyxis, gnome-console,
kgx and vte291 are in none of the repositories the image enables, and
Hummingbird's public repository carries no VTE library at all (20,351
packages checked, zero vte* names). A terminal recipe alone therefore
builds but installs nowhere, so this imports the VTE stack underneath it
in the same change.

- Import ptyxis 50.1 and vte291 0.84.1 from Fedora Rawhide dist-git, with
  provenance recorded in .hummingbird-upstream.json.
- Lock both to their download.gnome.org release tarballs: SHA-512 pinned
  against the dist-git sources manifests, SHA-256 against the upstream
  .sha256sum files, Fedora lookaside carried as fallback_urls only.
- Stage vte291 at 5 (above gtk4) and ptyxis at 7 (above libadwaita,
  libportal and vte291), because stage N resolves only against stages
  below it.
- Regenerate .packit.yaml, and move the inventory count assertions from
  352 to 354 (351 to 353 for the Hummingbird-supplied skip count).
- Record the measurement and the resulting ordering in
  docs/skills/terminal-emulator-recipes.md, indexed in docs/SKILL.md.

Resolves #224

Assisted-by: deepseek/deepseek-v4.1-flash via Claude Code

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: sramkrishna <sramkrishna@users.noreply.github.com>
The imported recipes carried Fedora dist-git's own automation config:
.packit.yaml declaring koji_build/bodhi_update jobs against fedora-stable,
README.packit, and monitoring.toml. None of that runs in this factory --
Packit here is driven by the rendered top-level .packit.yaml -- so the
files are dead config that invites confusion about which one is live.

Strip them so packages/ptyxis and packages/vte291 match the shape every
other import already has (packages/gtk4, packages/tecla).

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…230)

- packages/ffmpegthumbnailer: import recipe and lock source (stage 4)
- config/multimedia-closure.toml: document full multimedia closure requirements,
  set policy to negativo17-multimedia-rpmfusion-nonfree, and map all 12
  multimedia override binaries and codec components to named upstream spec sources
- tools/multimedia_closure.py: deterministic audit of closure against factory recipes
  and upstream spec source validation, with zstd primary.xml decompression support
- reports/multimedia-closure.json: committed audit report
- .github/workflows/validate.yml: add 'Bluefin multimedia closure' check
- .github/workflows/rebuild-rpms.yml: install zstandard in publish job and run
  multimedia closure report with continue-on-error: true
- Justfile: add multimedia recipe and include in check
- tests: unit test coverage and package count assertion bump (373 -> 374)
- docs/skills/multimedia-closure.md: document skill and sourcing contract
- docs/SKILL.md, AGENTS.md: index multimedia-closure skill

Closes #230
Refs #24

Assisted-by: Antigravity <noreply@google.com>
Co-authored-by: Antigravity <noreply@google.com>
Signed-off-by: repires <repires@users.noreply.github.com>
…es, and clarify target parity

- Record actual recipe provenance from .hummingbird-upstream.json in
  resolve() and the committed closure report alongside the target upstream spec source.
- Validate that declared upstream_spec_sources point to negativo17 or
  rpmfusion, and enforce stale check so unused mappings cannot escape detection.
- Remove stale gstreamer1-plugins-ugly and gstreamer1-plugins-bad-freeworld
  from config/multimedia-closure.toml.
- Update docs/skills/multimedia-closure.md and config/multimedia-closure.toml
  policy to document the negativo17/RPM Fusion mappings as target tracking for
  #230 rather than achieved tree properties.
- Add test coverage for recipe provenance inspection, non-negativo17/rpmfusion
  source rejection, and stale upstream spec source rejection in
  tests/test_multimedia_closure.py.

Refs #230
Refs #24

Signed-off-by: repires <repires@users.noreply.github.com>
Anchor repomd primary location lookup on <data type="primary"> to avoid
matching non-primary metadata entries such as primary_db if repomd
ordering varies.

Refs #230

Signed-off-by: repires <repires@users.noreply.github.com>
Enforce startswith('https://github.com/negativo17/') and startswith('https://github.com/rpmfusion/')
on upstream spec source URLs instead of substring check. Add unit test rejecting fork URLs.

Signed-off-by: repires <repires@users.noreply.github.com>
Review of #233 found the inventory overstating parity and the skill
frontmatter overstating sourcing.

- tools/multimedia_closure.py: derive codec_parity per requirement by
  comparing the recipe's .hummingbird-upstream.json provenance against the
  upstream spec source named in [upstream_spec_sources]. `built` says only
  that a recipe emits a binary of that name, and every override recipe is a
  Fedora dist-git import whose codec set is narrower (mesa passes no
  -Dvideo-codecs, libheif disables HEVC, intel-media-driver-free is the free
  variant), so `built` alone read as parity with negativo17 / RPM Fusion.
  The gate now fails when a provenance divergence carries no declared reason,
  prints the requirements still short of parity, and counts upstream_parity
  and fedora_restricted.
- config/multimedia-closure.toml: add [parity.<recipe>] stating the
  restriction each Fedora import carries; stale [parity] keys the transaction
  does not ask for are rejected like stale [upstream_spec_sources] are.
- docs/skills/multimedia-closure.md: reword the frontmatter description from
  "sourced from" to "mapped to target", matching what the body already says,
  and document codec_parity.
- reports/multimedia-closure.json: regenerate.
- tests: cover parity derivation, the undeclared-divergence and stale-[parity]
  failures, and the repository-level assertion that every override declares
  parity against its named upstream.

Refs #230
Refs #24

Signed-off-by: sec-check[bot] <sec-check[bot]@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
primary.xml parsing could still traceback out of the publish step: both
ElementTree.ParseError (a SyntaxError subclass) and zstandard.ZstdError
fall outside main()'s except tuple, which is the silent-failure mode the
ImportError wrapping already guards against under continue-on-error.
Wrap both as ClosureError so the cause is named.

Also correct three statements about the inventory:

- the comps definition URL pointed at pagure, which is an archived
  read-only snapshot with no comps-f44.xml.in; the file lives on
  forge.fedoraproject.org.
- gstreamer-plugins-espeak is declared type="conditional"
  requires="gstreamer", not conditional on espeak. It is still not a
  requirement, but for the stated reason.
- a null codec_parity is "no named upstream spec source", not "an
  exception": the built entries outside the override set are null too.

Finally, say in the skill that this maps targets and does not source from
negativo17 or RPM Fusion yet, so #230 is not read as closed by it.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
# Conflicts:
#	tests/test_package_inventory.py
#	tests/test_packit_srpm.py
#	tests/test_render_packit_config.py
#	tests/test_source_inventory.py
Assisted-by: Gemini via GitHub Copilot
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
# Conflicts:
#	.github/workflows/rebuild-rpms.yml
#	Justfile
#	tests/test_package_inventory.py
#	tests/test_packit_srpm.py
#	tests/test_render_packit_config.py
#	tests/test_source_inventory.py
…ository.yml

Assisted-by: Gemini via GitHub Copilot
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
%{?isa} is not a defined macro and expanded to nothing, so the main and devel packages' Requires on -libs lost their arch qualifier.

Assisted-by: Claude via omp
Signed-off-by: castrojo <jorge.castro@gmail.com>
… closure docs

Review follow-ups on the codec closure inventory:

- codec_parity called every non-upstream provenance "fedora-restricted",
  which is only true because each override is a src.fedoraproject.org
  import today. The label now checks for that, and a mismatch from any
  other source is "divergent" -- off the named upstream and not explained
  by Fedora's codec policy. Both fail the same [parity] gate, and the
  report counts them separately.
- The [upstream_spec_sources] fallback keyed by factory source was
  unreachable: the staleness check rejected any key that was not a
  requirement name before the lookup could use it. It now accepts recipe
  names the same way the [parity] check does, so one upstream spec can
  answer every binary its recipe emits.
- The skill doc placed the continue-on-error closure report step in
  rebuild-rpms.yml; it is in publish-repository.yml, so an operator
  removing the flag on purpose would have edited the wrong file.
- ffmpegthumbnailer.spec uses %{?_isa} where the recorded dist-git commit
  writes the undefined %{?isa}. The fix is correct but was unmarked
  against a provenance file claiming a verbatim import, so it now says so.

Hive-Fix-Attempt: 3/6

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…arget in both exceptions

[parity.*].status was declared and never read, so a table could keep saying
fedora-restricted after the recipe moved to a third spec and the derivation
turned divergent -- a claim about Fedora's codec policy on a spec Fedora never
shipped, passing the gate. It now has to equal the derived codec_parity.

The gstreamer1-plugin-libav and gstreamer1-plugins-ugly-free exception reasons
described a plain Fedora dist-git import while [upstream_spec_sources] named
RPM Fusion specs, leaving the target ambiguous. Both reasons now say which is
which: the planned import closes the requirement by name at fedora-restricted
parity, and the named upstream stays the codec target.

Hive-Fix-Attempt: 4/6

Assisted-by: Claude Opus 5 via GitHub Copilot
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Assisted-by: GPT-6 via GitHub Copilot

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Assisted-by: GPT-6 via GitHub Copilot

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
hanthor and others added 6 commits October 7, 2026 04:43
Assisted-by: GPT-6 via GitHub Copilot

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Assisted-by: GPT-6 via GitHub Copilot
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Assisted-by: GPT-6 via GitHub Copilot
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Assisted-by: GPT-6 via GitHub Copilot
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Assisted-by: GPT-6 via GitHub Copilot
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Assisted-by: GPT-6 via GitHub Copilot
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@hanthor
hanthor changed the base branch from main to fix/review-terminal-closure October 7, 2026 05:40
@hanthor

hanthor commented Oct 7, 2026

Copy link
Copy Markdown
Member Author

Stacked on #413 to serialize concurrent recipe imports and their generated inventory reports. The combined inventory passes 1,180 tests, 2,616 subtests and full pre-commit. Merge #413 to main first, then retarget this PR to main; do not merge into the feature branch. Earlier ffmpegthumbnailer compilation passed; the current required Canary reruns on this head.

@hanthor
hanthor changed the base branch from fix/review-terminal-closure to main October 7, 2026 05:42
Assisted-by: GPT-6 via GitHub Copilot
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@hanthor
hanthor merged commit fd8282c into main Oct 7, 2026
169 checks passed
hivecommons-hive Bot added a commit to kylerankin/utah-packages that referenced this pull request Oct 29, 2026
The ffmpeg recipe was imported via 6ed99b9 and reworked in projectbluefin#414, which
the ffmpegthumbnailer entries already cite; match the [resolved]
provenance convention instead of self-referencing this PR.

Hive-Fix-Attempt: 2/6
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
hivecommons-hive Bot added a commit to kylerankin/utah-packages that referenced this pull request Oct 29, 2026
…ries

ffmpeg's recipe was first imported in projectbluefin#70; projectbluefin#414 only added
ffmpegthumbnailer, so keep pr = 414 just for the thumbnailer names.

Hive-Fix-Attempt: 3/6
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants