Repository navigation
Conversation
…230) - packages/ffmpegthumbnailer: import recipe and lock source (stage 4) - config/multimedia-closure.toml: document full multimedia closure requirements, set policy to negativo17-multimedia-rpmfusion-nonfree, and map all 12 multimedia override binaries and codec components to named upstream spec sources - tools/multimedia_closure.py: deterministic audit of closure against factory recipes and upstream spec source validation, with zstd primary.xml decompression support - reports/multimedia-closure.json: committed audit report - .github/workflows/validate.yml: add 'Bluefin multimedia closure' check - .github/workflows/rebuild-rpms.yml: install zstandard in publish job and run multimedia closure report with continue-on-error: true - Justfile: add multimedia recipe and include in check - tests: unit test coverage and package count assertion bump (373 -> 374) - docs/skills/multimedia-closure.md: document skill and sourcing contract - docs/SKILL.md, AGENTS.md: index multimedia-closure skill Closes #230 Refs #24 Assisted-by: Antigravity <noreply@google.com> Co-authored-by: Antigravity <noreply@google.com> Signed-off-by: repires <repires@users.noreply.github.com>
…es, and clarify target parity - Record actual recipe provenance from .hummingbird-upstream.json in resolve() and the committed closure report alongside the target upstream spec source. - Validate that declared upstream_spec_sources point to negativo17 or rpmfusion, and enforce stale check so unused mappings cannot escape detection. - Remove stale gstreamer1-plugins-ugly and gstreamer1-plugins-bad-freeworld from config/multimedia-closure.toml. - Update docs/skills/multimedia-closure.md and config/multimedia-closure.toml policy to document the negativo17/RPM Fusion mappings as target tracking for #230 rather than achieved tree properties. - Add test coverage for recipe provenance inspection, non-negativo17/rpmfusion source rejection, and stale upstream spec source rejection in tests/test_multimedia_closure.py. Refs #230 Refs #24 Signed-off-by: repires <repires@users.noreply.github.com>
Anchor repomd primary location lookup on <data type="primary"> to avoid matching non-primary metadata entries such as primary_db if repomd ordering varies. Refs #230 Signed-off-by: repires <repires@users.noreply.github.com>
Enforce startswith('https://github.com/negativo17/') and startswith('https://github.com/rpmfusion/')
on upstream spec source URLs instead of substring check. Add unit test rejecting fork URLs.
Signed-off-by: repires <repires@users.noreply.github.com>
Review of #233 found the inventory overstating parity and the skill frontmatter overstating sourcing. - tools/multimedia_closure.py: derive codec_parity per requirement by comparing the recipe's .hummingbird-upstream.json provenance against the upstream spec source named in [upstream_spec_sources]. `built` says only that a recipe emits a binary of that name, and every override recipe is a Fedora dist-git import whose codec set is narrower (mesa passes no -Dvideo-codecs, libheif disables HEVC, intel-media-driver-free is the free variant), so `built` alone read as parity with negativo17 / RPM Fusion. The gate now fails when a provenance divergence carries no declared reason, prints the requirements still short of parity, and counts upstream_parity and fedora_restricted. - config/multimedia-closure.toml: add [parity.<recipe>] stating the restriction each Fedora import carries; stale [parity] keys the transaction does not ask for are rejected like stale [upstream_spec_sources] are. - docs/skills/multimedia-closure.md: reword the frontmatter description from "sourced from" to "mapped to target", matching what the body already says, and document codec_parity. - reports/multimedia-closure.json: regenerate. - tests: cover parity derivation, the undeclared-divergence and stale-[parity] failures, and the repository-level assertion that every override declares parity against its named upstream. Refs #230 Refs #24 Signed-off-by: sec-check[bot] <sec-check[bot]@users.noreply.github.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
primary.xml parsing could still traceback out of the publish step: both ElementTree.ParseError (a SyntaxError subclass) and zstandard.ZstdError fall outside main()'s except tuple, which is the silent-failure mode the ImportError wrapping already guards against under continue-on-error. Wrap both as ClosureError so the cause is named. Also correct three statements about the inventory: - the comps definition URL pointed at pagure, which is an archived read-only snapshot with no comps-f44.xml.in; the file lives on forge.fedoraproject.org. - gstreamer-plugins-espeak is declared type="conditional" requires="gstreamer", not conditional on espeak. It is still not a requirement, but for the stated reason. - a null codec_parity is "no named upstream spec source", not "an exception": the built entries outside the override set are null too. Finally, say in the skill that this maps targets and does not source from negativo17 or RPM Fusion yet, so #230 is not read as closed by it. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…re report failure
# Conflicts: # .github/workflows/rebuild-rpms.yml # Justfile # tests/test_package_inventory.py # tests/test_packit_srpm.py # tests/test_render_packit_config.py # tests/test_source_inventory.py
…ository.yml Assisted-by: Gemini via GitHub Copilot Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
%{?isa} is not a defined macro and expanded to nothing, so the main and devel packages' Requires on -libs lost their arch qualifier.
Assisted-by: Claude via omp
Signed-off-by: castrojo <jorge.castro@gmail.com>
🐝 Possible duplicateThis PR changes exactly the same files as #233, which was opened first:
Evidence — identical changed-file set (22 file(s)):
This is a suggestion, not a verdict. Hive will not close, label, approve or merge anything here — a human decides. It was produced by comparing changed-file sets across open PRs, which is a candidate generator: PRs that share a file are not necessarily the same work. Here the patches DIFFER, so this is the weaker tier: dependency-bump PRs that edit one shared manifest, and unrelated fixes to one busy file, both land in it. Read the diffs before acting. |
|
A note on #302 versus #233, since both are open and look identical. They are no longer the same. #302 is frozen at ce15643. #233 has two more commits on top: 6b396ce (labels non-Fedora provenance honestly and fixes the closure docs) and 78c6af6 (validates the declared parity status). The GitHub compare ce15643...78c6af6 shows #233 two commits ahead across 6 files. Merging #302 as it stands would drop those two review fixes. Also, the 09-29 note on #233 says #302 has merged. It has not; it is still open, and both PRs now conflict with main. So whichever branch is kept, it needs 78c6af6 and a rebase before it can land. |
There was a problem hiding this comment.
This carry is now two commits behind #233. The body says it carries #233 unchanged at head ce15643, and that was true when it was cut — ce15643 is in #233's history. Since then #233 has moved to 78c6af6, adding:
6b396cefix(multimedia): label non-Fedora provenance honestly …78c6af6fix(multimedia): gate the declared parity status and name the codec t…
Concretely, comparing the two diffs (same 22-file set):
tools/multimedia_closure.pyin #233 is 376 lines vs 357 here; #233 adds a third parity labeldivergentand fails the check when[parity.<recipe>].statusdisagrees with the derived parity. This branch has onlyupstream_parity/fedora_restrictedand no status gate.docs/skills/multimedia-closure.mdandconfig/multimedia-closure.tomlhere still carry the older text forgstreamer1-plugin-libav/gstreamer1-plugins-ugly(RPM Fusion named as the sourced upstream) that #233 reworded to make the Fedora-dist-git closing path andfedora-restrictedparity explicit.
So the two PRs are the same change but no longer the same code, and only one can land. Flagging for a maintainer (@castrojo, since you own the carry): either refresh this branch to 78c6af6 so the Canary result reflects what #233 actually is, or — if the Canary run has served its purpose — close this one in favour of #233. I have not closed anything.
The open scope question in the body (inventory-only progress on #230) is unchanged and still needs @hanthor.
Confidence: 3/5 (needs attention) — 1 medium finding; 1 perspective requires a human decision
— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88
|
Both review findings are fixed and verified locally, but the commit could not be pushed: it touches 1. Stale seeded rm -f repository/reports/buildroot-*.json
+ # Same shape, same reason: the multimedia closure report names the
+ # NEVRAs *this* publish resolved. Its step is continue-on-error, so
+ # a ClosureError leaves nothing behind to overwrite the seeded copy
+ # and the previous run's NEVRAs would ship in this image as if they
+ # described it -- the "committed stale" outcome that step exists to
+ # avoid. Drop it; only a report this run produced may be published.
+ rm -f repository/reports/multimedia-closure.json
2. - name: Install zstandard
- run: pip install --disable-pip-version-check --quiet 'zstandard==0.25.0'
+ run: |
+ pip install --disable-pip-version-check --quiet \
+ --require-hashes --no-deps -r .github/requirements/zstandard.txtVerified the hashed install resolves and imports. Docs: Gates run locally on the fix: Patch to apply (
|
Carries @repires's #233 unchanged (head ce15643). That branch lives on a fork, so its Canary stops at the fork guard (run 36499668401); this in-repo branch lets the Canary run, as #137/#138 did for #109/#100.
What #233 does: adds
config/multimedia-closure.toml+tools/multimedia_closure.pyto inventory Bluefin's multimedia override and codec closure (38 requirements) and map each to a factory recipe and a named negativo17 / RPM Fusion target spec source, without enabling third-party repositories; importsffmpegthumbnailerfrom Fedora Rawhide; adds amultimedia-closurevalidate job and a non-blocking (continue-on-error) closure report inpublish-repository.yml. Addresses, does not close, #230.State of review on #233: hanthor's 09-25 review ("looks solid") listed rebase,
%{?isa}->%{?_isa}, zstandard hash-pin (minor) and scope. Rebase and%{?_isa}are done (a8d4d40). Merged onto current main (ca55123) locally:pytest tests834 passed / 2 skipped.Still open, for @hanthor: his scope question -- whether inventory-only (no override migrated off Fedora dist-git yet) is acceptable progress on #230. Not merging this until a maintainer answers that; the Canary run here only removes the fork-guard blocker.