Skip to content

ci: pin zstandard in the prepare job (carries #109) - #137

Merged
hanthor merged 2 commits into
mainfrom
fix/rebuild-rpms-pin-zstandard
Sep 18, 2026
Merged

hanthor merged 2 commits into
mainfrom
fix/rebuild-rpms-pin-zstandard

Conversation

@hanthor

@hanthor hanthor commented Sep 18, 2026

Copy link
Copy Markdown
Member

Carries @mendezr's #109 onto today's main. That PR's branch lives on a fork and conflicts with the prepare job as rewritten by #70 and #133, so this is its commit plus a merge of main with the one line re-applied:

- name: Install zstandard
  run: pip install --disable-pip-version-check --quiet 'zstandard==0.25.0'

Reason unchanged from #109: prepare runs with contents: write, id-token: write and packages: write, and an unpinned pip install there lets a bad PyPI release run at install time with those tokens in reach. Same convention as pytest==8.3.5 in validate.yml.

Verified: workflow quoting check clean, 316 tests pass on the merged tree.

🤖 Generated with Claude Code

https://claude.ai/code/session_01W6BYLUD6KBzF8rBFXKjP7M


Generated by Claude Code

mendezr and others added 2 commits September 14, 2026 10:49
Pin zstandard==0.25.0 instead of unpinned 'pip install zstandard'.
This prevents a compromised PyPI release of zstandard from running
arbitrary code at install time in the prepare job, which holds
contents/id-token/packages write permissions and feeds the RPM build
stages. Resolves issue #105.

Signed-off-by: mendezr <mendezr@users.noreply.github.com>
…re job

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01W6BYLUD6KBzF8rBFXKjP7M
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants