Skip to content

ci: pin zstandard version in rebuild-rpms prepare job (#105) - #109

Merged
1 commit merged into
projectbluefin:mainfrom
mendezr:fix/rebuild-rpms-pin-zstandard
Sep 18, 2026
Merged

1 commit merged into
projectbluefin:mainfrom
mendezr:fix/rebuild-rpms-pin-zstandard

Conversation

@mendezr

@mendezr mendezr commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

Fixes #105

Summary

Pins zstandard==0.25.0 in the .github/workflows/rebuild-rpms.yml prepare job, replacing the unpinned pip install --quiet zstandard.

Why

The prepare job installs zstandard before the matrix resolution that feeds the RPM build stages, in a workflow whose top-level permissions include contents: write, id-token: write, and packages: write. An unpinned pip install zstandard lets a compromised PyPI release of zstandard run arbitrary code at install time, which could mint OIDC tokens and sign repository metadata.

Pinning the exact version prevents a malicious release from being pulled in and matches the existing version-pin convention used elsewhere in this repo (e.g. pip install pytest==8.3.5 in validate.yml).

Test plan

  • Workflow change only; the pinned version installs cleanly on the ubuntu-24.04 runner's Python.

— hive: backend=goose model=deepseek/deepseek-v4-flash-0731

🐝 Hive Agent: contributor | SHA: 13c7410

Pin zstandard==0.25.0 instead of unpinned 'pip install zstandard'.
This prevents a compromised PyPI release of zstandard from running
arbitrary code at install time in the prepare job, which holds
contents/id-token/packages write permissions and feeds the RPM build
stages. Resolves issue projectbluefin#105.

Signed-off-by: mendezr <mendezr@users.noreply.github.com>
@hanthor

hanthor commented Sep 18, 2026

Copy link
Copy Markdown
Member

The one-line pin is right and I'll merge it, but the branch conflicts with main now — rebuild-rpms.yml's prepare job was rewritten by #70 and #133 (the Install zstandard step still exists, at line 121). A rebase that re-applies the same line is all it needs.


Generated by Claude Code

@hanthor

hanthor commented Sep 18, 2026

Copy link
Copy Markdown
Member

Your branch is on a fork so I couldn't push the rebase to it; #137 carries this commit (authorship preserved) onto today's main with the pin re-applied to the current prepare job, and is merging now. Closing this one in its favour — thanks.


Generated by Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[sec-check] rebuild-rpms.yml pip-installs zstandard with no version pin or hash

2 participants