Repository navigation
ci: pin zstandard version in rebuild-rpms prepare job (#105) - #109
Merged
1 commit merged intoSep 18, 2026
Merged
1 commit merged into
1 commit merged into
Conversation
Pin zstandard==0.25.0 instead of unpinned 'pip install zstandard'. This prevents a compromised PyPI release of zstandard from running arbitrary code at install time in the prepare job, which holds contents/id-token/packages write permissions and feeds the RPM build stages. Resolves issue projectbluefin#105. Signed-off-by: mendezr <mendezr@users.noreply.github.com>
Member
|
The one-line pin is right and I'll merge it, but the branch conflicts with Generated by Claude Code |
Member
|
Your branch is on a fork so I couldn't push the rebase to it; #137 carries this commit (authorship preserved) onto today's Generated by Claude Code |
4606ae9
This was referenced Sep 29, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #105
Summary
Pins
zstandard==0.25.0in the.github/workflows/rebuild-rpms.ymlprepare job, replacing the unpinnedpip install --quiet zstandard.Why
The prepare job installs zstandard before the matrix resolution that feeds the RPM build stages, in a workflow whose top-level permissions include
contents: write,id-token: write, andpackages: write. An unpinnedpip install zstandardlets a compromised PyPI release of zstandard run arbitrary code at install time, which could mint OIDC tokens and sign repository metadata.Pinning the exact version prevents a malicious release from being pulled in and matches the existing version-pin convention used elsewhere in this repo (e.g.
pip install pytest==8.3.5in validate.yml).Test plan
ubuntu-24.04runner's Python.— hive: backend=goose model=deepseek/deepseek-v4-flash-0731
🐝 Hive Agent:
contributor| SHA:13c7410