Skip to content

fix(ci): report nothing for a cancelled run instead of every package as failed (carries #271) - #300

Merged
hanthor merged 4 commits into
mainfrom
carry/271-report-skips-cancelled-run
Sep 29, 2026
Merged

hanthor merged 4 commits into
mainfrom
carry/271-report-skips-cancelled-run

Conversation

@castrojo

Copy link
Copy Markdown
Contributor

Carries @clubanderson's #271 unchanged (head f6d889c, the commit @Danathar approved). That branch lives on a fork, so its Canary stops at the fork guard ("a fork pull request cannot publish the canary image; a maintainer must push this branch to the repository", run 36499664856); this in-repo branch lets the Canary actually run, the same way #137/#138 carried #109/#100.

What #271 does: the report job in rebuild-rpms.yml runs on !cancelled() instead of always(), the same shape publish uses, so a hand-cancelled run (e.g. 36205360031, which filed #267 naming 215 packages that never failed) reports nothing, while a failed wave or failed publish gate still reports. tools/publish_gate.py assert_gate_enforced now rejects always() on report and requires it to wait for prepare, publish and every wave.

Review: approved on #271 by Danathar at f6d889c (unit tests 694 OK, publish_gate.py exit 0, and reverting to always() is rejected by the gate). No changes here beyond #271's commits.

Closes #271 when merged.

clubanderson and others added 4 commits September 26, 2026 01:28
…as failed

Run 36205360031 was cancelled by hand one minute into rebuild0. No wave
had uploaded an rpm-s<stage>-<package> artifact yet, and the report job
ran on always(), so it read that silence as 215 failed packages and filed
the "Factory: packages failing on main" tracking issue naming the whole
build list (#267).

A cancelled run has no verdict. Gate report on !cancelled(), the same
shape publish already uses: a failed wave or a failed publish gate still
reports and still drives the tracking issue, a cancellation reports
nothing. assert_gate_enforced now rejects always() on the report job and
requires it to wait for prepare, precedence, publish and every wave, and
the workflow test covers both.

Skill write-back: repeated-mistakes gains entry 21 (this is the second
time the tracking issue spoke for a run that decided nothing, after the
canary-on-main case in b858eee), and package-build-cache no longer claims
runs are never cancelled -- a merge never cancels one, a human can.

Fixes #267

Hive-Run: #267
Hive-Plan: factory-report-cancelled-run
Hive-Spec: factory-report#cancelled-run-no-verdict
Assisted-by: Claude Fable 5.1 via GitHub Copilot
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: Andrew Anderson <andy@clubanderson.com>
@hivecommons-hive

Copy link
Copy Markdown
Contributor

🐝 Possible duplicate

This PR changes exactly the same files as #271, which was opened first:

The diff here is byte-identical to #271.

Evidence — identical changed-file set, identical diff (5 file(s)):

  • .github/workflows/rebuild-rpms.yml
  • docs/skills/package-build-cache.md
  • docs/skills/repeated-mistakes.md
  • tests/test_incremental_publish.py
  • tools/publish_gate.py

This is a suggestion, not a verdict. Hive will not close, label, approve or merge anything here — a human decides.

It was produced by comparing changed-file sets across open PRs, which is a candidate generator: PRs that share a file are not necessarily the same work. In this case the patches are byte-identical, which is the strongest corroboration available without reading intent — but confirm before closing anything.

@castrojo

Copy link
Copy Markdown
Contributor Author

Canary is green on f6d889c (run 36512018639); every required check passes and the PR is CLEAN. Not merging without an approval on this PR itself: @Danathar, you approved these exact commits on #271 -- an approval here lands it.

@hanthor
hanthor merged commit 6f7a2be into main Sep 29, 2026
185 of 186 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants