Repository navigation
feat(e2e): boot the e2e VM with SELinux enforcing by default - #1119
Conversation
Flip selinux_enforcing default to true in e2e.yml and manual.yml so the GHA VM is qualified with the candidate's own SELinux mode instead of selinux=0. Callers can still pass false for the legacy boot. Closes #1024 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
bf473eb
ℹ️ Sentinel notice — informational; author is trusted (hive agent), merge is not blockedHive flagged this PR (author @hivecommons-hive[bot], head
Hive did not add the |
There was a problem hiding this comment.
Decision needed: @castrojo should decide whether e2e.yml's selinux_enforcing default may flip to true now, before any hosted manual.yml run has exercised enforcing mode on a Bluefin image (the precondition #1024 and #1021 set for the flip).
Conclusion: the diff is mechanically correct and small, but it performs the rollout step that the linked issue explicitly reserved for a maintainer after a hosted qualification run, and that run has not happened. This needs a maintainer's go/no-go, not a code fix.
Evidence
.github/workflows/e2e.yml:76changesdefault: false→true;e2e.yml:566-569then stops appendingselinux=0for every caller that does not pass the input.manual.yml:27flips the same way. Doc edits inSKILL.mdandreferences/selinux-enforcing.mdmatch the new behaviour.- The text this PR deletes at
e2e.yml:73-74read "Defaults to false until a hosted run qualifies the path and the rollout plan in #1021 turns it on." On #1024 the hive's own 2026-11-07 status comment states that everymanual.ymlrun since #1109 merged useddakota@sha256:e9918fd7, which reportsexpected=unsupported after-boot=Disabled, so "none of those runs exercised enforcing mode, the AVC gate or the canary", and asks a maintainer to run smoke then lifecycle on a Bluefin image before deciding the default in #1021. That evidence is still absent. - Blast radius: callers pin
e2e.ymlby commit (e.g. utah'spost-testing-e2e.yml:349usese2e.yml@<sha>and renovate bumps it — utah#1153 is one such bump in flight). After this merges, the next routine digest bump in each consumer silently turns enforcing on for that repo's release gate with no change on their side, so a first-time AVC denial on Bluefin's policy would surface as a red release gate rather than a manual run. - Issue linking: the body says
Closes #1024, but #1024's remaining checklist item is the hosted run, and the default flip is tracked in #1021. If this lands as-is,Refs #1021is the accurate link and #1024 should stay open until the run is recorded.
If the maintainer wants the flip now anyway, the code is fine as written. Otherwise the clean path is: dispatch manual.yml with selinux_enforcing=true on a Bluefin image (smoke, then lifecycle), attach the run IDs to #1021, then merge this.
I have not changed anything on this PR.
Confidence: 2/5 (needs attention) — 1 high finding; 1 medium finding
— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88
|
Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor. Your move: this pull request is parked for your decision ( Reply on this PR with one of these:
A GitHub Approve review on the current head does the same as approving here, except on a PR you opened: GitHub refuses that. Only a trusted merger on this hive can approve. |
Update selinux_qualify unit tests for the flipped selinux_enforcing default and reword the KERNEL_ARGS comment so the install step keeps a single selinux=0 occurrence. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
Hive will not merge this PR: it changes path(s) listed in
Hive added the |
|
Needs a decision, not a merge:
Head: verdict approved @bf473eb, 7/7 checks green, soak 27m0s of 30m0s, labels: hold. What to do: The hive set Clear the cause and the hive re-evaluates on its next pass; the stage moves to |
Danathar
left a comment
There was a problem hiding this comment.
Reviewed: flips selinux_enforcing default to true in e2e.yml and manual.yml with a false opt-out; images without a policy store stay unsupported/passing. Requested by castrojo.
…1138) #1119's labeling step runs the candidate image with -v /mnt/root:/mnt/root and -v SELINUX_DIR:SELINUX_DIR. In ostree-style images /mnt and /home are symlinks into /var that the image does not populate, so podman cannot create the mount point and the step fails before any test runs: utah:testing stopped with "crun: creating `/mnt/root`: openat2 `mnt`: No such file or directory" (manual run 42919494173). dakota:testing is not affected, so the v1 gate passed. Mount the disk at /harness/root and the list at /harness/list, and rewrite /mnt/root to /harness/root in setfiles' root, the file_contexts path and every list entry, so the same files are labeled. Assisted-by: Claude Opus 5.5 via Claude Code Claude-Session: https://claude.ai/code/session_01WcWm7qQa538Zjcuvv8jBtn Signed-off-by: Danathar <Danathar@users.noreply.github.com> Co-authored-by: Danathar <Danathar@users.noreply.github.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Summary: Each desktop run now starts its virtual machine with Linux's SELinux security layer switched on and enforcing by default. Before, runs switched SELinux off unless someone asked for it, so a build with broken security rules could still pass. The safety checks for this mode landed in #1109: file labeling, a check that SELinux really is enforcing, and a gate that fails on unexpected blocked actions. This change makes enforcing the normal path, and anyone debugging can still switch back to the old behavior.
e2e.yml:selinux_enforcinginput defaultfalse→true; description and kernel-args comment updated.selinux=0is now appended only when a caller passesfalse.manual.yml: dispatch input default"false"→"true".unsupportedbyselinux_qualify.py expected-modeand keep passing, so non-SELinux callers are not affected.docs/skills/ci-ops/e2e-workflow/SKILL.mdandreferences/selinux-enforcing.mdnow describe the lane as on by default, withfalseas a triage-only fallback..github/workflows/e2e.yml, so a maintainer must merge it.Closes #1024
— hive: agent=scanner backend=copilot model=claude-opus-5.5 copilot=1.0.88 requested_by=@castrojo